From 2a7246884486cc1885a369298efbc6108db78be3 Mon Sep 17 00:00:00 2001
From: fallenoak <git@fallenoak.me>
Date: Mon, 20 Feb 2023 12:42:59 -0600
Subject: [PATCH] fix(ui): correct id handling errors in CreateFrame script
 function

---
 src/ui/ScriptFunctionsSimpleFrame.cpp | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/ui/ScriptFunctionsSimpleFrame.cpp b/src/ui/ScriptFunctionsSimpleFrame.cpp
index 33f9196..b1ebcf7 100644
--- a/src/ui/ScriptFunctionsSimpleFrame.cpp
+++ b/src/ui/ScriptFunctionsSimpleFrame.cpp
@@ -100,13 +100,15 @@ int32_t Script_CreateFrame(lua_State* L) {
     }
 
     if (lua_isstring(L, 5)) {
-        const char* id = lua_tolstring(L, 5, 0);
-        frameNode.SetAttribute("id", id);
+        const char* idStr = lua_tolstring(L, 5, nullptr);
+        frameNode.SetAttribute("id", idStr);
     } else if (lua_isnumber(L, 5)) {
         int32_t idNum = lua_tointeger(L, 5);
-        char id[4];
-        SStrPrintf(id, 256, "%d", id);
-        frameNode.SetAttribute("id", id);
+
+        char idStr[256];
+        SStrPrintf(idStr, sizeof(idStr), "%d", idNum);
+
+        frameNode.SetAttribute("id", idStr);
     }
 
     CStatus status;