Compare commits

...

5 Commits

Author SHA1 Message Date
Tristan 'Natrist' Cormier
a9e314b16d
Merge a82628adaa into cda8fff096 2026-02-06 19:03:14 -05:00
fallenoak
cda8fff096
feat(ui): implement Script_GetCursorMoney
Some checks are pending
Push / ${{ matrix.build.system_name }} / ${{ matrix.build.build_type }} / ${{ matrix.build.compiler_name }} (map[build_type:Release cc:cl compiler_name:MSVC cxx:cl os:windows-latest system_name:Windows test_path:WhoaTest]) (push) Waiting to run
Push / ${{ matrix.build.system_name }} / ${{ matrix.build.build_type }} / ${{ matrix.build.compiler_name }} (map[build_type:Release cc:clang compiler_name:Clang cxx:clang++ os:macos-latest system_name:macOS test_path:WhoaTest]) (push) Waiting to run
Push / ${{ matrix.build.system_name }} / ${{ matrix.build.build_type }} / ${{ matrix.build.compiler_name }} (map[build_type:Release cc:gcc compiler_name:GCC cxx:g++ os:ubuntu-latest system_name:Linux test_path:WhoaTest]) (push) Waiting to run
2026-02-06 15:35:17 -06:00
fallenoak
5ee4c54827
feat(ui): implement Script_GetMoney 2026-02-06 14:04:52 -06:00
fallenoak
68ad71090e
feat(object): simplify getters in CGPlayer_C 2026-02-06 10:36:54 -06:00
Tristan Cormier
a82628adaa feat(glue): implement Script_DeleteCharacter 2026-01-05 22:35:20 -05:00
15 changed files with 99 additions and 12 deletions

View File

@ -160,6 +160,10 @@ ClientConnection* ClientServices::Connection() {
return ClientServices::s_currentConnection; return ClientServices::s_currentConnection;
} }
void ClientServices::CharacterDelete(uint64_t guid) {
ClientServices::Connection()->RequestCharacterDelete(guid);
}
void ClientServices::Disconnect() { void ClientServices::Disconnect() {
ClientServices::Connection()->Disconnect(); ClientServices::Connection()->Disconnect();
} }

View File

@ -33,6 +33,7 @@ class ClientServices : public LoginResponse {
// Static functions // Static functions
static void ConnectToSelectedServer(); static void ConnectToSelectedServer();
static ClientConnection* Connection(); static ClientConnection* Connection();
static void CharacterDelete(uint64_t guid);
static void Disconnect(); static void Disconnect();
static const char* GetCurrentLoginPortal(); static const char* GetCurrentLoginPortal();
static const char* GetCurrentLoginServer(); static const char* GetCurrentLoginServer();

View File

@ -1,4 +1,5 @@
#include "glue/CCharacterSelectionScript.hpp" #include "glue/CCharacterSelectionScript.hpp"
#include "CGlueMgr.hpp"
#include "db/Db.hpp" #include "db/Db.hpp"
#include "glue/CCharacterSelection.hpp" #include "glue/CCharacterSelection.hpp"
#include "object/client/CGUnit_C.hpp" #include "object/client/CGUnit_C.hpp"
@ -157,7 +158,17 @@ int32_t Script_SelectCharacter(lua_State* L) {
} }
int32_t Script_DeleteCharacter(lua_State* L) { int32_t Script_DeleteCharacter(lua_State* L) {
WHOA_UNIMPLEMENTED(0); if (!lua_isnumber(L, 1)) {
luaL_error(L, "Usage: DeleteCharacter(index)");
}
int32_t index = static_cast<int32_t>(lua_tonumber(L, 1)) - 1;
if (index >= 0 && index < CCharacterSelection::s_characterList.Count()) {
CGlueMgr::DeleteCharacter(CCharacterSelection::s_characterList.m_data[index].m_info.guid);
}
return 0;
} }
int32_t Script_RenameCharacter(lua_State* L) { int32_t Script_RenameCharacter(lua_State* L) {

View File

@ -129,6 +129,17 @@ void CGlueMgr::ChangeRealm(const REALM_INFO* realmInfo) {
ClientServices::Connection()->Connect(); ClientServices::Connection()->Connect();
} }
void CGlueMgr::DeleteCharacter(uint64_t guid) {
if (guid) {
CGlueMgr::SetIdleState(IDLE_DELETE_CHARACTER);
auto text = FrameScript_GetText(ClientServices::GetErrorToken(70), -1, GENDER_NOT_APPLICABLE);
FrameScript_SignalEvent(OPEN_STATUS_DIALOG, "%s%s", "CANCEL", text);
ClientServices::CharacterDelete(guid);
}
}
void CGlueMgr::EnterWorld() { void CGlueMgr::EnterWorld() {
if (!ClientServices::GetSelectedRealm()) { if (!ClientServices::GetSelectedRealm()) {
return; return;

View File

@ -66,6 +66,7 @@ class CGlueMgr {
// Static functions // Static functions
static void CancelRealmListQuery(); static void CancelRealmListQuery();
static void ChangeRealm(const REALM_INFO* realmInfo); static void ChangeRealm(const REALM_INFO* realmInfo);
static void DeleteCharacter(uint64_t guid);
static void DisplayLoginStatus(); static void DisplayLoginStatus();
static void EnterWorld(); static void EnterWorld();
static void GetCharacterList(); static void GetCharacterList();

View File

@ -1,6 +1,7 @@
#include "net/connection/ClientConnection.hpp" #include "net/connection/ClientConnection.hpp"
#include "net/Login.hpp"
#include "client/ClientServices.hpp" #include "client/ClientServices.hpp"
#include "common/datastore/CDataStore.hpp"
#include "net/Login.hpp"
#include "ui/FrameScript.hpp" #include "ui/FrameScript.hpp"
void ClientConnection::AccountLogin(const char* name, const char* password, int32_t region, WOW_LOCALE locale) { void ClientConnection::AccountLogin(const char* name, const char* password, int32_t region, WOW_LOCALE locale) {
@ -160,3 +161,19 @@ int32_t ClientConnection::PollStatus(WOWCS_OPS& op, const char** msg, int32_t& r
return this->m_statusComplete; return this->m_statusComplete;
} }
void ClientConnection::RequestCharacterDelete(uint64_t guid) {
this->Initiate(COP_DELETE_CHARACTER, 70, nullptr);
if (this->IsConnected()) {
CDataStore netMsg;
netMsg.Put(static_cast<uint32_t>(CMSG_CHAR_DELETE));
netMsg.Put(guid);
netMsg.Finalize();
this->Send(&netMsg);
}
else {
this->Cancel(4);
}
}

View File

@ -43,6 +43,7 @@ class ClientConnection : public RealmConnection {
void Initiate(WOWCS_OPS op, int32_t errorCode, void (*cleanup)()); void Initiate(WOWCS_OPS op, int32_t errorCode, void (*cleanup)());
int32_t IsConnected(); int32_t IsConnected();
int32_t PollStatus(WOWCS_OPS& op, const char** msg, int32_t& result, int32_t& errorCode); int32_t PollStatus(WOWCS_OPS& op, const char** msg, int32_t& result, int32_t& errorCode);
void RequestCharacterDelete(uint64_t guid);
}; };
#endif #endif

View File

@ -41,6 +41,10 @@ uint32_t CGPlayer::TotalRemoteFieldsSaved() {
return CGPlayer::GetBaseOffsetSaved() + 173; return CGPlayer::GetBaseOffsetSaved() + 173;
} }
uint32_t CGPlayer::GetMoney() const {
return this->Player()->coinage;
}
uint32_t CGPlayer::GetNextLevelXP() const { uint32_t CGPlayer::GetNextLevelXP() const {
return this->Player()->nextLevelXP; return this->Player()->nextLevelXP;
} }

View File

@ -149,6 +149,7 @@ class CGPlayer {
static uint32_t TotalRemoteFieldsSaved(); static uint32_t TotalRemoteFieldsSaved();
// Public member functions // Public member functions
uint32_t GetMoney() const;
uint32_t GetNextLevelXP() const; uint32_t GetNextLevelXP() const;
uint32_t GetXP() const; uint32_t GetXP() const;

View File

@ -6,6 +6,12 @@
#include "ui/Game.hpp" #include "ui/Game.hpp"
#include <storm/Error.hpp> #include <storm/Error.hpp>
CGPlayer_C* CGPlayer_C::GetActivePtr() {
return static_cast<CGPlayer_C*>(
ClntObjMgrObjectPtr(ClntObjMgrGetActivePlayer(), TYPE_PLAYER, __FILE__, __LINE__)
);
}
CGPlayer_C::CGPlayer_C(uint32_t time, CClientObjCreate& objCreate) : CGUnit_C(time, objCreate) { CGPlayer_C::CGPlayer_C(uint32_t time, CClientObjCreate& objCreate) : CGUnit_C(time, objCreate) {
// TODO // TODO
} }
@ -14,20 +20,28 @@ CGPlayer_C::~CGPlayer_C() {
// TODO // TODO
} }
uint32_t CGPlayer_C::GetActiveNextLevelXP() const { uint32_t CGPlayer_C::GetMoney() const {
if (this->GetGUID() != ClntObjMgrGetActivePlayer()) { if (this->GetGUID() != ClntObjMgrGetActivePlayer()) {
return 0; return 0;
} }
return this->GetNextLevelXP(); return this->CGPlayer::GetMoney();
} }
uint32_t CGPlayer_C::GetActiveXP() const { uint32_t CGPlayer_C::GetNextLevelXP() const {
if (this->GetGUID() != ClntObjMgrGetActivePlayer()) { if (this->GetGUID() != ClntObjMgrGetActivePlayer()) {
return 0; return 0;
} }
return this->GetXP(); return this->CGPlayer::GetNextLevelXP();
}
uint32_t CGPlayer_C::GetXP() const {
if (this->GetGUID() != ClntObjMgrGetActivePlayer()) {
return 0;
}
return this->CGPlayer::GetXP();
} }
void CGPlayer_C::PostInit(uint32_t time, const CClientObjCreate& init, bool a4) { void CGPlayer_C::PostInit(uint32_t time, const CClientObjCreate& init, bool a4) {

View File

@ -10,13 +10,17 @@ class CreatureModelDataRec;
class CGPlayer_C : public CGUnit_C, public CGPlayer { class CGPlayer_C : public CGUnit_C, public CGPlayer {
public: public:
// Public static functions
static CGPlayer_C* GetActivePtr();
// Virtual public member functions // Virtual public member functions
virtual ~CGPlayer_C(); virtual ~CGPlayer_C();
// Public member functions // Public member functions
CGPlayer_C(uint32_t time, CClientObjCreate& objCreate); CGPlayer_C(uint32_t time, CClientObjCreate& objCreate);
uint32_t GetActiveNextLevelXP() const; uint32_t GetMoney() const;
uint32_t GetActiveXP() const; uint32_t GetNextLevelXP() const;
uint32_t GetXP() const;
void PostInit(uint32_t time, const CClientObjCreate& init, bool a4); void PostInit(uint32_t time, const CClientObjCreate& init, bool a4);
void PostInitActivePlayer(); void PostInitActivePlayer();
void SetStorage(uint32_t* storage, uint32_t* saved); void SetStorage(uint32_t* storage, uint32_t* saved);

View File

@ -25,6 +25,7 @@
#include <common/MD5.hpp> #include <common/MD5.hpp>
WOWGUID CGGameUI::s_currentObjectTrack; WOWGUID CGGameUI::s_currentObjectTrack;
uint32_t CGGameUI::s_cursorMoney;
CScriptObject* CGGameUI::s_gameTooltip; CScriptObject* CGGameUI::s_gameTooltip;
bool CGGameUI::s_inWorld; bool CGGameUI::s_inWorld;
WOWGUID CGGameUI::s_lockedTarget; WOWGUID CGGameUI::s_lockedTarget;
@ -94,6 +95,10 @@ WOWGUID& CGGameUI::GetCurrentObjectTrack() {
return CGGameUI::s_currentObjectTrack; return CGGameUI::s_currentObjectTrack;
} }
uint32_t CGGameUI::GetCursorMoney() {
return CGGameUI::s_cursorMoney;
}
WOWGUID& CGGameUI::GetLockedTarget() { WOWGUID& CGGameUI::GetLockedTarget() {
return CGGameUI::s_lockedTarget; return CGGameUI::s_lockedTarget;
} }

View File

@ -15,6 +15,7 @@ class CGGameUI {
// Static functions // Static functions
static void EnterWorld(); static void EnterWorld();
static WOWGUID& GetCurrentObjectTrack(); static WOWGUID& GetCurrentObjectTrack();
static uint32_t GetCursorMoney();
static WOWGUID& GetLockedTarget(); static WOWGUID& GetLockedTarget();
static void Initialize(); static void Initialize();
static void InitializeGame(); static void InitializeGame();
@ -25,6 +26,7 @@ class CGGameUI {
private: private:
static WOWGUID s_currentObjectTrack; static WOWGUID s_currentObjectTrack;
static uint32_t s_cursorMoney;
static bool s_inWorld; static bool s_inWorld;
static WOWGUID s_lockedTarget; static WOWGUID s_lockedTarget;
static bool s_loggingIn; static bool s_loggingIn;

View File

@ -3,6 +3,7 @@
#include "gx/Coordinate.hpp" #include "gx/Coordinate.hpp"
#include "ui/FrameScript.hpp" #include "ui/FrameScript.hpp"
#include "ui/ScriptFunctionsShared.hpp" #include "ui/ScriptFunctionsShared.hpp"
#include "ui/game/CGGameUI.hpp"
#include "ui/simple/CSimpleTop.hpp" #include "ui/simple/CSimpleTop.hpp"
#include "util/StringTo.hpp" #include "util/StringTo.hpp"
#include "util/Unimplemented.hpp" #include "util/Unimplemented.hpp"
@ -502,7 +503,9 @@ int32_t Script_ForceQuit(lua_State* L) {
} }
int32_t Script_GetCursorMoney(lua_State* L) { int32_t Script_GetCursorMoney(lua_State* L) {
WHOA_UNIMPLEMENTED(0); lua_pushnumber(L, CGGameUI::GetCursorMoney());
return 1;
} }
int32_t Script_DropCursorMoney(lua_State* L) { int32_t Script_DropCursorMoney(lua_State* L) {

View File

@ -189,7 +189,7 @@ int32_t Script_UnitXP(lua_State* L) {
float xp = 0.0f; float xp = 0.0f;
if (unit && unit->IsA(TYPE_PLAYER)) { if (unit && unit->IsA(TYPE_PLAYER)) {
xp = static_cast<CGPlayer_C*>(unit)->GetActiveXP(); xp = static_cast<CGPlayer_C*>(unit)->GetXP();
} }
lua_pushnumber(L, xp); lua_pushnumber(L, xp);
@ -209,7 +209,7 @@ int32_t Script_UnitXPMax(lua_State* L) {
float xpMax = 0.0f; float xpMax = 0.0f;
if (unit && unit->IsA(TYPE_PLAYER)) { if (unit && unit->IsA(TYPE_PLAYER)) {
xpMax = static_cast<CGPlayer_C*>(unit)->GetActiveNextLevelXP(); xpMax = static_cast<CGPlayer_C*>(unit)->GetNextLevelXP();
} }
lua_pushnumber(L, xpMax); lua_pushnumber(L, xpMax);
@ -282,7 +282,15 @@ int32_t Script_UnitLevel(lua_State* L) {
} }
int32_t Script_GetMoney(lua_State* L) { int32_t Script_GetMoney(lua_State* L) {
WHOA_UNIMPLEMENTED(0); auto player = CGPlayer_C::GetActivePtr();
if (player) {
lua_pushnumber(L, player->GetMoney());
} else {
lua_pushnumber(L, 0.0f);
}
return 1;
} }
int32_t Script_GetHonorCurrency(lua_State* L) { int32_t Script_GetHonorCurrency(lua_State* L) {