Compare commits

..

5 Commits

Author SHA1 Message Date
Tristan 'Natrist' Cormier
731b2a5ba5
Merge e985629f09 into e5150d7d21 2026-02-27 23:10:46 -05:00
fallenoak
e5150d7d21
feat(object): add CGUnit_C::GetFacing
Some checks failed
Push / ${{ matrix.build.system_name }} / ${{ matrix.build.build_type }} / ${{ matrix.build.compiler_name }} (map[build_type:Release cc:cl compiler_name:MSVC cxx:cl os:windows-latest system_name:Windows test_path:WhoaTest]) (push) Has been cancelled
Push / ${{ matrix.build.system_name }} / ${{ matrix.build.build_type }} / ${{ matrix.build.compiler_name }} (map[build_type:Release cc:clang compiler_name:Clang cxx:clang++ os:macos-latest system_name:macOS test_path:WhoaTest]) (push) Has been cancelled
Push / ${{ matrix.build.system_name }} / ${{ matrix.build.build_type }} / ${{ matrix.build.compiler_name }} (map[build_type:Release cc:gcc compiler_name:GCC cxx:g++ os:ubuntu-latest system_name:Linux test_path:WhoaTest]) (push) Has been cancelled
2026-02-27 20:35:12 -06:00
fallenoak
3a876398a7
feat(object): add CGUnit_C::GetPosition 2026-02-27 20:25:16 -06:00
fallenoak
1b90dcb09b
fix(object): move CMovement_C pointer to proper location in CGUnit 2026-02-27 20:12:08 -06:00
fallenoak
c5bd63b79e
feat(object): add missing CGUnit_C in-class initializers 2026-02-26 07:16:16 -06:00
6 changed files with 58 additions and 12 deletions

View File

@ -1,5 +1,6 @@
#include "object/client/CGUnit.hpp" #include "object/client/CGUnit.hpp"
#include "object/client/CGObject.hpp" #include "object/client/CGObject.hpp"
#include "object/client/CMovement_C.hpp"
uint32_t CGUnit::GetBaseOffset() { uint32_t CGUnit::GetBaseOffset() {
return CGObject::TotalFields(); return CGObject::TotalFields();
@ -29,10 +30,18 @@ int32_t CGUnit::GetDisplayID() const {
return this->Unit()->displayID; return this->Unit()->displayID;
} }
float CGUnit::GetFacing() const {
return this->m_move->GetFacing();
}
int32_t CGUnit::GetNativeDisplayID() const { int32_t CGUnit::GetNativeDisplayID() const {
return this->Unit()->nativeDisplayID; return this->Unit()->nativeDisplayID;
} }
C3Vector CGUnit::GetPosition() const {
return this->m_move->GetPosition();
}
CGUnitData* CGUnit::Unit() const { CGUnitData* CGUnit::Unit() const {
return this->m_unit; return this->m_unit;
} }

View File

@ -2,8 +2,11 @@
#define OBJECT_CLIENT_CG_UNIT_HPP #define OBJECT_CLIENT_CG_UNIT_HPP
#include "util/GUID.hpp" #include "util/GUID.hpp"
#include <tempest/Vector.hpp>
#include <cstdint> #include <cstdint>
class CMovement_C;
struct CGUnitData { struct CGUnitData {
WOWGUID charm; WOWGUID charm;
WOWGUID summon; WOWGUID summon;
@ -83,13 +86,18 @@ class CGUnit {
static uint32_t TotalFieldsSaved(); static uint32_t TotalFieldsSaved();
// Public member functions // Public member functions
CGUnit(CMovement_C& move)
: m_move(&move) {};
int32_t GetDisplayID() const; int32_t GetDisplayID() const;
float GetFacing() const;
int32_t GetNativeDisplayID() const; int32_t GetNativeDisplayID() const;
C3Vector GetPosition() const;
protected: protected:
// Protected member variables // Protected member variables
CGUnitData* m_unit; CGUnitData* m_unit;
uint32_t* m_unitSaved; uint32_t* m_unitSaved;
CMovement_C* m_move;
// Protected member functions // Protected member functions
CGUnitData* Unit() const; CGUnitData* Unit() const;

View File

@ -98,8 +98,8 @@ const char* CGUnit_C::GetDisplayRaceNameFromRecord(const ChrRacesRec* raceRec, U
CGUnit_C::CGUnit_C(uint32_t time, CClientObjCreate& objCreate) CGUnit_C::CGUnit_C(uint32_t time, CClientObjCreate& objCreate)
: CGObject_C(time, objCreate) : CGObject_C(time, objCreate)
, m_movement(&this->m_localMovement) , CGUnit(this->m_localMove)
, m_localMovement(objCreate.move.status.position28, objCreate.move.status.facing34, this->GetGUID(), this) , m_localMove(objCreate.move.status.position28, objCreate.move.status.facing34, this->GetGUID(), this)
{ {
// TODO // TODO
@ -136,6 +136,10 @@ int32_t CGUnit_C::GetDisplayID() const {
return this->CGUnit::GetDisplayID(); return this->CGUnit::GetDisplayID();
} }
float CGUnit_C::GetFacing() const {
return this->CGUnit::GetFacing();
}
int32_t CGUnit_C::GetLocalDisplayID() const { int32_t CGUnit_C::GetLocalDisplayID() const {
return this->m_localDisplayID; return this->m_localDisplayID;
} }
@ -175,6 +179,10 @@ int32_t CGUnit_C::GetModelFileName(const char*& name) const {
return modelDataRec->m_modelName ? true : false; return modelDataRec->m_modelName ? true : false;
} }
C3Vector CGUnit_C::GetPosition() const {
return this->CGUnit::GetPosition();
}
void CGUnit_C::PostInit(uint32_t time, const CClientObjCreate& init, bool a4) { void CGUnit_C::PostInit(uint32_t time, const CClientObjCreate& init, bool a4) {
// TODO // TODO

View File

@ -4,7 +4,7 @@
#include "object/client/CClientObjCreate.hpp" #include "object/client/CClientObjCreate.hpp"
#include "object/client/CGObject_C.hpp" #include "object/client/CGObject_C.hpp"
#include "object/client/CGUnit.hpp" #include "object/client/CGUnit.hpp"
#include "object/client/CMovementData_C.hpp" #include "object/client/CMovement_C.hpp"
#include "object/Types.hpp" #include "object/Types.hpp"
#include "util/GUID.hpp" #include "util/GUID.hpp"
@ -28,6 +28,10 @@ class CGUnit_C : public CGObject_C, public CGUnit {
// Virtual public member functions // Virtual public member functions
virtual ~CGUnit_C(); virtual ~CGUnit_C();
// TODO // TODO
virtual C3Vector GetPosition() const;
// TODO
virtual float GetFacing() const;
// TODO
virtual int32_t GetModelFileName(const char*& name) const; virtual int32_t GetModelFileName(const char*& name) const;
// TODO // TODO
virtual int32_t CanHighlight(); virtual int32_t CanHighlight();
@ -49,16 +53,15 @@ class CGUnit_C : public CGObject_C, public CGUnit {
private: private:
// Private member variables // Private member variables
CMovementData_C* m_movement;
// TODO // TODO
CMovementData_C m_localMovement; CMovement_C m_localMove;
// TODO // TODO
CreatureDisplayInfoRec* m_displayInfo; CreatureDisplayInfoRec* m_displayInfo = nullptr;
CreatureDisplayInfoExtraRec* m_displayInfoExtra; CreatureDisplayInfoExtraRec* m_displayInfoExtra = nullptr;
CreatureModelDataRec* m_modelData; CreatureModelDataRec* m_modelData = nullptr;
CreatureSoundDataRec* m_soundData; CreatureSoundDataRec* m_soundData = nullptr;
// TODO // TODO
UnitBloodLevelsRec* m_bloodRec; UnitBloodLevelsRec* m_bloodRec = nullptr;
// TODO // TODO
int32_t m_localDisplayID = 0; int32_t m_localDisplayID = 0;
// TODO // TODO

View File

@ -1,15 +1,31 @@
#include "object/movement/CPassenger.hpp" #include "object/movement/CPassenger.hpp"
#include <tempest/Matrix.hpp> #include <tempest/Matrix.hpp>
float CPassenger::GetFacing() const {
return this->GetFacing(this->m_facing);
}
float CPassenger::GetFacing(float facing) const {
// If on transport, transform facing by transport facing
if (this->m_transportGUID) {
float transportFacing = 0.0f;
// TODO MovementGetTransportFacing(this->m_transportGUID);
return facing + transportFacing;
}
return facing;
}
C3Vector CPassenger::GetPosition() const { C3Vector CPassenger::GetPosition() const {
return GetPosition(this->m_position); return this->GetPosition(this->m_position);
} }
C3Vector CPassenger::GetPosition(const C3Vector& position) const { C3Vector CPassenger::GetPosition(const C3Vector& position) const {
// If on transport, transform position by transport matrix // If on transport, transform position by transport matrix
if (this->m_transportGUID) { if (this->m_transportGUID) {
C44Matrix transportMatrix; C44Matrix transportMatrix;
// MovementGetTransportMtxX(this->m_transportGUID, &transportMatrix); // TODO MovementGetTransportMtxX(this->m_transportGUID, &transportMatrix);
return position * transportMatrix; return position * transportMatrix;
} }

View File

@ -12,6 +12,8 @@ class CPassenger {
, m_position(position) , m_position(position)
, m_facing(0.0f) , m_facing(0.0f)
, m_guid(guid) {}; , m_guid(guid) {};
float GetFacing() const;
float GetFacing(float facing) const;
C3Vector GetPosition() const; C3Vector GetPosition() const;
C3Vector GetPosition(const C3Vector& position) const; C3Vector GetPosition(const C3Vector& position) const;