Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-05-14 18:08:13 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

"fixed" uninitialized memory usage/data race in osd_work_item_wait (nw)

Browse Source 
appears to be a Linux-only issue
This commit is contained in:
Oliver Stöneberg 2015-01-01 15:02:21 +01:00
parent 5d5a89726c
commit 0c0260ec2d
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/osd/sdl/sdlwork.c
View File

@ -428,6 +428,11 @@ osd_work_item *osd_work_item_queue_multiple(osd_work_queue *queue, osd_work_call
return NULL; return NULL;
item->event = NULL; item->event = NULL;
item->queue = queue; item->queue = queue;
item->done = FALSE;
}
else
{
atomic_exchange32(&item->done, FALSE); // needs to be set this way to prevent data race/usage of uninitialized memory on Linux
} }
// fill in the basics // fill in the basics
@ -436,7 +441,6 @@ osd_work_item *osd_work_item_queue_multiple(osd_work_queue *queue, osd_work_call
item->param = parambase; item->param = parambase;
item->result = NULL; item->result = NULL;
item->flags = flags; item->flags = flags;
atomic_exchange32(&item->done, FALSE);
// advance to the next // advance to the next
lastitem = item; lastitem = item;

6
src/osd/windows/winwork.c
View File

@ -438,6 +438,11 @@ osd_work_item *osd_work_item_queue_multiple(osd_work_queue *queue, osd_work_call
return NULL; return NULL;
item->event = NULL; item->event = NULL;
item->queue = queue; item->queue = queue;
item->done = FALSE;
}
else
{
atomic_exchange32(&item->done, FALSE); // needs to be set this way to prevent data race/usage of uninitialized memory on Linux
} }
// fill in the basics // fill in the basics
@ -446,7 +451,6 @@ osd_work_item *osd_work_item_queue_multiple(osd_work_queue *queue, osd_work_call
item->param = parambase; item->param = parambase;
item->result = NULL; item->result = NULL;
item->flags = flags; item->flags = flags;
atomic_exchange32(&item->done, FALSE);
// advance to the next // advance to the next
lastitem = item; lastitem = item;