Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-20 23:42:22 +03:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

video/gba_lcd.cpp: Implement device_palette_interface rather than instantiating a separate palette device. (#13481)

Browse Source
This commit is contained in:
cam900 2025-04-07 02:15:56 +09:00 committed by GitHub
parent e7250f3563
commit 178f205a4a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/devices/video/gba_lcd.cpp
View File

@ -136,6 +136,7 @@ DEFINE_DEVICE_TYPE(GBA_LCD, gba_lcd_device, "gba_lcd", "GBA LCD")
gba_lcd_device::gba_lcd_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock)
: device_t(mconfig, GBA_LCD, tag, owner, clock)
, device_video_interface(mconfig, *this)
, device_palette_interface(mconfig, *this)
, m_int_hblank_cb(*this)
, m_int_vblank_cb(*this)
, m_int_vcount_cb(*this)
@ -1704,7 +1705,7 @@ TIMER_CALLBACK_MEMBER(gba_lcd_device::perform_scan)
m_scan_timer->adjust(screen().time_until_pos((scanline + 1) % 228, 0));
}
void gba_lcd_device::gba_palette(palette_device &palette) const
void gba_lcd_device::palette_init()
{
for (uint8_t b = 0; b < 32; b++)
{
@ -1712,7 +1713,7 @@ void gba_lcd_device::gba_palette(palette_device &palette) const
{
for (uint8_t r = 0; r < 32; r++)
{
palette.set_pen_color((b << 10) | (g << 5) | r, pal5bit(r), pal5bit(g), pal5bit(b));
set_pen_color((b << 10) | (g << 5) | r, pal5bit(r), pal5bit(g), pal5bit(b));
}
}
}
@ -1727,6 +1728,8 @@ uint32_t gba_lcd_device::screen_update(screen_device &screen, bitmap_ind16 &bitm
void gba_lcd_device::device_start()
{
palette_init();
m_pram = make_unique_clear<uint32_t[]>(0x400 / 4);
m_vram = make_unique_clear<uint32_t[]>(0x18000 / 4);
m_oam = make_unique_clear<uint32_t[]>(0x400 / 4);
@ -1777,7 +1780,5 @@ void gba_lcd_device::device_add_mconfig(machine_config &config)
screen_device &screen(SCREEN(config, "screen", SCREEN_TYPE_LCD));
screen.set_raw(XTAL(16'777'216) / 4, 308, 0, 240, 228, 0, 160);
screen.set_screen_update(FUNC(gba_lcd_device::screen_update));
screen.set_palette("palette");
PALETTE(config, "palette", FUNC(gba_lcd_device::gba_palette), 32768);
screen.set_palette(*this);
}

5
src/devices/video/gba_lcd.h
View File

@ -60,6 +60,7 @@ protected:
class gba_lcd_device
: public device_t
, public device_video_interface
, public device_palette_interface
, protected gba_registers<0x060 / 4, 0x000>
{
public:
@ -88,6 +89,8 @@ protected:
virtual void device_reset() override ATTR_COLD;
virtual void device_add_mconfig(machine_config &config) override ATTR_COLD;
virtual u32 palette_entries() const noexcept override { return 32 * 32 * 32; }
private:
struct internal_reg
{
@ -185,7 +188,7 @@ private:
uint32_t decrease_brightness(uint32_t color);
uint32_t screen_update(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect);
void gba_palette(palette_device &palette) const;
void palette_init();
devcb_write_line m_int_hblank_cb; /* H-Blank interrupt callback function */
devcb_write_line m_int_vblank_cb; /* V-Blank interrupt callback function */