Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-24 13:26:36 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed issue that could cause core_filename_ends_with() to return true when extension.size() > filename.size()

Browse Source
This commit is contained in:
Nathan Woods 2016-07-11 18:05:23 -04:00
parent 32230ae648
commit 210d5cb451
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/lib/util/corefile.cpp
View File

@ -1298,15 +1298,16 @@ bool core_filename_ends_with(const std::string &filename, const std::string &ext
{ {
auto namelen = filename.length(); auto namelen = filename.length();
auto extlen = extension.length(); auto extlen = extension.length();
bool matches = true;
// first if the extension is bigger than the name, we definitely don't match
bool matches = namelen >= extlen;
// work backwards checking for a match // work backwards checking for a match
while (extlen > 0 && namelen > 0) while (matches && extlen > 0 && namelen > 0)
{
if (tolower((UINT8)filename[--namelen]) != tolower((UINT8)extension[--extlen])) if (tolower((UINT8)filename[--namelen]) != tolower((UINT8)extension[--extlen]))
{
matches = false; matches = false;
break; }
}
return matches; return matches;
} }