netlist: fix some clang-tidy warnings. (nw)

This commit is contained in:
couriersud 2020-06-13 23:26:21 +02:00
parent 2a95b76ce9
commit 23c0490019
4 changed files with 8 additions and 7 deletions

View File

@ -17951,8 +17951,8 @@ static void nl_gcr_f6a620d52ca4719f_7_double_double(double * __restrict V, const
V[0] = (RHS0 - tmp0) / m_A0;
}
extern plib::dynlib_static_sym nl_static_solver_syms[];
plib::dynlib_static_sym nl_static_solver_syms[] = {
extern const plib::dynlib_static_sym nl_static_solver_syms[];
const plib::dynlib_static_sym nl_static_solver_syms[] = {
// konami1x
{"nl_gcr_105d3ecb773843b6_49_double_double", reinterpret_cast<void *>(&nl_gcr_105d3ecb773843b6_49_double_double)},
// breakout

View File

@ -324,6 +324,7 @@ namespace netlist
t.push_back(&term->delegate());
term->run_delegate();
}
// NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast)
auto *dev = reinterpret_cast<core_device_t *>(term->delegate().object());
if (!plib::container::contains(d, dev))
d.push_back(dev);

View File

@ -27,7 +27,7 @@
#define NL_DISABLE_DYNAMIC_LOAD 0
#endif
extern plib::dynlib_static_sym nl_static_solver_syms[];
extern const plib::dynlib_static_sym nl_static_solver_syms[];
class tool_app_t : public plib::app
{
@ -668,8 +668,8 @@ void tool_app_t::static_compile()
sout << "// " << e.second.m_module << "\n";
sout << e.second.m_code;
}
sout << "extern plib::dynlib_static_sym nl_static_solver_syms[];\n";
sout << "plib::dynlib_static_sym nl_static_solver_syms[] = {\n";
sout << "extern const plib::dynlib_static_sym nl_static_solver_syms[];\n";
sout << "const plib::dynlib_static_sym nl_static_solver_syms[] = {\n";
for (auto &e : map)
{
sout << "// " << e.second.m_module << "\n";
@ -1066,7 +1066,7 @@ void tool_app_t::listdevices()
{
pstring out = plib::pfmt("{1:-20} {2}(<id>")(fl->name())(fl->name());
netlist::factory::element_t *f;
netlist::factory::element_t *f = nullptr;
nt.parser().register_dev(fl->name(), fl->name() + "_lc",
std::vector<pstring>(), &f);

View File

@ -132,7 +132,7 @@ private:
double value() const { return m_val;}
const str_list &extra() const { return m_extra;}
bool has_model() const { return m_model != ""; }
bool has_model() const { return !m_model.empty(); }
bool has_value() const { return m_has_val; }
void add_extra(const pstring &s) { m_extra.push_back(s); }