ginganin.cpp: remove trivial ROM patch, use nopw() instead.

This commit is contained in:
Angelo Salese 2020-09-17 00:03:02 +02:00 committed by GitHub
parent 566c63ea79
commit 279284e3c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -46,9 +46,13 @@ f5d6 print 7 digit BCD number: d0.l to (a1)+ color $3000
To Do
-----
- game doesn't init paletteram / tilemaps properly, ending up with MAME
- Game doesn't init paletteram / tilemaps properly, ending up with MAME
palette defaults at start-up and missing text layer if you coin it up
too soon.
- In later levels a couple sprites lingers on top of screen;
- Sometimes a credit sample also gets overwritten with additional spurious
playback of all samples;
^ all these might be just BTANBs ...
***************************************************************************/
@ -78,8 +82,9 @@ f5d6 print 7 digit BCD number: d0.l to (a1)+ color $3000
void ginganin_state::main_map(address_map &map)
{
/* The ROM area: 10000-13fff is written with: 0000 0000 0000 0001, at startup only. Why? */
map(0x000000, 0x01ffff).rom();
// PC=0x408 ROM area 10000-13fff is written at POST with: 0000 0000 0000 0001,
// looks a debugging left-over for GFX patching (causes state garbage if hooked as RAM write mirror)
map(0x000000, 0x01ffff).rom().nopw();
map(0x020000, 0x023fff).ram();
map(0x030000, 0x0307ff).ram().w(FUNC(ginganin_state::txtram_w)).share("txtram");
map(0x040000, 0x0407ff).ram().share("spriteram");
@ -353,11 +358,12 @@ ROM_END
void ginganin_state::init_ginganin()
{
// pending full removal of this patch ...
/* main cpu patches */
u16 *rom = (u16 *)memregion("maincpu")->base();
// u16 *rom = (u16 *)memregion("maincpu")->base();
/* avoid writes to rom getting to the log */
rom[0x408 / 2] = 0x6000;
rom[0x40a / 2] = 0x001c;
// rom[0x408 / 2] = 0x6000;
// rom[0x40a / 2] = 0x001c;
}