Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-05-07 14:54:35 +03:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

zsg2.cpp: properly reset emphasis filter state at key on

Browse Source 
zsg2.cpp: update documentation
This commit is contained in:
superctr 2018-08-31 22:36:54 +02:00
parent 25035d3ac0
commit 27e30dd243
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/devices/sound/zsg2.cpp
View File

@ -10,7 +10,7 @@
--------------------------------------------------------- ---------------------------------------------------------
Register map: Register map:
000-5fe : Channel specific registers 000-5fe : Channel specific registers (48 channels)
(high) (low) (high) (low)
+000 : xxxxxxxx -------- : Start address (low) +000 : xxxxxxxx -------- : Start address (low)
+000 : -------- xxxxxxxx : Unknown register (usually cleared) +000 : -------- xxxxxxxx : Unknown register (usually cleared)
@ -27,7 +27,7 @@
+010 : xxxxxxxx xxxxxxxx : Initial filter time constant +010 : xxxxxxxx xxxxxxxx : Initial filter time constant
+012 : xxxxxxxx xxxxxxxx : Current filter time constant +012 : xxxxxxxx xxxxxxxx : Current filter time constant
+014 : xxxxxxxx xxxxxxxx : Initial volume +014 : xxxxxxxx xxxxxxxx : Initial volume
+016 : xxxxxxxx xxxxxxxx : Current volume +016 : xxxxxxxx xxxxxxxx : Current volume?
+018 : xxxxxxxx xxxxxxxx : Target filter time constant +018 : xxxxxxxx xxxxxxxx : Target filter time constant
+01a : xxxxxxxx -------- : DSP ch 1 (chorus) output gain +01a : xxxxxxxx -------- : DSP ch 1 (chorus) output gain
: -------- xxxxxxxx : Filter ramping speed : -------- xxxxxxxx : Filter ramping speed
@ -85,7 +85,7 @@
TODO: TODO:
- Filter and ramping behavior might not be perfect. - Filter and ramping behavior might not be perfect.
- sometimes clicking / popping noises - clicking / popping noises in gdarius, raystorm: maybe the sample ROMs are bad dumps?
- memory reads out of range sometimes - memory reads out of range sometimes
*/ */
@ -309,10 +309,11 @@ void zsg2_device::sound_stream_update(sound_stream &stream, stream_sample_t **in
elem.status &= ~STATUS_ACTIVE; elem.status &= ~STATUS_ACTIVE;
continue; continue;
} }
if(elem.cur_pos == elem.start_pos)
elem.emphasis_filter_state = EMPHASIS_INITIAL_BIAS;
} }
if(elem.cur_pos == elem.start_pos)
elem.emphasis_filter_state = EMPHASIS_INITIAL_BIAS;
elem.step_ptr &= 0xffff; elem.step_ptr &= 0xffff;
filter_samples(&elem); filter_samples(&elem);
} }