Make the (watch|break)points notify correctly in response to clicks

This commit is contained in:
Vas Crabb 2015-02-21 06:44:12 +11:00
parent 8fbc771daa
commit 2bb9137fdf
4 changed files with 10 additions and 52 deletions

View File

@ -72,26 +72,6 @@ void debug_view_breakpoints::enumerate_sources()
}
//-------------------------------------------------
// view_notify - handle notification of updates
// to cursor changes
//-------------------------------------------------
void debug_view_breakpoints::view_notify(debug_view_notification type)
{
}
//-------------------------------------------------
// view_char - handle a character typed within
// the current view
//-------------------------------------------------
void debug_view_breakpoints::view_char(int chval)
{
}
//-------------------------------------------------
// view_click - handle a mouse click within the
// current view
@ -134,7 +114,7 @@ void debug_view_breakpoints::view_click(const int button, const debug_view_xy& p
device_debug::breakpoint** bpList = NULL;
const int numBPs = breakpoints(SORT_NONE, bpList);
const int bpIndex = pos.y-1;
const int bpIndex = pos.y - 1;
if (bpIndex > numBPs || bpIndex < 0)
return;
@ -147,7 +127,9 @@ void debug_view_breakpoints::view_click(const int button, const debug_view_xy& p
delete[] bpList;
}
view_update();
begin_update();
m_update_pending = true;
end_update();
}
@ -331,7 +313,7 @@ int debug_view_breakpoints::breakpoints(SortMode sort, device_debug::breakpoint*
//-------------------------------------------------
// view_update - update the contents of the
// disassembly view
// breakpoints view
//-------------------------------------------------
void debug_view_breakpoints::view_update()

View File

@ -58,14 +58,11 @@ public:
protected:
// view overrides
virtual void view_update();
virtual void view_notify(debug_view_notification type);
virtual void view_char(int chval);
virtual void view_click(const int button, const debug_view_xy& pos);
private:
// internal helpers
void enumerate_sources();
bool recompute(offs_t pc, int startline, int lines);
void pad_astring_to_length(astring& str, int len);
int breakpoints(SortMode sort, device_debug::breakpoint**& bpList);

View File

@ -71,26 +71,6 @@ void debug_view_watchpoints::enumerate_sources()
}
//-------------------------------------------------
// view_notify - handle notification of updates
// to cursor changes
//-------------------------------------------------
void debug_view_watchpoints::view_notify(debug_view_notification type)
{
}
//-------------------------------------------------
// view_char - handle a character typed within
// the current view
//-------------------------------------------------
void debug_view_watchpoints::view_char(int chval)
{
}
//-------------------------------------------------
// view_click - handle a mouse click within the
// current view
@ -141,7 +121,7 @@ void debug_view_watchpoints::view_click(const int button, const debug_view_xy& p
device_debug::watchpoint** wpList = NULL;
const int numWPs = watchpoints(SORT_NONE, wpList);
const int wpIndex = pos.y-1;
const int wpIndex = pos.y - 1;
if (wpIndex > numWPs || wpIndex < 0)
return;
@ -154,7 +134,9 @@ void debug_view_watchpoints::view_click(const int button, const debug_view_xy& p
delete[] wpList;
}
view_update();
begin_update();
m_update_pending = true;
end_update();
}
@ -387,7 +369,7 @@ int debug_view_watchpoints::watchpoints(SortMode sort, device_debug::watchpoint*
//-------------------------------------------------
// view_update - update the contents of the
// disassembly view
// watchpoints view
//-------------------------------------------------
void debug_view_watchpoints::view_update()

View File

@ -62,14 +62,11 @@ public:
protected:
// view overrides
virtual void view_update();
virtual void view_notify(debug_view_notification type);
virtual void view_char(int chval);
virtual void view_click(const int button, const debug_view_xy& pos);
private:
// internal helpers
void enumerate_sources();
bool recompute(offs_t pc, int startline, int lines);
void pad_astring_to_length(astring& str, int len);
int watchpoints(SortMode sort, device_debug::watchpoint**& bpList);