From 377e9d6d7dd2f04427b21387f14dc0e9b30970e3 Mon Sep 17 00:00:00 2001 From: angelosa Date: Sat, 15 Mar 2025 19:31:34 +0100 Subject: [PATCH] machine/i82371sb.cpp: lift cargo cult 0xe0-0xef noprw machine/mediagx_cs5530_bridge, machine/sis85c496.cpp, machine/sis950_lpc.cpp: as above --- src/devices/machine/i82371sb.cpp | 2 +- src/devices/machine/mediagx_cs5530_bridge.cpp | 2 +- src/devices/machine/sis85c496.cpp | 2 +- src/devices/machine/sis950_lpc.cpp | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/devices/machine/i82371sb.cpp b/src/devices/machine/i82371sb.cpp index a0b8f411534..376e3a9da9c 100644 --- a/src/devices/machine/i82371sb.cpp +++ b/src/devices/machine/i82371sb.cpp @@ -48,7 +48,7 @@ void i82371sb_isa_device::internal_io_map(address_map &map) map(0x00b2, 0x00b3).rw(FUNC(i82371sb_isa_device::read_apmcapms), FUNC(i82371sb_isa_device::write_apmcapms)); // Up to $de according to TC430HX spec? map(0x00c0, 0x00df).rw(FUNC(i82371sb_isa_device::at_dma8237_2_r), FUNC(i82371sb_isa_device::at_dma8237_2_w)); - map(0x00e0, 0x00ef).noprw(); +// map(0x00e0, 0x00ef) MCA bus (cfr. Bochs) or PnP // map(0x00f0, 0x00f0) Reset Numeric Error // map(0x0270, 0x0273) I/O read port for PnP map(0x04d0, 0x04d1).rw(FUNC(i82371sb_isa_device::eisa_irq_read), FUNC(i82371sb_isa_device::eisa_irq_write)); diff --git a/src/devices/machine/mediagx_cs5530_bridge.cpp b/src/devices/machine/mediagx_cs5530_bridge.cpp index 8521d9451fe..8336c5aff35 100644 --- a/src/devices/machine/mediagx_cs5530_bridge.cpp +++ b/src/devices/machine/mediagx_cs5530_bridge.cpp @@ -245,7 +245,7 @@ void mediagx_cs5530_bridge_device::internal_io_map(address_map &map) map(0x00a0, 0x00a1).rw("pic8259_slave", FUNC(pic8259_device::read), FUNC(pic8259_device::write)); map(0x00c0, 0x00df).rw(FUNC(mediagx_cs5530_bridge_device::at_dma8237_2_r), FUNC(mediagx_cs5530_bridge_device::at_dma8237_2_w)); // map(0x04d0, 0x04d1).rw(FUNC(mediagx_cs5530_bridge_device::eisa_irq_read), FUNC(mediagx_cs5530_bridge_device::eisa_irq_write)); - map(0x00e0, 0x00ef).noprw(); + // map(0x00e0, 0x00ef) MCA bus (cfr. Bochs) or PnP // map(0x121c, 0x121f) ACPI Timer count register (on rev 1.3+) } diff --git a/src/devices/machine/sis85c496.cpp b/src/devices/machine/sis85c496.cpp index 4fc946475e4..6504a982e44 100644 --- a/src/devices/machine/sis85c496.cpp +++ b/src/devices/machine/sis85c496.cpp @@ -54,7 +54,7 @@ void sis85c496_host_device::internal_io_map(address_map &map) map(0x0080, 0x009f).rw(FUNC(sis85c496_host_device::at_page8_r), FUNC(sis85c496_host_device::at_page8_w)); map(0x00a0, 0x00a1).rw("pic8259_slave", FUNC(pic8259_device::read), FUNC(pic8259_device::write)); map(0x00c0, 0x00df).rw(FUNC(sis85c496_host_device::at_dma8237_2_r), FUNC(sis85c496_host_device::at_dma8237_2_w)); - map(0x00e0, 0x00ef).noprw(); + // map(0x00e0, 0x00ef) MCA bus (cfr. Bochs) or PnP } void sis85c496_host_device::device_add_mconfig(machine_config &config) diff --git a/src/devices/machine/sis950_lpc.cpp b/src/devices/machine/sis950_lpc.cpp index 12980d995fb..81d94ae94ca 100644 --- a/src/devices/machine/sis950_lpc.cpp +++ b/src/devices/machine/sis950_lpc.cpp @@ -447,7 +447,8 @@ void sis950_lpc_device::io_map(address_map &map) NAME([this] (offs_t offset, u8 data) { m_dmac_slave->write( offset / 2, data ); }) ); - map(0x00e0, 0x00ef).noprw(); + // map(0x00e0, 0x00ef) MCA bus (cfr. Bochs) or PnP + // map(0x00f0, 0x00f0) COPRO error // map(0x0480, 0x048f) DMA high page registers // map(0x04d0, 0x04d1) IRQ edge/level control registers