Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-21 07:52:35 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

voodoo: Return 0 on invalid reads, seems to fix funkball. Improve logging of unexpected accesses to include register name.

Browse Source
This commit is contained in:
Aaron Giles 2021-07-15 10:15:30 -07:00
parent f936d35b58
commit 3e4d3c7997
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/devices/video/voodoo.cpp
View File

@ -1947,7 +1947,10 @@ void voodoo_1_device::internal_texture_w(offs_t offset, u32 data)
u32 voodoo_1_device::reg_invalid_r(u32 chipmask, u32 regnum)
{
return 0xffffffff;
// funkball does invalid reads of textureMode and will leave
// improper bits set if this returns 0xffffffff
logerror("%s: Unexpected read from register %s[%X.%02X]\n", machine().describe_context(), m_regtable[regnum].name(), chipmask, regnum);
return 0x00000000;
}
@ -2045,7 +2048,7 @@ u32 voodoo_1_device::reg_stats_r(u32 chipmask, u32 regnum)
u32 voodoo_1_device::reg_invalid_w(u32 chipmask, u32 regnum, u32 data)
{
logerror("%s: Unexpected write to register %02X[%X] = %08X\n", machine().describe_context(), regnum, chipmask, data);
logerror("%s: Unexpected write to register %s[%X.%02X] = %08X\n", machine().describe_context(), m_regtable[regnum].name(), chipmask, regnum, data);
return 0;
}
@ -2056,7 +2059,7 @@ u32 voodoo_1_device::reg_invalid_w(u32 chipmask, u32 regnum, u32 data)
u32 voodoo_1_device::reg_unimplemented_w(u32 chipmask, u32 regnum, u32 data)
{
logerror("%s: Unimplemented write to register %02X(%X) = %08X\n", machine().describe_context(), regnum, chipmask, data);
logerror("%s: Unimplemented write to register %s[%X.%02X] = %08X\n", machine().describe_context(), m_regtable[regnum].name(), chipmask, regnum, data);
return 0;
}