Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-23 00:39:36 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

olympia/portrait.cpp: simplify scroll hookup

Browse Source
This commit is contained in:
angelosa 2022-11-15 23:55:38 +01:00
parent eb110e8b30
commit 4cb802bc68
2 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/mame/olympia/portrait.cpp
View File

@ -123,16 +123,13 @@ void portrait_state::ctrl_w(uint8_t data)
output().set_value("photo", (data >> 7) & 1);
}
// $9235-$9236 raw scroll values up to 512
// $9236 bit 0 defines which of these are used
void portrait_state::positive_scroll_w(uint8_t data)
// $9235-$9236 raw scroll values up to 511
// $9236 bit 0 defines if $a018 or $a019 is used during active frame
void portrait_state::scroll_w(offs_t offset, uint8_t data)
{
m_scroll = data;
}
void portrait_state::negative_scroll_w(uint8_t data)
{
m_scroll = 511 - (data ^ 0xff);
if (offset & 1)
m_scroll += 256;
}
void portrait_state::portrait_map(address_map &map)
@ -149,8 +146,8 @@ void portrait_state::portrait_map(address_map &map)
map(0xa008, 0xa008).portr("SYSTEM").w(FUNC(portrait_state::ctrl_w));
map(0xa010, 0xa010).portr("INPUTS");
// $a018 reads go to $920f, never really read up?
map(0xa018, 0xa018).nopr().w(FUNC(portrait_state::positive_scroll_w));
map(0xa019, 0xa019).w(FUNC(portrait_state::negative_scroll_w));
map(0xa018, 0xa018).nopr();
map(0xa018, 0xa019).w(FUNC(portrait_state::scroll_w));
map(0xa800, 0xa83f).ram().share("nvram");
map(0xffff, 0xffff).nopr(); // on POST only, value discarded, likely just a bug
}

3
src/mame/olympia/portrait.h
View File

@ -36,8 +36,7 @@ protected:
private:
void ctrl_w(uint8_t data);
void positive_scroll_w(uint8_t data);
void negative_scroll_w(uint8_t data);
void scroll_w(offs_t offset, uint8_t data);
void bgvideo_write(offs_t offset, uint8_t data);
void fgvideo_write(offs_t offset, uint8_t data);