From 521ae5e5b36c4818baefa264327e41d98289d627 Mon Sep 17 00:00:00 2001 From: Scott Stone Date: Fri, 4 Sep 2009 16:38:57 +0000 Subject: [PATCH] Cleaned up drivers that write files which are not being actively developed. Also, commented our or changed the printf-ing of some messages to LOGERROR. Comments: I did this largely due to the difficulty in running regression testing - scanning the text as it flows to the screen has been becoming increasingly annoying, mostly due to excessive amount of specifc printf's used in some instances. Putting them into LOGERROR keeps them available and makes them transparent to the normal end user. As for the files, if a driver is not in active development (it's been over a year on Raiden/Seibu - High Seas Havoc almost 3 years), they shouldn't need to output files. --- src/mame/audio/8080bw.c | 2 +- src/mame/drivers/hshavoc.c | 3 ++- src/mame/drivers/ilpag.c | 6 +++--- src/mame/drivers/raiden2.c | 2 ++ src/mame/drivers/trvmadns.c | 10 +++++----- src/mame/machine/archimds.c | 4 ++-- src/mame/machine/seicop.c | 4 ++++ 7 files changed, 19 insertions(+), 12 deletions(-) diff --git a/src/mame/audio/8080bw.c b/src/mame/audio/8080bw.c index 7d88b36416c..34223faf9a9 100644 --- a/src/mame/audio/8080bw.c +++ b/src/mame/audio/8080bw.c @@ -876,7 +876,7 @@ WRITE8_HANDLER( schaser_sh_port_2_w ) const device_config *discrete = devtag_get_device(space->machine, "discrete"); - printf( "schaser_sh_port_2_w: %02x\n", data ); + //printf( "schaser_sh_port_2_w: %02x\n", data ); discrete_sound_w(discrete, SCHASER_MUSIC_BIT, data & 0x01); diff --git a/src/mame/drivers/hshavoc.c b/src/mame/drivers/hshavoc.c index dfa48ad421a..eb0401ac6fd 100644 --- a/src/mame/drivers/hshavoc.c +++ b/src/mame/drivers/hshavoc.c @@ -300,6 +300,7 @@ static DRIVER_INIT(hshavoc) } +/* Uncommented until actively worked on { FILE*FP; @@ -308,7 +309,7 @@ static DRIVER_INIT(hshavoc) fwrite(src, rom_size/2, 2, FP); fclose(FP); } - +*/ DRIVER_INIT_CALL(genesis); diff --git a/src/mame/drivers/ilpag.c b/src/mame/drivers/ilpag.c index 9d66f29ad13..8d5af3746ec 100644 --- a/src/mame/drivers/ilpag.c +++ b/src/mame/drivers/ilpag.c @@ -174,9 +174,9 @@ static WRITE16_HANDLER( blit_copy_w ) int x,y,x_size,y_size; UINT32 src; - printf("blit copy %04x %04x %04x %04x %04x\n", blit_romaddr[0], blit_attr1_ram[0], blit_dst_ram_loword[0], blit_attr2_ram[0], blit_dst_ram_hiword[0] ); - printf("blit vregs %04x %04x %04x %04x\n",blit_vregs[0/2],blit_vregs[2/2],blit_vregs[4/2],blit_vregs[6/2]); - printf("blit transpen %04x %04x %04x %04x %04x %04x %04x %04x\n",blit_transpen[0/2],blit_transpen[2/2],blit_transpen[4/2],blit_transpen[6/2], + logerror("blit copy %04x %04x %04x %04x %04x\n", blit_romaddr[0], blit_attr1_ram[0], blit_dst_ram_loword[0], blit_attr2_ram[0], blit_dst_ram_hiword[0] ); + logerror("blit vregs %04x %04x %04x %04x\n",blit_vregs[0/2],blit_vregs[2/2],blit_vregs[4/2],blit_vregs[6/2]); + logerror("blit transpen %04x %04x %04x %04x %04x %04x %04x %04x\n",blit_transpen[0/2],blit_transpen[2/2],blit_transpen[4/2],blit_transpen[6/2], blit_transpen[8/2],blit_transpen[10/2],blit_transpen[12/2],blit_transpen[14/2]); blit_dst_xpos = (blit_dst_ram_loword[0] & 0x00ff)*2; diff --git a/src/mame/drivers/raiden2.c b/src/mame/drivers/raiden2.c index 2d1d20dfd3b..7d65cffb3e1 100644 --- a/src/mame/drivers/raiden2.c +++ b/src/mame/drivers/raiden2.c @@ -2002,6 +2002,7 @@ static WRITE16_HANDLER( mcu_prog_w2 ) { mcu_prog[mcu_prog_offs*2+1] = data; +/* Uncommented until actively worked on { FILE *fp; fp=fopen("rdx_v33.dmp", "w+b"); @@ -2011,6 +2012,7 @@ static WRITE16_HANDLER( mcu_prog_w2 ) fclose(fp); } } +*/ } static WRITE16_HANDLER( mcu_prog_offs_w ) diff --git a/src/mame/drivers/trvmadns.c b/src/mame/drivers/trvmadns.c index 29ae2e1a977..3b32c0dc0cb 100644 --- a/src/mame/drivers/trvmadns.c +++ b/src/mame/drivers/trvmadns.c @@ -104,7 +104,7 @@ static WRITE8_HANDLER( trvmadns_banking_w ) if(data != old_data) { old_data = data; - printf("port80 = %02X\n",data); + logerror("port80 = %02X\n",data); //logerror("port80 = %02X\n",data); } @@ -134,7 +134,7 @@ static WRITE8_HANDLER( trvmadns_banking_w ) //address |= (data & 0x08) ? 0x8000 : 0; -// printf("add = %X\n",address); +// logerror("add = %X\n",address); memory_set_bankptr(space->machine, 1, &rom[address]); } @@ -166,7 +166,7 @@ static WRITE8_HANDLER( w2 ) { /* static int old = -1; if(data!=old) - printf("w2 = %02X\n",old=data); + logerror("w2 = %02X\n",old=data); */ } @@ -174,7 +174,7 @@ static WRITE8_HANDLER( w3 ) { /* static int old = -1; if(data!=old) - printf("w3 = %02X\n",old=data); + logerror("w3 = %02X\n",old=data); */ } @@ -187,7 +187,7 @@ static WRITE8_HANDLER( trvmadns_tileram_w ) cputag_set_input_line(space->machine, "maincpu", 0, HOLD_LINE); } // else -// printf("%x \n", cpu_get_previouspc(space->cpu)); +// logerror("%x \n", cpu_get_previouspc(space->cpu)); } diff --git a/src/mame/machine/archimds.c b/src/mame/machine/archimds.c index 1c82f410c71..bf79377d593 100644 --- a/src/mame/machine/archimds.c +++ b/src/mame/machine/archimds.c @@ -202,7 +202,7 @@ READ32_HANDLER(memc_logical_r) } else { - printf("ARCHIMEDES_MEMC: Reading unmapped page, what do we do?\n"); + logerror("ARCHIMEDES_MEMC: Reading unmapped page, what do we do?\n"); } } @@ -232,7 +232,7 @@ WRITE32_HANDLER(memc_logical_w) } else { - printf("ARCHIMEDES_MEMC: Writing unmapped page, what do we do?\n"); + logerror("ARCHIMEDES_MEMC: Writing unmapped page, what do we do?\n"); } } } diff --git a/src/mame/machine/seicop.c b/src/mame/machine/seicop.c index c45da1519fe..f77c6762936 100644 --- a/src/mame/machine/seicop.c +++ b/src/mame/machine/seicop.c @@ -86,6 +86,7 @@ static void copd2_set_tableoffset(running_machine *machine, UINT16 data) copd2_table_3[copd2_offs/8] = cop_43a; copd2_table_4[copd2_offs/8] = cop_43c; +/* Uncommented until actively worked on { FILE *fp; char filename[256]; @@ -119,6 +120,7 @@ static void copd2_set_tableoffset(running_machine *machine, UINT16 data) fclose(fp); } } +*/ } @@ -127,6 +129,7 @@ static void copd2_set_tabledata(running_machine *machine, UINT16 data) copd2_table[copd2_offs] = data; logerror("mcu_data %04x\n", data); +/* Uncommented until actively worked on { FILE *fp; char filename[256]; @@ -138,6 +141,7 @@ static void copd2_set_tabledata(running_machine *machine, UINT16 data) fclose(fp); } } +*/ }