Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-19 23:12:11 +03:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

konamigx_v.cpp, konamigx.h: implement brightness for layers (#13400)

Browse Source 
* konamigx_v.cpp, konamigx.h: implement brightness for layers
* konamigx_m.cpp: initial implementation of operation 0x98
This commit is contained in:
Fredrik Sandkvist 2025-03-01 19:19:33 +01:00 committed by GitHub
parent be62159ab8
commit 5360641faf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 70 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mame/konami/konamigx.h
View File

@ -144,6 +144,7 @@ public:
void konamigx_precache_registers(void);
void wipezbuf(int noshadow);
void set_brightness(int layer);
void dmastart_callback(int data);
@ -247,6 +248,9 @@ protected:
uint16_t *m_gx_spriteram = nullptr;
std::unique_ptr<uint16_t[]> m_gx_spriteram_alloc;
u8 m_current_brightness = 0xff;
u8 m_brightness[3]{};
// mirrored K054338 settings
int *m_K054338_shdRGB = nullptr;

67
src/mame/konami/konamigx_m.cpp
View File

@ -53,8 +53,8 @@ uint16_t konamigx_state::K055550_word_r(offs_t offset)
void konamigx_state::K055550_word_w(offs_t offset, uint16_t data, uint16_t mem_mask)
{
auto &mspace = m_maincpu->space(AS_PROGRAM);
uint32_t adr, bsize, count, i, lim;
int src, tgt, srcend, tgtend, skip, cx1, sx1, wx1, cy1, sy1, wy1, cz1, sz1, wz1, c2, s2, w2;
uint32_t adr, bsize, count, i, lim, src, dst;
int tgt, srcend, tgtend, skip, cx1, sx1, wx1, cy1, sy1, wy1, cz1, sz1, wz1, c2, s2, w2;
int dx, dy, angle;
COMBINE_DATA(m_prot_data+offset);
@ -71,10 +71,25 @@ void konamigx_state::K055550_word_w(offs_t offset, uint16_t data, uint16_t mem_m
count = (m_prot_data[0] & 0xff) + 1;
lim = adr+bsize*count;
for(i=adr; i<lim; i+=2)
for (i = adr; i < lim; i += 2)
mspace.write_word(i, m_prot_data[0x1a/2]);
break;
case 0x98: // memcpy of some kind. incomplete
// known use cases:
// viostorm: transfer "color check" palette
dst = (m_prot_data[7] << 16) | m_prot_data[8];
src = (m_prot_data[2] << 16) | m_prot_data[3];
count = (m_prot_data[10] << 16 | m_prot_data[11]) >> 2;
for (int x = 0; x < count; ++x)
{
const u32 src_data = mspace.read_dword(src + x * 8);
mspace.write_dword(dst + x * 4, src_data);
}
break;
// WARNING: The following cases are speculation based with questionable accuracy!(AAT)
case 0x87: // unknown memory write (Violent Storm at 0x00b6ea)
@ -101,7 +116,7 @@ void konamigx_state::K055550_word_w(offs_t offset, uint16_t data, uint16_t mem_m
tgtend = srcend + bsize;
// let's hope GCC will inline the mem24bew calls
for (src=adr; src<srcend; src+=bsize)
for (src = adr; src < srcend; src += bsize)
{
cx1 = (short)mspace.read_word(src);
sx1 = (short)mspace.read_word(src + 2);
@ -118,24 +133,24 @@ void konamigx_state::K055550_word_w(offs_t offset, uint16_t data, uint16_t mem_m
count = i = src + skip;
tgt = src + bsize;
for (; count<tgt; count++) mspace.write_byte(count, 0);
for (; count < tgt; count++) mspace.write_byte(count, 0);
for (; tgt<tgtend; i++, tgt+=bsize)
for (; tgt < tgtend; i++, tgt += bsize)
{
c2 = (short)mspace.read_word(tgt);
s2 = (short)mspace.read_word(tgt + 2);
w2 = (short)mspace.read_word(tgt + 4);
if (abs((cx1+sx1)-(c2+s2))>=wx1+w2) continue; // X rejection
if (abs((cx1 + sx1) - (c2 + s2)) >= wx1 + w2) continue; // X rejection
c2 = (short)mspace.read_word(tgt + 6);
s2 = (short)mspace.read_word(tgt + 8);
w2 = (short)mspace.read_word(tgt +10);
if (abs((cy1+sy1)-(c2+s2))>=wy1+w2) continue; // Y rejection
if (abs((cy1 + sy1) - (c2 + s2)) >= wy1 + w2) continue; // Y rejection
c2 = (short)mspace.read_word(tgt +12);
s2 = (short)mspace.read_word(tgt +14);
w2 = (short)mspace.read_word(tgt +16);
if (abs((cz1+sz1)-(c2+s2))>=wz1+w2) continue; // Z rejection
if (abs((cz1 + sz1) - (c2 + s2)) >= wz1 + w2) continue; // Z rejection
mspace.write_byte(i, 0x80); // collision confirmed
}
@ -211,13 +226,13 @@ void konamigx_state::K053990_martchmp_word_w(offs_t offset, uint16_t data, uint1
dst_skip += element_size;
if (element_size == 1)
for (i=src_count; i; i--)
for (i = src_count; i; i--)
{
mspace.write_byte(dst_addr, mspace.read_byte(src_addr));
src_addr += src_skip;
dst_addr += dst_skip;
}
else for (i=src_count; i; i--)
else for (i = src_count; i; i--)
{
mspace.write_word(dst_addr, mspace.read_word(src_addr));
src_addr += src_skip;
@ -387,7 +402,7 @@ if((data1=obj[0])&0x80000000)\
case 0x11010010: i = 5; vmask = 0x1ff; break;
case 0x01111018: i = 4; break;
case 0x10010011: i = 3;
if ((srcbase[0x1c75]&0xff)==32) m_k055555->K055555_write_reg(K55_BLEND_ENABLES,36); // (TEMPORARY)
if ((srcbase[0x1c75] & 0xff) == 32) m_k055555->K055555_write_reg(K55_BLEND_ENABLES,36); // (TEMPORARY)
break;
case 0x11010811: i = 2; break;
case 0x10000010: i = 1; break;
@ -424,8 +439,8 @@ if((data1=obj[0])&0x80000000)\
// decode Lord British (the designer must be a Richard Garriot fan too:)
if (srcbase[0x0848/4] & 0x0000ffff)
{
hoffs = srcbase[0x08b0/4]>>16;
voffs = srcbase[0x08b4/4]>>16;
hoffs = srcbase[0x08b0/4] >> 16;
voffs = srcbase[0x08b4/4] >> 16;
hoffs -= hcorr;
voffs -= vcorr;
obj = &srcbase[0x084c/4];
@ -445,8 +460,8 @@ if((data1=obj[0])&0x80000000)\
i = src[7] & 0xf;
if (!i) continue; // reject retired or zero-element groups
i <<= 2;
hoffs = src[5]>>16;
voffs = src[6]>>16;
hoffs = src[5] >> 16;
voffs = src[6] >> 16;
hoffs -= hcorr;
voffs -= vcorr;
obj = src + 8;
@ -456,9 +471,9 @@ if((data1=obj[0])&0x80000000)\
{
EXTRACT_EVEN
}
while ((obj+=4)<objend);
while ((obj += 4) < objend);
}
while ((src+=0x30)<srcend);
while ((src += 0x30) < srcend);
// clear residual data
if (j) do { *dst = 0; dst += 8; } while (--j);
@ -480,7 +495,7 @@ void konamigx_state::fantjour_dma_w(offs_t offset, uint32_t data, uint32_t mem_m
{
auto &mspace = m_maincpu->space(AS_PROGRAM);
COMBINE_DATA(m_fantjour_dma + offset);
if(!offset && ACCESSING_BITS_24_31) {
if (!offset && ACCESSING_BITS_24_31) {
uint32_t sa = m_fantjour_dma[1];
// uint16_t ss = (m_fantjour_dma[2] & 0xffff0000) >> 16;
// uint32_t sb = ((m_fantjour_dma[2] & 0xffff) << 16) | ((m_fantjour_dma[3] & 0xffff0000) >> 16);
@ -496,16 +511,18 @@ void konamigx_state::fantjour_dma_w(offs_t offset, uint32_t data, uint32_t mem_m
uint32_t x = m_fantjour_dma[6];
uint32_t i1, i2;
if(mode == 0x93)
for(i1=0; i1 <= sz2; i1++)
for(i2=0; i2 < db; i2+=4) {
if (mode == 0x93)
for (i1 = 0; i1 <= sz2; i1++)
for (i2 = 0; i2 < db; i2 += 4)
{
mspace.write_dword(da, mspace.read_dword(sa) ^ x);
da += 4;
sa += 4;
}
else if(mode == 0x8f)
for(i1=0; i1 <= sz2; i1++)
for(i2=0; i2 < db; i2+=4) {
else if (mode == 0x8f)
for (i1 = 0; i1 <= sz2; i1++)
for (i2 = 0; i2 < db; i2 += 4)
{
mspace.write_dword(da, x);
da += 4;
}

24
src/mame/konami/konamigx_v.cpp
View File

@ -54,6 +54,10 @@ void konamigx_state::konamigx_precache_registers(void)
m_vmixon = m_k055555->K055555_read_register(K55_VINMIX_ON);
m_osinmix = m_k055555->K055555_read_register(K55_OSBLEND_ENABLES);
m_osmixon = m_k055555->K055555_read_register(K55_OSBLEND_ON);
m_brightness[0] = u8(m_k054338->register_r(K338_REG_BRI3));
m_brightness[1] = u8(m_k054338->register_r(K338_REG_BRI3 + 1) >> 8);
m_brightness[2] = u8(m_k054338->register_r(K338_REG_BRI3 + 1));
}
inline int konamigx_state::K053247GX_combine_c18(int attrib) // (see p.46)
@ -243,6 +247,22 @@ void konamigx_state::wipezbuf(int noshadow)
}
}
void konamigx_state::set_brightness(int layer)
{
const u8 bri_mode = (m_k055555->K055555_read_register(K55_VBRI) >> layer * 2) & 0b11;
const u8 new_brightness = bri_mode ? m_brightness[bri_mode - 1] : 0xff;
if (m_current_brightness != new_brightness)
{
m_current_brightness = new_brightness;
for (int x = 0; x < m_palette->entries(); ++x)
{
m_palette->set_pen_contrast(x, m_current_brightness / 255.0);
}
}
}
/*
* Sprite Format
* ------------------
@ -664,6 +684,8 @@ void konamigx_state::gx_draw_basic_tilemaps(screen_device &screen, bitmap_rgb32
int disp = m_k055555->K055555_read_register(K55_INPUT_ENABLES);
if (disp & (1<<code))
{
set_brightness(code);
if (j == GXMIX_BLEND_NONE) { temp1 = 0xff; temp2 = temp3 = 0; } else
if (j == GXMIX_BLEND_FORCE) { temp1 = 0x00; temp2 = mixerflags>>(i+16); temp3 = 3; }
else
@ -1135,6 +1157,8 @@ void konamigx_state::common_init()
save_item(NAME(m_vmixon));
save_item(NAME(m_osinmix));
save_item(NAME(m_osmixon));
save_item(NAME(m_current_brightness));
save_item(NAME(m_brightness));
m_gx_tilemode = 0;