(get rid of old commented-out verbosity and some other source cleanup)

This commit is contained in:
Michaël Banaan Ananas 2013-04-18 20:47:21 +00:00
parent f540dd481d
commit 53ce1a4a56

View File

@ -108,50 +108,43 @@ void tc0140syt_device::interrupt_controller( )
WRITE8_MEMBER( tc0140syt_device::tc0140syt_port_w ) WRITE8_MEMBER( tc0140syt_device::tc0140syt_port_w )
{ {
data &= 0x0f; data &= 0x0f;
m_mainmode = data; m_mainmode = data;
//logerror("taitosnd: Master cpu mode [%02x]\n", data);
if (data > 4) if (data > 4)
{ {
logerror("tc0140syt : error Master entering unknown mode[%02x]\n", data); logerror("tc0140syt : error Master entering unknown mode[%02x]\n", data);
} }
} }
WRITE8_MEMBER( tc0140syt_device::tc0140syt_comm_w ) WRITE8_MEMBER( tc0140syt_device::tc0140syt_comm_w )
{ {
data &= 0x0f; /*this is important, otherwise ballbros won't work*/ data &= 0x0f; /* this is important, otherwise ballbros won't work */
switch (m_mainmode) switch (m_mainmode)
{ {
case 0x00: // mode #0 case 0x00: // mode #0
m_slavedata[m_mainmode ++] = data; m_slavedata[m_mainmode++] = data;
//logerror("taitosnd: Master cpu written port 0, data %01x\n", data);
break; break;
case 0x01: // mode #1 case 0x01: // mode #1
m_slavedata[m_mainmode ++] = data; m_slavedata[m_mainmode++] = data;
m_status |= TC0140SYT_PORT01_FULL; m_status |= TC0140SYT_PORT01_FULL;
m_nmi_req = 1; m_nmi_req = 1;
interrupt_controller(); interrupt_controller();
//logerror("taitosnd: Master cpu sends 0/1 : %01x%01x\n", m_slavedata[1], m_slavedata[0]);
break; break;
case 0x02: // mode #2 case 0x02: // mode #2
m_slavedata[m_mainmode ++] = data; m_slavedata[m_mainmode++] = data;
//logerror("taitosnd: Master cpu written port 2, data %01\n", data);
break; break;
case 0x03: // mode #3 case 0x03: // mode #3
m_slavedata[m_mainmode ++] = data; m_slavedata[m_mainmode++] = data;
m_status |= TC0140SYT_PORT23_FULL; m_status |= TC0140SYT_PORT23_FULL;
m_nmi_req = 1; m_nmi_req = 1;
interrupt_controller(); interrupt_controller();
//logerror("taitosnd: Master cpu sends 2/3 : %01x%01x\n", m_slavedata[3], m_slavedata[2]);
break; break;
case 0x04: // port status case 0x04: // port status
//logerror("taitosnd: Master issued control value %02x (PC = %08x) \n",data, space.device().safe_pc() );
/* this does a hi-lo transition to reset the sound cpu */ /* this does a hi-lo transition to reset the sound cpu */
if (data) if (data)
m_slavecpu->execute().set_input_line(INPUT_LINE_RESET, ASSERT_LINE); m_slavecpu->execute().set_input_line(INPUT_LINE_RESET, ASSERT_LINE);
@ -163,102 +156,101 @@ WRITE8_MEMBER( tc0140syt_device::tc0140syt_comm_w )
break; break;
default: default:
//logerror("taitosnd: Master cpu written in mode [%02x] data[%02x]\n", m_mainmode, data);
break; break;
} }
} }
READ8_MEMBER( tc0140syt_device::tc0140syt_comm_r ) READ8_MEMBER( tc0140syt_device::tc0140syt_comm_r )
{ {
switch( m_mainmode ) UINT8 res = 0;
switch (m_mainmode)
{ {
case 0x00: // mode #0 case 0x00: // mode #0
//logerror("taitosnd: Master cpu read portdata %01x\n", m_masterdata[0]); res = m_masterdata[m_mainmode++];
return m_masterdata[m_mainmode ++]; break;
case 0x01: // mode #1 case 0x01: // mode #1
//logerror("taitosnd: Master cpu receives 0/1 : %01x%01x\n", m_masterdata[1], m_masterdata[0]);
m_status &= ~TC0140SYT_PORT01_FULL_MASTER; m_status &= ~TC0140SYT_PORT01_FULL_MASTER;
return m_masterdata[m_mainmode ++]; res = m_masterdata[m_mainmode++];
break;
case 0x02: // mode #2 case 0x02: // mode #2
//logerror("taitosnd: Master cpu read masterdata %01x\n", m_masterdata[2]); res = m_masterdata[m_mainmode++];
return m_masterdata[m_mainmode ++]; break;
case 0x03: // mode #3 case 0x03: // mode #3
//logerror("taitosnd: Master cpu receives 2/3 : %01x%01x\n", m_masterdata[3], m_masterdata[2]);
m_status &= ~TC0140SYT_PORT23_FULL_MASTER; m_status &= ~TC0140SYT_PORT23_FULL_MASTER;
return m_masterdata[m_mainmode ++]; res = m_masterdata[m_mainmode++];
break;
case 0x04: // port status case 0x04: // port status
//logerror("tc0140syt : Master cpu read status : %02x\n", m_status); res = m_status;
return m_status; break;
default: default:
//logerror("tc0140syt : Master cpu read in mode [%02x]\n", m_mainmode); break;
return 0;
} }
return res;
} }
//------------------------------------------------- //-------------------------------------------------
//SLAVE SIDE // SLAVE SIDE
//------------------------------------------------- //-------------------------------------------------
WRITE8_MEMBER( tc0140syt_device::tc0140syt_slave_port_w ) WRITE8_MEMBER( tc0140syt_device::tc0140syt_slave_port_w )
{ {
data &= 0x0f; data &= 0x0f;
m_submode = data; m_submode = data;
//logerror("taitosnd: Slave cpu mode [%02x]\n", data);
if (data > 6) if (data > 6)
{
logerror("tc0140syt error : Slave cpu unknown mode[%02x]\n", data); logerror("tc0140syt error : Slave cpu unknown mode[%02x]\n", data);
}
} }
WRITE8_MEMBER( tc0140syt_device::tc0140syt_slave_comm_w ) WRITE8_MEMBER( tc0140syt_device::tc0140syt_slave_comm_w )
{ {
data &= 0x0f; data &= 0x0f;
switch (m_submode) switch (m_submode)
{ {
case 0x00: // mode #0 case 0x00: // mode #0
m_masterdata[m_submode ++] = data; m_masterdata[m_submode++] = data;
//logerror("taitosnd: Slave cpu written port 0, data %01x\n", data);
break; break;
case 0x01: // mode #1 case 0x01: // mode #1
m_masterdata[m_submode ++] = data; m_masterdata[m_submode++] = data;
m_status |= TC0140SYT_PORT01_FULL_MASTER; m_status |= TC0140SYT_PORT01_FULL_MASTER;
//logerror("taitosnd: Slave cpu sends 0/1 : %01x%01x\n" , m_masterdata[1] , m_masterdata[0]);
m_slavecpu->execute().spin(); /* writing should take longer than emulated, so spin */ m_slavecpu->execute().spin(); /* writing should take longer than emulated, so spin */
break; break;
case 0x02: // mode #2 case 0x02: // mode #2
//logerror("taitosnd: Slave cpu written port 2, data %01x\n", data); m_masterdata[m_submode++] = data;
m_masterdata[m_submode ++] = data;
break; break;
case 0x03: // mode #3 case 0x03: // mode #3
m_masterdata[m_submode ++] = data; m_masterdata[m_submode++] = data;
m_status |= TC0140SYT_PORT23_FULL_MASTER; m_status |= TC0140SYT_PORT23_FULL_MASTER;
//logerror("taitosnd: Slave cpu sends 2/3 : %01x%01x\n" , m_masterdata[3] , m_masterdata[2]);
m_slavecpu->execute().spin(); /* writing should take longer than emulated, so spin */ m_slavecpu->execute().spin(); /* writing should take longer than emulated, so spin */
break; break;
case 0x04: // port status case 0x04: // port status
//m_status = TC0140SYT_SET_OK; //m_status = TC0140SYT_SET_OK;
//logerror("tc0140syt : Slave cpu status ok.\n");
break; break;
case 0x05: // nmi disable case 0x05: // nmi disable
m_nmi_enabled = 0; m_nmi_enabled = 0;
break; break;
case 0x06: // nmi enable case 0x06: // nmi enable
m_nmi_enabled = 1; m_nmi_enabled = 1;
interrupt_controller(); interrupt_controller();
break; break;
default: default:
//logerror("tc0140syt: Slave cpu written in mode [%02x] data[%02x]\n" , m_submode, data & 0xff);
break; break;
} }
} }
@ -267,38 +259,31 @@ READ8_MEMBER( tc0140syt_device::tc0140syt_slave_comm_r )
{ {
UINT8 res = 0; UINT8 res = 0;
switch ( m_submode ) switch (m_submode)
{ {
case 0x00: // mode #0 case 0x00: // mode #0
//logerror("taitosnd: Slave cpu read slavedata %01x\n", m_slavedata[0]); res = m_slavedata[m_submode++];
res = m_slavedata[m_submode ++];
break; break;
case 0x01: // mode #1 case 0x01: // mode #1
//logerror("taitosnd: Slave cpu receives 0/1 : %01x%01x PC=%4x\n", m_slavedata[1] , m_slavedata[0],space.device().safe_pc());
m_status &= ~TC0140SYT_PORT01_FULL; m_status &= ~TC0140SYT_PORT01_FULL;
res = m_slavedata[m_submode ++]; res = m_slavedata[m_submode++];
break; break;
case 0x02: // mode #2 case 0x02: // mode #2
//logerror("taitosnd: Slave cpu read slavedata %01x\n", m_slavedata[2]); res = m_slavedata[m_submode++];
res = m_slavedata[m_submode ++];
break; break;
case 0x03: // mode #3 case 0x03: // mode #3
//logerror("taitosnd: Slave cpu receives 2/3 : %01x%01x\n", m_slavedata[3] , m_slavedata[2]);
m_status &= ~TC0140SYT_PORT23_FULL; m_status &= ~TC0140SYT_PORT23_FULL;
res = m_slavedata[m_submode ++]; res = m_slavedata[m_submode++];
break; break;
case 0x04: // port status case 0x04: // port status
//logerror("tc0140syt : Slave cpu read status : %02x\n", m_status);
res = m_status; res = m_status;
break; break;
default: default:
//logerror("tc0140syt : Slave cpu read in mode [%02x]\n", m_submode);
res = 0;
break; break;
} }