From 58c512b761a18401c2d11396e73d78bbba32af6b Mon Sep 17 00:00:00 2001 From: Vas Crabb Date: Fri, 27 Sep 2019 22:33:47 +1000 Subject: [PATCH] (nw) Misc cleanup: * bagman.cpp: use CONFblah for sense lines that don't warrant a different machine * comx35.cpp: fix a "bool in integer context" thing * supstarf.cpp: update commented code to devcb3 syntax --- src/mame/drivers/bagman.cpp | 6 +++--- src/mame/drivers/comx35.cpp | 2 +- src/mame/drivers/supstarf.cpp | 3 +-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mame/drivers/bagman.cpp b/src/mame/drivers/bagman.cpp index c5175916802..b2f59c77be2 100644 --- a/src/mame/drivers/bagman.cpp +++ b/src/mame/drivers/bagman.cpp @@ -274,9 +274,9 @@ static INPUT_PORTS_START( pickin ) PORT_DIPNAME( 0x40, 0x40, DEF_STR( Language ) ) PORT_DIPLOCATION("SW1:6") PORT_DIPSETTING( 0x40, DEF_STR( English ) ) PORT_DIPSETTING( 0x00, DEF_STR( French ) ) - PORT_DIPNAME( 0x80, 0x80, DEF_STR( Cabinet ) ) /* Cabinet type set through edge connector, not dip switch (verified on real pcb) */ - PORT_DIPSETTING( 0x80, DEF_STR( Upright ) ) - PORT_DIPSETTING( 0x00, DEF_STR( Cocktail ) ) + PORT_CONFNAME(0x80, 0x80, DEF_STR( Cabinet ) ) // sense line on wiring harness + PORT_CONFSETTING( 0x80, DEF_STR( Upright ) ) + PORT_CONFSETTING( 0x00, DEF_STR( Cocktail ) ) INPUT_PORTS_END diff --git a/src/mame/drivers/comx35.cpp b/src/mame/drivers/comx35.cpp index e596b752045..0db94f4f0a1 100644 --- a/src/mame/drivers/comx35.cpp +++ b/src/mame/drivers/comx35.cpp @@ -465,7 +465,7 @@ READ_LINE_MEMBER( comx35_state::ef2_r ) READ_LINE_MEMBER( comx35_state::ef4_r ) { - return m_exp->ef4_r() | (m_cassette->input() > 0.0f); + return m_exp->ef4_r() | ((m_cassette->input() > 0.0f) ? 1 : 0); } WRITE_LINE_MEMBER( comx35_state::q_w ) diff --git a/src/mame/drivers/supstarf.cpp b/src/mame/drivers/supstarf.cpp index 597d940addf..b27cdf735c7 100644 --- a/src/mame/drivers/supstarf.cpp +++ b/src/mame/drivers/supstarf.cpp @@ -194,8 +194,7 @@ void supstarf_state::supstarf(machine_config &config) I8212(config, m_soundlatch[1]); m_soundlatch[1]->md_rd_callback().set_constant(0); - m_soundlatch[1]->int_wr_callback().set_inputline("soundcpu", MCS48_INPUT_IRQ); - //MCFG_DEVCB_CHAIN_OUTPUT(INPUTLINE("maincpu", I8085_READY_LINE)) + m_soundlatch[1]->int_wr_callback().set_inputline("soundcpu", MCS48_INPUT_IRQ)/*.append_inputline(m_maincpu, I8085_READY_LINE)*/; SPEAKER(config, "mono").front_center();