Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-25 01:40:16 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Eliminated virtual function use in strconv.cpp

Browse Source 
Take note that in practice, this does not actually change the compiled code because the optimizer should be smart enough to remove the need for vtable lookups as a part of optimization (this is definitely true for MinGW).  If you really prefer, I can collapse the class hierarchy into a single templated class that just has overloaded constructors - this also doesn't actually change the compiled code, but I can make the change if you wish.
This commit is contained in:
Nathan Woods 2016-10-03 08:37:03 -04:00
parent 314a7e7906
commit 6549ec8ccf
1 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/osd/strconv.cpp
View File

@ -25,8 +25,18 @@ namespace
class string_source
{
public:
virtual const T *string() const = 0; // returns pointer to actual characters
virtual int char_count() const = 0; // returns the character count (including NUL terminater), or -1 if NUL terminated
const T *string() const { return m_str; }; // returns pointer to actual characters
virtual int char_count() const { return m_char_count; } // returns the character count (including NUL terminater), or -1 if NUL terminated
protected:
string_source(const T *str, int char_count) : m_str(str), m_char_count(char_count)
{
assert(str != nullptr);
}
private:
const T *m_str;
int m_char_count;
};
// implementation of string_source for NUL-terminated strings
@ -34,16 +44,9 @@ namespace
class null_terminated_string_source : public string_source<T>
{
public:
null_terminated_string_source(const T *str) : m_str(str)
null_terminated_string_source(const T *str) : string_source<T>(str, -1)
{
assert(str != nullptr);
}
virtual const T *string() const override { return m_str; }
virtual int char_count() const override { return -1; }
private:
const T *m_str;
};
// implementation of string_source for std::[w]string
@ -51,15 +54,9 @@ namespace
class basic_string_source : public string_source<T>
{
public:
basic_string_source(const std::basic_string<T> &str) : m_str(str)
basic_string_source(const std::basic_string<T> &str) : string_source<T>(str.c_str(), (int)str.size() + 1)
{
}
virtual const T *string() const override { return m_str.c_str(); }
virtual int char_count() const override { return (int) m_str.size() + 1; }
private:
const std::basic_string<T> &m_str;
};
};