Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-07-08 03:12:37 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #7288 from DavidHaywood/240920_2

Browse Source 
small quality of life cleanups
This commit is contained in:
ajrhacker 2020-09-24 19:48:16 -04:00 committed by GitHub
commit 673ee99a3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 34 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/devices/machine/bl_handhelds_menucontrol.cpp
View File

@ -206,7 +206,7 @@ void bl_handhelds_menucontrol_device::device_start()
save_item(NAME(m_response)); save_item(NAME(m_response));
save_item(NAME(m_commandbit)); save_item(NAME(m_commandbit));
save_item(NAME(m_command)); save_item(NAME(m_command));
//save_item(NAME(m_menustate)); save_item(NAME(m_menustate));
} }
void bl_handhelds_menucontrol_device::device_reset() void bl_handhelds_menucontrol_device::device_reset()

14
src/devices/machine/bl_handhelds_menucontrol.h
View File

@ -32,21 +32,21 @@ private:
bool m_is_unsp_type_hack; bool m_is_unsp_type_hack;
// internal state // internal state
int m_menupos; uint16_t m_menupos;
// command handling // command handling
int m_clockstate; uint8_t m_clockstate;
int m_datashifterpos; uint8_t m_datashifterpos;
int m_responsebit; uint8_t m_responsebit;
uint8_t m_response; uint8_t m_response;
int m_commandbit; uint8_t m_commandbit;
uint8_t m_command; uint8_t m_command;
void handle_command(); void handle_command();
enum menustate : const int enum menustate : uint8_t
{ {
MENU_READY_FOR_COMMAND = 0, MENU_READY_FOR_COMMAND = 0,
@ -58,7 +58,7 @@ private:
MENU_COMMAND_05_IN, MENU_COMMAND_05_IN,
}; };
menustate m_menustate; uint8_t m_menustate;
}; };
#endif // MAME_MACHINE_BL_HANDHELDS_MENUCONTROL_H #endif // MAME_MACHINE_BL_HANDHELDS_MENUCONTROL_H

36
src/mame/drivers/nes_vt.cpp
View File

@ -34,8 +34,7 @@ public:
m_exin1(*this, "EXTRAIN1"), m_exin1(*this, "EXTRAIN1"),
m_exin2(*this, "EXTRAIN2"), m_exin2(*this, "EXTRAIN2"),
m_exin3(*this, "EXTRAIN3"), m_exin3(*this, "EXTRAIN3"),
m_prgrom(*this, "mainrom"), m_prgrom(*this, "mainrom")
m_previous_port0(0)
{ } { }
protected: protected:
@ -48,17 +47,12 @@ protected:
void nes_vt_map(address_map& map); void nes_vt_map(address_map& map);
optional_ioport m_io0; optional_ioport m_io0;
optional_ioport m_io1; optional_ioport m_io1;
uint8_t m_latch0; uint8_t m_latch0;
uint8_t m_latch1; uint8_t m_latch1;
uint8_t m_previous_port0;
/* Misc */
uint32_t m_ahigh; // external banking bits
uint8_t m_4242;
uint8_t m_411c;
uint8_t m_411d;
optional_ioport m_cartsel; optional_ioport m_cartsel;
optional_ioport m_exin0; optional_ioport m_exin0;
@ -66,6 +60,12 @@ protected:
optional_ioport m_exin2; optional_ioport m_exin2;
optional_ioport m_exin3; optional_ioport m_exin3;
/* Misc */
uint32_t m_ahigh; // external banking bits
uint8_t m_4242;
uint8_t m_411c;
uint8_t m_411d;
required_region_ptr<uint8_t> m_prgrom; required_region_ptr<uint8_t> m_prgrom;
uint8_t vt_rom_r(offs_t offset); uint8_t vt_rom_r(offs_t offset);
@ -76,7 +76,6 @@ protected:
uint8_t upper_412c_r(); uint8_t upper_412c_r();
uint8_t upper_412d_r(); uint8_t upper_412d_r();
void upper_412c_w(uint8_t data); void upper_412c_w(uint8_t data);
int m_previous_port0;
private: private:
/* APU handling */ /* APU handling */
@ -649,6 +648,23 @@ void nes_vt_ablping_state::ablping_extraio_w(uint8_t data)
void nes_vt_base_state::machine_start() void nes_vt_base_state::machine_start()
{ {
m_latch0 = 0;
m_latch1 = 0;
m_previous_port0 = 0;
m_ahigh = 0;
m_4242 = 0;
m_411c = 0;
m_411d = 0;
save_item(NAME(m_latch0));
save_item(NAME(m_latch1));
save_item(NAME(m_previous_port0));
save_item(NAME(m_ahigh));
save_item(NAME(m_4242));
save_item(NAME(m_411c));
save_item(NAME(m_411d));
} }
void nes_vt_base_state::machine_reset() void nes_vt_base_state::machine_reset()