From 71373de1582b3681974a5bd237bd5ade4bf58f0a Mon Sep 17 00:00:00 2001 From: Fabio Priuli Date: Sun, 21 Sep 2014 09:51:20 +0000 Subject: [PATCH] old Apple GCC at least is good at catching comparisons which are always true :) nw. --- src/emu/bus/snes/snes_slot.c | 2 +- src/emu/machine/i8279.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/emu/bus/snes/snes_slot.c b/src/emu/bus/snes/snes_slot.c index ce1ddf1426f..940ec1c829e 100644 --- a/src/emu/bus/snes/snes_slot.c +++ b/src/emu/bus/snes/snes_slot.c @@ -1362,7 +1362,7 @@ void base_sns_cart_slot_device::internal_header_logging(UINT8 *ROM, UINT32 len) logerror( "\tSize: %d megabits [%d]\n", 1 << (ROM[hilo_mode + 0x17] - 7), ROM[hilo_mode + 0x17]); logerror( "\tSRAM: %d kilobits [%d]\n", ROM[hilo_mode + 0x18] * 8, ROM[hilo_mode + 0x18] ); - assert(ROM[hilo_mode + 0x19] >= 0 && ROM[hilo_mode + 0x19] < ARRAY_LENGTH(countries)); + assert(ROM[hilo_mode + 0x19] < ARRAY_LENGTH(countries)); logerror( "\tCountry: %s [%d]\n", countries[ROM[hilo_mode + 0x19]], ROM[hilo_mode + 0x19]); logerror( "\tLicense: %s [%X]\n", companies[ROM[hilo_mode + 0x1a]], ROM[hilo_mode + 0x1a]); logerror( "\tVersion: 1.%d\n", ROM[hilo_mode + 0x1b]); diff --git a/src/emu/machine/i8279.c b/src/emu/machine/i8279.c index 502086f05d3..43f02cc2102 100644 --- a/src/emu/machine/i8279.c +++ b/src/emu/machine/i8279.c @@ -316,7 +316,7 @@ void i8279_device::timer_mainloop() for (addr=0; !BIT(m_scanner, addr); addr++); rl ^= 0xff; // inverted - assert(addr >= 0 && addr < ARRAY_LENGTH(m_s_ram)); + assert(addr < ARRAY_LENGTH(m_s_ram)); if (m_s_ram[addr] != rl) { m_s_ram[addr] = rl; @@ -378,7 +378,7 @@ READ8_MEMBER( i8279_device::data_r ) if (sensor_mode) { // read sensor ram - assert(m_s_ram_ptr >= 0 && m_s_ram_ptr < ARRAY_LENGTH(m_s_ram)); + assert(m_s_ram_ptr < ARRAY_LENGTH(m_s_ram)); data = m_s_ram[m_s_ram_ptr]; if (m_autoinc) m_s_ram_ptr++;