Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-05-23 22:20:01 +03:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

PIC16C5x CPU - Count input fix

Browse Source 
- Fixed the T0CKI count input being controlled by the wrong edge sensing
This commit is contained in:
Quench 2009-09-09 13:58:19 +00:00
parent 8015c7a47f
commit 740ae26ae6
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/emu/cpu/pic16c5x/pic16c5x.c
View File

@ -38,6 +38,8 @@
* the W register. * * the W register. *
* - 'tris' instruction no longer modifies Port-C on PIC models that * * - 'tris' instruction no longer modifies Port-C on PIC models that *
* do not have Port-C implemented. * * do not have Port-C implemented. *
* TLP (07-Sep-2009) Ver 1.14 *
* - Edge sense control for the T0 count input was incorrectly reversed *
* * * *
* * * *
* **** Notes: **** * * **** Notes: **** *
@ -160,8 +162,8 @@ INLINE void update_internalram_ptr(pic16c5x_state *cpustate)
#define ADDR (cpustate->opcode.b.l & 0x1f) #define ADDR (cpustate->opcode.b.l & 0x1f)
#define POSITIVE_EDGE_T0 (( (int)(T0_in - cpustate->old_T0) > 0) ? 1 : 0) #define RISING_EDGE_T0 (( (int)(T0_in - cpustate->old_T0) > 0) ? 1 : 0)
#define NEGATIVE_EDGE_T0 (( (int)(cpustate->old_T0 - T0_in) > 0) ? 1 : 0) #define FALLING_EDGE_T0 (( (int)(T0_in - cpustate->old_T0) < 0) ? 1 : 0)
/******** The following is the Status Flag register definition. *********/ /******** The following is the Status Flag register definition. *********/
@ -882,7 +884,7 @@ static void pic16c5x_update_timer(pic16c5x_state *cpustate, int counts)
static CPU_EXECUTE( pic16c5x ) static CPU_EXECUTE( pic16c5x )
{ {
pic16c5x_state *cpustate = get_safe_token(device); pic16c5x_state *cpustate = get_safe_token(device);
int T0_in; UINT8 T0_in;
update_internalram_ptr(cpustate); update_internalram_ptr(cpustate);
@ -919,13 +921,14 @@ static CPU_EXECUTE( pic16c5x )
if (T0CS) { /* Count mode */ if (T0CS) { /* Count mode */
T0_in = S_T0_IN; T0_in = S_T0_IN;
if (T0SE) { /* Count rising edge */ if (T0_in) T0_in = 1;
if (POSITIVE_EDGE_T0) { if (T0SE) { /* Count falling edge T0 input */
if (FALLING_EDGE_T0) {
pic16c5x_update_timer(cpustate, 1); pic16c5x_update_timer(cpustate, 1);
} }
} }
else { /* Count falling edge */ else { /* Count rising edge T0 input */
if (NEGATIVE_EDGE_T0) { if (RISING_EDGE_T0) {
pic16c5x_update_timer(cpustate, 1); pic16c5x_update_timer(cpustate, 1);
} }
} }
@ -1052,7 +1055,7 @@ static CPU_GET_INFO( pic16c5x )
/* --- the following bits of info are returned as NULL-terminated strings --- */ /* --- the following bits of info are returned as NULL-terminated strings --- */
case DEVINFO_STR_NAME: strcpy(info->s, "PIC16C5x"); break; case DEVINFO_STR_NAME: strcpy(info->s, "PIC16C5x"); break;
case DEVINFO_STR_FAMILY: strcpy(info->s, "Microchip"); break; case DEVINFO_STR_FAMILY: strcpy(info->s, "Microchip"); break;
case DEVINFO_STR_VERSION: strcpy(info->s, "1.13"); break; case DEVINFO_STR_VERSION: strcpy(info->s, "1.14"); break;
case DEVINFO_STR_SOURCE_FILE: strcpy(info->s, __FILE__); break; case DEVINFO_STR_SOURCE_FILE: strcpy(info->s, __FILE__); break;
case DEVINFO_STR_CREDITS: strcpy(info->s, "Copyright Tony La Porta"); break; case DEVINFO_STR_CREDITS: strcpy(info->s, "Copyright Tony La Porta"); break;