Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-18 22:49:58 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

CD-i: Fix DYUV off-by-1 (#13511)

Browse Source 
The DYUV decoder requires an interpolation between steps. The previous implementation was based on the manual. This interpolation is based on visual comparison to the hardware.
This commit is contained in:
Vincent-Halver 2025-03-26 19:23:19 -07:00 committed by GitHub
parent 52f1f3ac1c
commit 7555232b0c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/mame/philips/mcd212.cpp
View File

@ -590,21 +590,24 @@ void mcd212_device::process_vsr(uint32_t *pixels, bool *transparent)
{
const uint8_t byte1 = data[(vsr++ & 0x0007ffff) ^ 1];
const uint8_t y2 = y + m_delta_y_lut[byte];
const uint8_t y4 = y2 + m_delta_y_lut[byte1];
y = y2 + m_delta_y_lut[byte1];
u += m_delta_uv_lut[byte];
v += m_delta_uv_lut[byte1];
const uint8_t u4 = u + m_delta_uv_lut[byte];
const uint8_t v4 = v + m_delta_uv_lut[byte1];
const uint8_t u2 = (u >> 1) + (u4 >> 1) + (u & u4 & 1);
const uint8_t v2 = (v >> 1) + (v4 >> 1) + (v & v4 & 1);
uint32_t* limit_rgb = m_dyuv_limit_lut + y2 + 0x100;
uint32_t* limit_rgb2 = m_dyuv_limit_lut + y + 0x100;
uint32_t *limit_rgb = m_dyuv_limit_lut + y2 + 0x100;
color0 = (limit_rgb[m_dyuv_v_to_r[v2]] << 16) | (limit_rgb[m_dyuv_u_to_g[u2] + m_dyuv_v_to_g[v2]] << 8) | limit_rgb[m_dyuv_u_to_b[u2]];
limit_rgb = m_dyuv_limit_lut + y4 + 0x100;
color1 = (limit_rgb[m_dyuv_v_to_r[v4]] << 16) | (limit_rgb[m_dyuv_u_to_g[u4] + m_dyuv_v_to_g[v4]] << 8) | limit_rgb[m_dyuv_u_to_b[u4]];
color0 = (limit_rgb[m_dyuv_v_to_r[v]] << 16) | (limit_rgb[m_dyuv_u_to_g[u] + m_dyuv_v_to_g[v]] << 8) | limit_rgb[m_dyuv_u_to_b[u]];
const uint8_t byte2 = data[(vsr & 0x0007ffff) ^ 1]; // Peek ahead, for calculating the half-step.
const uint8_t byte3 = data[((vsr + 1) & 0x0007ffff) ^ 1];
const uint8_t u8 = u + m_delta_uv_lut[byte2];
const uint8_t v8 = v + m_delta_uv_lut[byte3];
const uint8_t u6 = (u >> 1) + (u8 >> 1) + (u & u8 & 1);
const uint8_t v6 = (v >> 1) + (v8 >> 1) + (v & v8 & 1);
color1 = (limit_rgb2[m_dyuv_v_to_r[v6]] << 16) | (limit_rgb2[m_dyuv_u_to_g[u6] + m_dyuv_v_to_g[v6]] << 8) | limit_rgb2[m_dyuv_u_to_b[u6]];
y = y4;
u = u4;
v = v4;
// TODO: Does not support QHY
pixels[x] = color0;
pixels[x + 1] = color0;