srcclean and cleanup

This commit is contained in:
Vas Crabb 2024-12-22 05:34:00 +11:00
parent 3336772d68
commit 780490d9ac
29 changed files with 93 additions and 93 deletions

View File

@ -3019,7 +3019,7 @@ Crashes after EA logo, requires better [VDP] irq handling
<!-- Another, 1.12, version is known to have existed between this and the final version
See: https://www.youtube.com/watch?v=_1uGkfw5ky8 -->
See: https://www.youtube.com/watch?v=_1uGkfw5ky8 -->
<software name="felixjrv10" cloneof="felixjr">
<description>Fix-it Felix Jr. (v1.0)</description>
<year>2013</year>

View File

@ -606,7 +606,7 @@ void upd777_cpu_device::do_op()
src1 = src1 + src2;
// not in this case?
//if (src1 & 0x80)
// m_skip = 1;
// m_skip = 1;
break;
}
case 2: // OR

View File

@ -1190,7 +1190,7 @@ uint8_t cirrus_gd5428_vga_device::mem_r(offs_t offset)
// FIXME: workaround crash behaviour in picasso2
// it will otherwise provide an offset of 0x1fxxxx in the gc_locked below
// causing a crash during adapter init
// causing a crash during adapter init
if(svga.rgb8_en || svga.rgb15_en || svga.rgb16_en || svga.rgb24_en)
{
return svga_device::mem_linear_r((offset & 0xffff) + bank * 0x10000);

View File

@ -9,11 +9,11 @@ license:CC0-1.0
<element name="button">
<rect>
<color red="0.25" green="0.25" blue="0.25" />
<color red="0.25" green="0.25" blue="0.25" />
</rect>
</element>
<element name="red_led" defstate="0">
<element name="red_led" defstate="0">
<disk state="0">
<color red="0.20" green="0.0" blue="0.0" />
</disk>
@ -22,7 +22,7 @@ license:CC0-1.0
</disk>
</element>
<element name="green_led" defstate="0">
<element name="green_led" defstate="0">
<disk state="0">
<color red="0.0" green="0.20" blue="0.0" />
</disk>
@ -38,38 +38,38 @@ license:CC0-1.0
</element>
<element name="time_led" defstate="0">
<text state="0" string="TID">
<text state="0" string="TID">
<color red="0.0" green="0.20" blue="0.0" />
</text>
<text state="1" string="TID">
<text state="1" string="TID">
<color red="0.0" green="0.75" blue="0.0" />
</text>
</element>
<element name="date_led" defstate="0">
<text state="0" string="DAT">
<text state="0" string="DAT">
<color red="0.0" green="0.20" blue="0.0" />
</text>
<text state="1" string="DAT">
<text state="1" string="DAT">
<color red="0.0" green="0.75" blue="0.0" />
</text>
</element>
<element name="year_led" defstate="0">
<text state="0" string="ÅR">
<text state="0" string="ÅR">
<color red="0.0" green="0.20" blue="0.0" />
</text>
<text state="1" string="ÅR">
<text state="1" string="ÅR">
<color red="0.0" green="0.75" blue="0.0" />
</text>
</element>
<view name="Front panel">
<bounds x="0" y="0" width="810" height="473" />
<bounds x="0" y="0" width="810" height="473" />
<element ref="panel">
<bounds x="0" y="0" width="810" height="473" />
</element>
<element ref="panel">
<bounds x="0" y="0" width="810" height="473" />
</element>
<!-- BATTERI DRIFT -->
<element name="bat_led" ref="red_led">
@ -151,17 +151,17 @@ license:CC0-1.0
<!-- SKRIV -->
<element ref="button" inputtag="BTN" inputmask="0x01">
<bounds x="275" y="262" width="54" height="54" />
<bounds x="275" y="262" width="54" height="54" />
</element>
<!-- ALLA -->
<element ref="button" inputtag="BTN" inputmask="0x02">
<bounds x="556" y="261" width="54" height="54" />
<bounds x="556" y="261" width="54" height="54" />
</element>
<!-- KLOCK -->
<element ref="button" inputtag="BTN" inputmask="0x04">
<bounds x="648" y="263" width="54" height="54" />
<bounds x="648" y="263" width="54" height="54" />
</element>
</view>
</mamelayout>

View File

@ -1467,12 +1467,12 @@ void lua_engine::initialize()
{
switch (m.phase())
{
case machine_phase::PREINIT: return "preinit";
case machine_phase::INIT: return "init";
case machine_phase::RESET: return "reset";
case machine_phase::RUNNING: return "running";
case machine_phase::EXIT: return "exit";
default: return "";
case machine_phase::PREINIT: return "preinit";
case machine_phase::INIT: return "init";
case machine_phase::RESET: return "reset";
case machine_phase::RUNNING: return "running";
case machine_phase::EXIT: return "exit";
default: return "";
}
});

View File

@ -550,7 +550,7 @@ void amiga_state::render_scanline(bitmap_rgb32 &bitmap, int scanline)
for (int x = 0; x < (amiga_state::SCREEN_WIDTH / 2) + 10; x++)
{
int sprpix;
const bool out_of_beam = x >= amiga_state::SCREEN_WIDTH / 2;
const bool out_of_beam = x >= amiga_state::SCREEN_WIDTH / 2;
/* time to execute the copper? */
if (x == next_copper_x)
@ -602,10 +602,10 @@ void amiga_state::render_scanline(bitmap_rgb32 &bitmap, int scanline)
/* clear the target pixels to the background color as a starting point */
if (dst != nullptr && !out_of_beam)
{
{
dst[x*2+0] =
dst[x*2+1] = m_palette->pen(CUSTOM_REG(REG_COLOR00));
}
}
/* if we hit the first fetch pixel, reset the counters and latch the delays */
if (x == ddf_start_pixel)

View File

@ -549,7 +549,7 @@ void amiga_state::aga_render_scanline(bitmap_rgb32 &bitmap, int scanline)
for (int x = 0; x < (amiga_state::SCREEN_WIDTH / 2) + offset_hack[bitplane_fmode]; x++)
{
int sprpix;
const bool out_of_beam = x >= amiga_state::SCREEN_WIDTH / 2;
const bool out_of_beam = x >= amiga_state::SCREEN_WIDTH / 2;
/* time to execute the copper? */
if (x == next_copper_x)

View File

@ -207,7 +207,7 @@ static INPUT_PORTS_START(monitor_config)
PORT_CONFSETTING(0x02, u8"Mac RGB Display (12\" 512\u00d7384)") // "Rubik" (modified IIgs AppleColor RGB)
PORT_CONFSETTING(0x03, u8"Mac Two-Page Display (B&W 21\" 1152\u00d7870)") // "2 Page"
PORT_CONFSETTING(0x06, u8"Mac Hi-Res Display (12-14\" 640\u00d7480)") // "High Res"
PORT_CONFSETTING(0x07, u8"No monitor, disable internal video") // No monitor connected
PORT_CONFSETTING(0x07, u8"No monitor, disable internal video") // No monitor connected
PORT_CONFSETTING(ext(0, 0, 0), "PAL Encoder (640\u00d7480, 768\u00d7576)")
PORT_CONFSETTING(ext(1, 1, 0), "NTSC Encoder (512\u00d7384, 640\u00d7480)")
PORT_CONFSETTING(ext(1, 1, 3), "640x480 VGA")
@ -225,7 +225,7 @@ static INPUT_PORTS_START(monitor_config_noconv)
PORT_CONFSETTING(0x02, u8"Mac RGB Display (12\" 512\u00d7384)") // "Rubik" (modified IIgs AppleColor RGB)
PORT_CONFSETTING(0x03, u8"Mac Two-Page Display (B&W 21\" 1152\u00d7870)") // "2 Page"
PORT_CONFSETTING(0x06, u8"Mac Hi-Res Display (12-14\" 640\u00d7480)") // "High Res"
PORT_CONFSETTING(0x07, u8"No monitor, disable internal video") // No monitor connected
PORT_CONFSETTING(0x07, u8"No monitor, disable internal video") // No monitor connected
PORT_CONFSETTING(ext(1, 1, 3), "640x480 VGA")
PORT_CONFSETTING(ext(2, 3, 1), "832x624 16\" RGB") // "Goldfish" or "16 inch RGB"
PORT_CONFSETTING(ext(3, 2, 2), "1024\u00d7768 19\" RGB");

View File

@ -1205,7 +1205,7 @@ static INPUT_PORTS_START( ghostb )
PORT_START("DSW0")
PORT_BIT( 0x01, IP_ACTIVE_LOW, IPT_START1 ) // Tested on real hardware
PORT_BIT( 0x02, IP_ACTIVE_LOW, IPT_START2 )
// 1-2 should be coinage.
// 1-2 should be coinage.
// PORT_DIPNAME( 0x03, 0x03, DEF_STR( Coin_A ) ) PORT_DIPLOCATION("SW1:1,2")
// PORT_DIPSETTING( 0x00, DEF_STR( 2C_1C ) )
// PORT_DIPSETTING( 0x03, DEF_STR( 1C_1C ) )
@ -1752,7 +1752,7 @@ static const gfx_layout sr_sprites =
{ 16*8, 1+(16*8), 2+(16*8), 3+(16*8), 4+(16*8), 5+(16*8), 6+(16*8), 7+(16*8),
0,1,2,3,4,5,6,7 },
{ 0*8, 1*8, 2*8, 3*8, 4*8, 5*8, 6*8, 7*8 ,8*8,9*8,10*8,11*8,12*8,13*8,14*8,15*8 },
// { 0*8, 2*8, 1*8, 3*8, 4*8, 6*8, 5*8, 7*8 ,8*8,10*8,9*8,11*8,12*8,14*8,13*8,15*8 }, bootleg decode
// { 0*8, 2*8, 1*8, 3*8, 4*8, 6*8, 5*8, 7*8 ,8*8,10*8,9*8,11*8,12*8,14*8,13*8,15*8 }, bootleg decode
16*16
};

View File

@ -57,11 +57,11 @@ void kchamp_state::draw_sprites(bitmap_ind16 &bitmap, const rectangle &cliprect,
{
/* sprite format:
Offset Encoding
0 YYYYYYYY
1 TTTTTTTT - tile#
2 FGGTCCCC - y flip, gfx bank, high bit of tile#, color
3 XXXXXXXX
Offset Encoding
0 YYYYYYYY
1 TTTTTTTT - tile#
2 FGGTCCCC - y flip, gfx bank, high bit of tile#, color
3 XXXXXXXX
*/
int attr = m_spriteram[offs + 2];

View File

@ -3628,7 +3628,7 @@ static INPUT_PORTS_START( mjreach )
PORT_DIPNAME( 0x20, 0x00, "Last Chance" ) PORT_DIPLOCATION("DIP-SW3:6") // ラストチャンス
PORT_DIPSETTING( 0x20, DEF_STR(Off) ) // 無
PORT_DIPSETTING( 0x00, DEF_STR(On) ) // 有
PORT_DIPNAME( 0xc0, 0x00, "Last Chance Tsumo Count" ) PORT_DIPLOCATION("DIP-SW3:7,8") // ラストチャンスのツモ回数
PORT_DIPNAME( 0xc0, 0x00, "Last Chance Count" ) PORT_DIPLOCATION("DIP-SW3:7,8") // ラストチャンスのツモ回数
PORT_DIPSETTING( 0xc0, "1" )
PORT_DIPSETTING( 0x80, "3" )
PORT_DIPSETTING( 0x00, "5" )
@ -3653,7 +3653,7 @@ static INPUT_PORTS_START( mjreach )
PORT_DIPNAME( 0x20, 0x00, "In-Game Messages" ) PORT_DIPLOCATION("DIP-SW4:6") // ゲーム中のメッセージ
PORT_DIPSETTING( 0x20, DEF_STR(Off) ) // 無
PORT_DIPSETTING( 0x00, DEF_STR(On) ) // 有 (shows when kan/pon/chi/ron is possible)
PORT_DIPNAME( 0x40, 0x00, DEF_STR(Unused) ) PORT_DIPLOCATION("DIP-SW4:7") // ON固定
PORT_DIPNAME( 0x40, 0x00, DEF_STR(Unknown) ) PORT_DIPLOCATION("DIP-SW4:7") // ON固定
PORT_DIPSETTING( 0x40, DEF_STR(Off) )
PORT_DIPSETTING( 0x00, DEF_STR(On) )
PORT_DIPNAME( 0x80, 0x80, "Super Revolver Jackpot Payout Rate" ) PORT_DIPLOCATION("DIP-SW4:8") // スパーレボルバーのJACK-POTの出率
@ -3679,7 +3679,7 @@ static INPUT_PORTS_START( mjreach )
PORT_DIPNAME( 0x40, 0x40, "Renchan Gal Display" ) PORT_DIPLOCATION("DIP-SW4:9") // 連荘ギャルの表示の方式
PORT_DIPSETTING( 0x40, "After Each Win" ) // 勝つごとに表示 (= On according to manual page?)
PORT_DIPSETTING( 0x00, "After 3 Consecutive Wins" ) // 3連荘のみ表示 (= Off according to manual page?)
PORT_DIPNAME( 0x80, 0x80, DEF_STR(Unused) ) PORT_DIPLOCATION("DIP-SW4:10") // OFF固定
PORT_DIPNAME( 0x80, 0x80, DEF_STR(Unknown) ) PORT_DIPLOCATION("DIP-SW4:10") // OFF固定
PORT_DIPSETTING( 0x80, DEF_STR(Off) )
PORT_DIPSETTING( 0x00, DEF_STR(On) )

View File

@ -41,7 +41,7 @@
****************************************************************************
CA00-CA07 blitter (Stargate and Defender do not have blitter)
CA00-CA07 blitter (Stargate and Defender do not have blitter)
CB00 6 bits of the video counters bits 2-7

View File

@ -687,16 +687,16 @@ void cvs_state::sh_trigger_w(offs_t offset, u8 data)
I have recordings available.
- 0x1884 - Enables an XP8038 frequency generator IC
Reflected on pin 10 of a 4016.
The frequency is set by 0x1840, the 8 bit DAC register.
Not all 0x1840 values were tested, but:
0x00 - off, 0x1884 enable has no sound.
0x55,0xAA,0xFF - increasing value has higher frequency
Reflected on pin 10 of a 4016.
The frequency is set by 0x1840, the 8 bit DAC register.
Not all 0x1840 values were tested, but:
0x00 - off, 0x1884 enable has no sound.
0x55,0xAA,0xFF - increasing value has higher frequency
- 0x1885 - A scope showed this halving the XP8038 amplitude with a little decay.
Causes 4016 pin 11 to rise (on) and decay-fall (off)
Causes 4016 pin 11 to rise (on) and decay-fall (off)
- 0x1886 - Outputs a complete Galaxia-style ship fire sound, with attack-to-on and decay-to-off.
- 0x1887 - Reflected on an LM380.
Causes an envelope-like operation on the XP8038 tone with attack (on) and decay (off).
Causes an envelope-like operation on the XP8038 tone with attack (on) and decay (off).
*/
data &= 1;

View File

@ -277,10 +277,10 @@ INPUT_CHANGED_MEMBER(psionmc_state::key_on)
//INPUT_CHANGED_MEMBER(psionmc_state::reset)
//{
// if (newval)
// {
// m_asic2->reset_w(0);
// }
// if (newval)
// {
// m_asic2->reset_w(0);
// }
//}
INPUT_CHANGED_MEMBER(psionmc_state::digitiser_changed)

View File

@ -79,11 +79,11 @@
------------------
For units which allow downloadable songs the only difference in the bootloader ROMs is a couple of bytes
at the end. This may be used as security, to tie the downloads stored in the flash ROM to the units as
the format of the downloaded data in the flash ROMs appears to be different in each case, starting with
different unique bytes after the header information for each unit we've seen. (maybe encryption?)
The bootloader ROM has a unique ID on a sticker in each case too (could be a bytesum, haven't checked)
For units which allow downloadable songs the only difference in the bootloader ROMs is a couple of bytes
at the end. This may be used as security, to tie the downloads stored in the flash ROM to the units as
the format of the downloaded data in the flash ROMs appears to be different in each case, starting with
different unique bytes after the header information for each unit we've seen. (maybe encryption?)
The bootloader ROM has a unique ID on a sticker in each case too (could be a bytesum, haven't checked)
*******************************************************************************/

View File

@ -115,7 +115,7 @@ void dogyuun_state::video_start()
void dogyuun_state::screen_vblank(int state)
{
if (state) // rising edge
if (state) // rising edge
{
m_vdp[0]->screen_eof();
m_vdp[1]->screen_eof();

View File

@ -12,7 +12,7 @@
- verify frequencies on chips
- verify alt titles, some regions have 'Car Fighting' as a subtitle, region comes from EEPROM?
- verify text layer palettes
- service mode doesn't display properly
- service mode doesn't display properly
- currently only coins up with service button
- sound dies after one stage?
*/
@ -282,7 +282,7 @@ void dt7_state::shared_ram_audio_w(offs_t offset, u8 data)
// just a helper function to try and debug the sound CPU a bit more easily
//int pc = m_audiocpu->pc();
//if (offset == 0xf004 / 2)
// logerror("%08x: shared_ram_audio_w address %08x data %02x\n", pc, offset, data);
// logerror("%08x: shared_ram_audio_w address %08x data %02x\n", pc, offset, data);
shared_ram_w(offset, data);
}

View File

@ -77,7 +77,7 @@ u32 enmadaio_state::screen_update(screen_device &screen, bitmap_ind16 &bitmap, c
void enmadaio_state::screen_vblank(int state)
{
if (state) // rising edge
if (state) // rising edge
{
m_vdp->screen_eof();
}

View File

@ -26,7 +26,7 @@ pipibibsp TP-025 Toaplan Pipi & Bibis / Whoopee!! (Prototype)
pipibibsbl bootleg Toaplan Pipi & Bibis / Whoopee!! (based of the prototype)
TODO:
- move bootlegs to oneshot.cpp driver
- move bootlegs to oneshot.cpp driver
*/
namespace {

View File

@ -508,7 +508,7 @@ static INPUT_PORTS_START( quasar )
PORT_DIPSETTING( 0x00, DEF_STR( On ) )
PORT_DIPNAME( 0x30, 0x20, "Sound Program" ) PORT_DIPLOCATION("SOUND:3,4")
PORT_DIPSETTING( 0x00, "Invalid 1" )
PORT_DIPSETTING( 0x10, "Invalid 1" )
PORT_DIPSETTING( 0x10, "Invalid 1" )
PORT_DIPSETTING( 0x30, "Invalid 2" )
PORT_DIPSETTING( 0x20, "Quasar" )
INPUT_PORTS_END