Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-19 07:00:31 +03:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

rx78: Fixed color in theprowr and seki. Added notes.

Browse Source
This commit is contained in:
Robbbert 2021-01-21 19:49:49 +11:00
parent 2525717851
commit 7b5d6819e0
2 changed files with 37 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hash/rx78_cart.xml
View File

@ -121,11 +121,11 @@ The monitor will expect you to load a program from cassette.
</part>
</software>
<software name="cracer">
<software name="cracer" supported="partial"><!-- various bugs -->
<description>Champion Racer</description>
<year>1983</year>
<publisher>Bandai</publisher>
<info name="usage" value="Space to start; Ctrl to accelerate; Left-Right to move" />
<info name="usage" value="PgUp = 1 or \ = 2. Space to start; Ctrl to accelerate; Left-Right to move" />
<part name="cart" interface="rx78_cart">
<dataarea name="rom" size="16384">
<rom name="championracer.bin" size="16384" crc="f32aa1ac" sha1="cfd4454f013af20d4c139af7d965d45a253f695b" />
@ -137,7 +137,7 @@ The monitor will expect you to load a program from cassette.
<description>Mobile Suit Gundam</description>
<year>1983</year>
<publisher>Bandai</publisher>
<info name="usage" value="Alt to Start and Fire; Left-Right to move" />
<info name="usage" value="Use either Z,X,Space; or Left,Right,Alt" />
<part name="cart" interface="rx78_cart">
<dataarea name="rom" size="16384">
<rom name="gundam.bin" size="16384" crc="4f90b7c7" sha1="c836f02876533dbd92fbef1b2237d47bd914ab50" />

52
src/mame/drivers/rx78.cpp
View File

@ -8,9 +8,13 @@ Driver by Angelo Salese & Robbbert.
TODO:
- implement printer;
- Colours are incorrect? Not really sure until we can get more carts
- Implement 2nd cart slot
- Keyboard works in all scenarios, but it is a guess.
- Colours are incorrect. Need more carts to help construct a proper solution.
-- m_pal_reg and m_pri_mask can have unemulated bits used by games, what are these bits for?
-- the colours are verified correct for all games in the software lists, except:
-- chlgolf - it's almost correct, just a few minor things in the background. Perfectly playable.
-- cracer - this game has a lot of issues, including incorrect behaviour. It's still playable though.
Notes:
- BS-BASIC v1.0 notes:
@ -23,7 +27,7 @@ Notes:
btanb. After that, scrolling works correctly.
-- Need a real machine to confirm these problems, but if true, one can only wonder how such
obvious issues made it out the door.
- To stop a cmt load, press STOP + SHIFT keys
- To stop a cmt load, press STOP + SHIFT keys (this combination is the BREAK key).
For a list of all known software and devices for the system, please see hash/rx78.xml.
@ -130,7 +134,7 @@ u8 rx78_state::cass_r()
uint32_t rx78_state::screen_update(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect)
{
u8 color;
u8 color[2];
bool pen[3];
const u8 borderx = 32, bordery = 20;
@ -139,7 +143,7 @@ uint32_t rx78_state::screen_update(screen_device &screen, bitmap_ind16 &bitmap,
u16 count = 0x2c0; //first 0x2bf bytes aren't used for bitmap drawing apparently
u8 pri_mask = m_pri_mask;
if (m_pal_reg[6])
if (BIT(m_pri_mask, 7))
pri_mask &= m_pal_reg[6]; // this gives blue sky in Challenge Golf - colours to be checked on carts as they are dumped
for(u8 y=0; y<184; y++)
@ -153,18 +157,19 @@ uint32_t rx78_state::screen_update(screen_device &screen, bitmap_ind16 &bitmap,
pen[1] = BIT(m_pri_mask, 4) ? BIT(m_vram[count + 0x8000], i) : 0;
pen[2] = BIT(m_pri_mask, 5) ? BIT(m_vram[count + 0xa000], i) : 0;
color = pen[0] | (pen[1] << 1) | (pen[2] << 2);
if (color)
bitmap.pix(y+bordery, x+i+borderx) = color | 8;
color[1] = pen[0] | (pen[1] << 1) | (pen[2] << 2);
/* fg color */
pen[0] = BIT(pri_mask, 0) ? BIT(m_vram[count + 0x0000], i) : 0;
pen[1] = BIT(pri_mask, 1) ? BIT(m_vram[count + 0x2000], i) : 0;
pen[2] = BIT(pri_mask, 2) ? BIT(m_vram[count + 0x4000], i) : 0;
color = pen[0] | (pen[1] << 1) | (pen[2] << 2);
if (color)
bitmap.pix(y+bordery, x+i+borderx) = color;
color[0] = pen[0] | (pen[1] << 1) | (pen[2] << 2);
if (color[1])
bitmap.pix(y+bordery, x+i+borderx) = color[1] | 8;
if (color[0])
bitmap.pix(y+bordery, x+i+borderx) = color[0];
}
count++;
}
@ -225,18 +230,29 @@ void rx78_state::vdp_reg_w(offs_t offset, u8 data)
{
m_pal_reg[offset] = data;
for(u8 i = 0; i < 16; i++)
if (offset < 6)
{
u8 res = (BIT(i, 0) ? m_pal_reg[0 + (BIT(i, 3) ? 3 : 0)] : 0)
|(BIT(i, 1) ? m_pal_reg[1 + (BIT(i, 3) ? 3 : 0)] : 0)
|(BIT(i, 2) ? m_pal_reg[2 + (BIT(i, 3) ? 3 : 0)] : 0);
for(u8 i = 0; i < 16; i++)
{
data = (BIT(i, 0) ? m_pal_reg[0 + (BIT(i, 3) ? 3 : 0)] : 0)
|(BIT(i, 1) ? m_pal_reg[1 + (BIT(i, 3) ? 3 : 0)] : 0)
|(BIT(i, 2) ? m_pal_reg[2 + (BIT(i, 3) ? 3 : 0)] : 0);
u8 r = (res & 0x11) == 0x11 ? 0xff : ((res & 0x11) == 0x01 ? 0x7f : 0);
u8 g = (res & 0x22) == 0x22 ? 0xff : ((res & 0x22) == 0x02 ? 0x7f : 0);
u8 b = (res & 0x44) == 0x44 ? 0xff : ((res & 0x44) == 0x04 ? 0x7f : 0);
u8 r = (data & 0x11) == 0x11 ? 0xff : ((data & 0x11) == 0x01 ? 0x7f : 0);
u8 g = (data & 0x22) == 0x22 ? 0xff : ((data & 0x22) == 0x02 ? 0x7f : 0);
u8 b = (data & 0x44) == 0x44 ? 0xff : ((data & 0x44) == 0x04 ? 0x7f : 0);
m_palette->set_pen_color(i, rgb_t(r,g,b));
m_palette->set_pen_color(i, rgb_t(r,g,b));
}
}
if (m_pal_reg[6] == 3) // seki
for (u8 i = 5; i <8; i++)
m_palette->set_pen_color(i, m_palette->pen_color(i-4));
else
if (m_pal_reg[6] == 15) // theprowr
for (u8 i = 11; i <16; i+=2)
m_palette->set_pen_color(i, m_palette->pen_color(9));
}
void rx78_state::vdp_bg_reg_w(u8 data)