Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-11 23:25:26 +03:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Fixed scrolling issues in Tryout, removed the GAME_IMPERFECT_GRAPHICS flag. [Angelo Salese]

Browse Source
This commit is contained in:
Angelo Salese 2009-05-24 21:14:18 +00:00
parent 98d5f69f46
commit 7bccda6530
2 changed files with 11 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mame/drivers/tryout.c
View File

@ -6,7 +6,6 @@
Driver by Pierpaolo Prazzoli and Bryan McPhail Driver by Pierpaolo Prazzoli and Bryan McPhail
TODO: TODO:
- Fix the scroll properly
- Fix sprite position in cocktail mode - Fix sprite position in cocktail mode
================================================================= =================================================================
@ -255,4 +254,4 @@ ROM_START( tryout )
ROM_LOAD( "ch14.bpr", 0x00000, 0x0020, CRC(8ce19925) SHA1(12f8f6022f1148b6ba1d019a34247452637063a7) ) ROM_LOAD( "ch14.bpr", 0x00000, 0x0020, CRC(8ce19925) SHA1(12f8f6022f1148b6ba1d019a34247452637063a7) )
ROM_END ROM_END
GAME( 1985, tryout, 0, tryout, tryout, 0, ROT90, "Data East Corporation", "Pro Baseball Skill Tryout (Japan)", GAME_IMPERFECT_GRAPHICS ) GAME( 1985, tryout, 0, tryout, tryout, 0, ROT90, "Data East Corporation", "Pro Baseball Skill Tryout (Japan)", GAME_NO_COCKTAIL )

31
src/mame/video/tryout.c
View File

@ -89,13 +89,6 @@ WRITE8_HANDLER( tryout_vram_w )
if ((bank==0 || bank==2 || bank==4 || bank==6) && (offset&0x7ff)<0x400) { if ((bank==0 || bank==2 || bank==4 || bank==6) && (offset&0x7ff)<0x400) {
int newoff=offset&0x3ff; int newoff=offset&0x3ff;
switch (newoff&0x300){
case 0x000: newoff=(newoff&0xff) | 0x100; break;
case 0x100: newoff=(newoff&0xff) | 0x200; break;
case 0x200: newoff=(newoff&0xff) | 0x000; break;
case 0x300: newoff=(newoff&0xff) | 0x300; break;
}
tryout_vram[newoff]=data; tryout_vram[newoff]=data;
tilemap_mark_tile_dirty(bg_tilemap,newoff); tilemap_mark_tile_dirty(bg_tilemap,newoff);
return; return;
@ -236,15 +229,21 @@ static void draw_sprites(running_machine *machine, bitmap_t *bitmap,const rectan
VIDEO_UPDATE( tryout ) VIDEO_UPDATE( tryout )
{ {
// UINT8* mem=memory_region(machine, REGION_CPU1); int scrollx = 0;
int scrollx;
if (!flip_screen_get(screen->machine)) if (!flip_screen_get(screen->machine))
tilemap_set_scrollx(fg_tilemap, 0, 16); /* Assumed hard-wired */ tilemap_set_scrollx(fg_tilemap, 0, 16); /* Assumed hard-wired */
else else
tilemap_set_scrollx(fg_tilemap, 0, -8); /* Assumed hard-wired */ tilemap_set_scrollx(fg_tilemap, 0, -8); /* Assumed hard-wired */
scrollx = tryout_gfx_control[1] + ((tryout_gfx_control[0]&1)<<8) + ((tryout_gfx_control[0]&4)<<7) - ((tryout_gfx_control[0] & 2) ? 0 : 0x100);
/* wrap-around */
if(tryout_gfx_control[1] == 0) { scrollx+=0x100; }
tilemap_set_scrollx(bg_tilemap, 0, scrollx+2); /* why +2? hard-wired? */
tilemap_set_scrolly(bg_tilemap, 0, -tryout_gfx_control[2]);
if(!(tryout_gfx_control[0] & 0x8)) // screen disable if(!(tryout_gfx_control[0] & 0x8)) // screen disable
{ {
/* TODO: Color might be different, needs a video from an original pcb. */ /* TODO: Color might be different, needs a video from an original pcb. */
@ -252,21 +251,11 @@ VIDEO_UPDATE( tryout )
} }
else else
{ {
if(tryout_gfx_control[0] == 0xc)
scrollx = tryout_gfx_control[1];
if(tryout_gfx_control[0] == 0x8 && !tryout_gfx_control[1])
scrollx = 0x100;
else
scrollx = tryout_gfx_control[1] | ((tryout_gfx_control[0]&1)<<8) | ((tryout_gfx_control[0]&4)<<7);
tilemap_set_scrollx(bg_tilemap, 0, scrollx);
tilemap_set_scrolly(bg_tilemap, 0, -tryout_gfx_control[2]);
tilemap_draw(bitmap,cliprect,bg_tilemap,0,0); tilemap_draw(bitmap,cliprect,bg_tilemap,0,0);
tilemap_draw(bitmap,cliprect,fg_tilemap,0,0); tilemap_draw(bitmap,cliprect,fg_tilemap,0,0);
draw_sprites(screen->machine, bitmap,cliprect); draw_sprites(screen->machine, bitmap,cliprect);
} }
// popmessage("%02x %02x %02x - %04x",mem[0xe402],mem[0xe403],mem[0xe404], ((tryout_gfx_control[0]&1)<<8) | ((tryout_gfx_control[0]&4)<<7)); popmessage("%02x %02x %02x %02x",tryout_gfx_control[0],tryout_gfx_control[1],tryout_gfx_control[2],scrollx);
return 0; return 0;
} }