From 7c6fdaf499f910a01210443326fb9e11e9fed928 Mon Sep 17 00:00:00 2001 From: couriersud Date: Wed, 30 Oct 2019 20:42:49 +0100 Subject: [PATCH] netlist solvers: fix some bad design. (nw) --- src/lib/netlist/solver/nld_matrix_solver.cpp | 6 +- src/lib/netlist/solver/nld_matrix_solver.h | 14 +- src/lib/netlist/solver/nld_ms_direct.h | 42 +++-- src/lib/netlist/solver/nld_ms_direct1.h | 6 +- src/lib/netlist/solver/nld_ms_direct2.h | 8 +- src/lib/netlist/solver/nld_ms_gcr.h | 153 +++++++++---------- src/lib/netlist/solver/nld_ms_gmres.h | 86 +++++------ src/lib/netlist/solver/nld_ms_sm.h | 30 ++-- src/lib/netlist/solver/nld_ms_sor.h | 14 +- src/lib/netlist/solver/nld_ms_sor_mat.h | 14 +- src/lib/netlist/solver/nld_ms_w.h | 34 ++--- src/lib/netlist/solver/nld_solver.cpp | 69 ++++----- src/lib/netlist/solver/nld_solver.h | 3 +- 13 files changed, 215 insertions(+), 264 deletions(-) diff --git a/src/lib/netlist/solver/nld_matrix_solver.cpp b/src/lib/netlist/solver/nld_matrix_solver.cpp index d76c2d2f5a3..b762749dc65 100644 --- a/src/lib/netlist/solver/nld_matrix_solver.cpp +++ b/src/lib/netlist/solver/nld_matrix_solver.cpp @@ -42,7 +42,8 @@ namespace devices // ---------------------------------------------------------------------------------------- matrix_solver_t::matrix_solver_t(netlist_state_t &anetlist, const pstring &name, - const solver_parameters_t *params) + const analog_net_t::list_t &nets, + const solver_parameters_t *params) : device_t(anetlist, name) , m_params(*params) , m_stat_calculations(*this, "m_stat_calculations", 0) @@ -56,9 +57,10 @@ namespace devices , m_ops(0) { connect_post_start(m_fb_sync, m_Q_sync); + setup_base(nets); } - void matrix_solver_t::setup_base(analog_net_t::list_t &nets) + void matrix_solver_t::setup_base(const analog_net_t::list_t &nets) { log().debug("New solver setup\n"); diff --git a/src/lib/netlist/solver/nld_matrix_solver.h b/src/lib/netlist/solver/nld_matrix_solver.h index 7870be34ad7..cd04d43bdbd 100644 --- a/src/lib/netlist/solver/nld_matrix_solver.h +++ b/src/lib/netlist/solver/nld_matrix_solver.h @@ -162,11 +162,6 @@ namespace devices public: using list_t = std::vector; - void setup(analog_net_t::list_t &nets) - { - vsetup(nets); - } - void solve_base(); /* after every call to solve, update inputs must be called. @@ -206,14 +201,13 @@ namespace devices protected: matrix_solver_t(netlist_state_t &anetlist, const pstring &name, + const analog_net_t::list_t &nets, const solver_parameters_t *params); void sort_terms(matrix_sort_type_e sort); - void setup_base(analog_net_t::list_t &nets); void update_dynamic(); - virtual void vsetup(analog_net_t::list_t &nets) = 0; virtual unsigned vsolve_non_dynamic(const bool newton_raphson) = 0; netlist_time compute_next_timestep(const double cur_ts); @@ -391,9 +385,6 @@ namespace devices state_var m_iterative_fail; state_var m_iterative_total; - - - private: state_var m_last_step; @@ -403,6 +394,9 @@ namespace devices logic_input_t m_fb_sync; logic_output_t m_Q_sync; + /* base setup - called from constructor */ + void setup_base(const analog_net_t::list_t &nets); + /* calculate matrix */ void setup_matrix(); diff --git a/src/lib/netlist/solver/nld_ms_direct.h b/src/lib/netlist/solver/nld_ms_direct.h index ba38a68235c..fd745d01d22 100644 --- a/src/lib/netlist/solver/nld_ms_direct.h +++ b/src/lib/netlist/solver/nld_ms_direct.h @@ -29,9 +29,10 @@ namespace devices using float_type = FT; - matrix_solver_direct_t(netlist_state_t &anetlist, const pstring &name, const solver_parameters_t *params, const std::size_t size); + matrix_solver_direct_t(netlist_state_t &anetlist, const pstring &name, + const analog_net_t::list_t &nets, + const solver_parameters_t *params, const std::size_t size); - void vsetup(analog_net_t::list_t &nets) override; void reset() override { matrix_solver_t::reset(); } protected: @@ -65,25 +66,6 @@ namespace devices // matrix_solver_direct // ---------------------------------------------------------------------------------------- - template - void matrix_solver_direct_t::vsetup(analog_net_t::list_t &nets) - { - matrix_solver_t::setup_base(nets); - - /* add RHS element */ - for (std::size_t k = 0; k < size(); k++) - { - terms_for_net_t & t = m_terms[k]; - - if (!plib::container::contains(t.m_nzrd, static_cast(size()))) - t.m_nzrd.push_back(static_cast(size())); - } - - // FIXME: This shouldn't be necessary ... - for (std::size_t k = 0; k < size(); k++) - state().save(*this, RHS(k), this->name(), plib::pfmt("RHS.{1}")(k)); - } - template void matrix_solver_direct_t::LE_solve() { @@ -210,13 +192,27 @@ namespace devices template matrix_solver_direct_t::matrix_solver_direct_t(netlist_state_t &anetlist, const pstring &name, - const solver_parameters_t *params, const std::size_t size) - : matrix_solver_t(anetlist, name, params) + const analog_net_t::list_t &nets, + const solver_parameters_t *params, + const std::size_t size) + : matrix_solver_t(anetlist, name, nets, params) , m_new_V(size) , m_dim(size) , m_pitch(m_pitch_ABS ? m_pitch_ABS : (((m_dim + 1) + 7) / 8) * 8) , m_A(size, m_pitch) { + /* add RHS element */ + for (std::size_t k = 0; k < this->size(); k++) + { + terms_for_net_t & t = m_terms[k]; + + if (!plib::container::contains(t.m_nzrd, static_cast(this->size()))) + t.m_nzrd.push_back(static_cast(this->size())); + } + + // FIXME: This shouldn't be necessary ... + for (std::size_t k = 0; k < this->size(); k++) + state().save(*this, RHS(k), this->name(), plib::pfmt("RHS.{1}")(k)); } } // namespace devices diff --git a/src/lib/netlist/solver/nld_ms_direct1.h b/src/lib/netlist/solver/nld_ms_direct1.h index fbbb8ecb098..1fefc9045b7 100644 --- a/src/lib/netlist/solver/nld_ms_direct1.h +++ b/src/lib/netlist/solver/nld_ms_direct1.h @@ -23,8 +23,10 @@ namespace devices using float_type = FT; using base_type = matrix_solver_direct_t; - matrix_solver_direct1_t(netlist_state_t &anetlist, const pstring &name, const solver_parameters_t *params) - : matrix_solver_direct_t(anetlist, name, params, 1) + matrix_solver_direct1_t(netlist_state_t &anetlist, const pstring &name, + const analog_net_t::list_t &nets, + const solver_parameters_t *params) + : matrix_solver_direct_t(anetlist, name, nets, params, 1) {} // ---------------------------------------------------------------------------------------- diff --git a/src/lib/netlist/solver/nld_ms_direct2.h b/src/lib/netlist/solver/nld_ms_direct2.h index 01f77c3bc3c..bca20eb583b 100644 --- a/src/lib/netlist/solver/nld_ms_direct2.h +++ b/src/lib/netlist/solver/nld_ms_direct2.h @@ -27,9 +27,11 @@ namespace devices using float_type = FT; - matrix_solver_direct2_t(netlist_state_t &anetlist, const pstring &name, const solver_parameters_t *params) - : matrix_solver_direct_t(anetlist, name, params, 2) - {} + matrix_solver_direct2_t(netlist_state_t &anetlist, const pstring &name, + const analog_net_t::list_t &nets, + const solver_parameters_t *params) + : matrix_solver_direct_t(anetlist, name, nets, params, 2) + {} unsigned vsolve_non_dynamic(const bool newton_raphson) override { this->build_LE_A(*this); diff --git a/src/lib/netlist/solver/nld_ms_gcr.h b/src/lib/netlist/solver/nld_ms_gcr.h index 7e51f5d7ef5..edb17ad9e73 100644 --- a/src/lib/netlist/solver/nld_ms_gcr.h +++ b/src/lib/netlist/solver/nld_ms_gcr.h @@ -35,19 +35,84 @@ namespace devices static constexpr const std::size_t storage_N = 100; matrix_solver_GCR_t(netlist_state_t &anetlist, const pstring &name, - const solver_parameters_t *params, const std::size_t size) - : matrix_solver_t(anetlist, name, params) - , m_dim(size) - , RHS(size) - , new_V(size) - , mat(static_cast(size)) - , m_proc() + const analog_net_t::list_t &nets, + const solver_parameters_t *params, const std::size_t size) + : matrix_solver_t(anetlist, name, nets, params) + , m_dim(size) + , RHS(size) + , new_V(size) + , mat(static_cast(size)) + , m_proc() + { + const std::size_t iN = this->N(); + + /* build the final matrix */ + + std::vector> fill(iN); + + std::size_t raw_elements = 0; + + for (std::size_t k = 0; k < iN; k++) { + fill[k].resize(iN, decltype(mat)::FILL_INFINITY); + for (auto &j : this->m_terms[k].m_nz) + { + fill[k][j] = 0; + raw_elements++; + } + } + auto gr = mat.gaussian_extend_fill_mat(fill); + + log_fill(fill, mat); + + mat.build_from_fill_mat(fill); + + for (mat_index_type k=0; km_terms[k].railstart();j++) + { + int other = this->m_terms[k].m_connected_net_idx[j]; + for (auto i = mat.row_idx[k]; i < mat.row_idx[k+1]; i++) + if (other == static_cast(mat.col_idx[i])) + { + m_mat_ptr[k][j] = &mat.A[i]; + cnt++; + break; + } + } + nl_assert(cnt == this->m_terms[k].railstart()); + m_mat_ptr[k][this->m_terms[k].railstart()] = &mat.A[mat.diag[k]]; + } + + this->log().verbose("maximum fill: {1}", gr.first); + this->log().verbose("Post elimination occupancy ratio: {2} Ops: {1}", gr.second, + static_cast(mat.nz_num) / static_cast(iN * iN)); + this->log().verbose(" Pre elimination occupancy ratio: {2}", + static_cast(raw_elements) / static_cast(iN * iN)); + + // FIXME: Move me + + if (state().lib().isLoaded()) + { + pstring symname = static_compile_name(); + m_proc.load(this->state().lib(), symname); + if (m_proc.resolved()) + { + this->log().info("External static solver {1} found ...", symname); + } + else + { + this->log().warning("External static solver {1} not found ...", symname); + } + } + } + constexpr std::size_t N() const { return m_dim; } - void vsetup(analog_net_t::list_t &nets) override; unsigned vsolve_non_dynamic(const bool newton_raphson) override; std::pair create_solver_code() override; @@ -74,78 +139,6 @@ namespace devices // matrix_solver - GCR // ---------------------------------------------------------------------------------------- - template - void matrix_solver_GCR_t::vsetup(analog_net_t::list_t &nets) - { - setup_base(nets); - - const std::size_t iN = this->N(); - - /* build the final matrix */ - - std::vector> fill(iN); - - std::size_t raw_elements = 0; - - for (std::size_t k = 0; k < iN; k++) - { - fill[k].resize(iN, decltype(mat)::FILL_INFINITY); - for (auto &j : this->m_terms[k].m_nz) - { - fill[k][j] = 0; - raw_elements++; - } - - } - - auto gr = mat.gaussian_extend_fill_mat(fill); - - log_fill(fill, mat); - - mat.build_from_fill_mat(fill); - - for (mat_index_type k=0; km_terms[k].railstart();j++) - { - int other = this->m_terms[k].m_connected_net_idx[j]; - for (auto i = mat.row_idx[k]; i < mat.row_idx[k+1]; i++) - if (other == static_cast(mat.col_idx[i])) - { - m_mat_ptr[k][j] = &mat.A[i]; - cnt++; - break; - } - } - nl_assert(cnt == this->m_terms[k].railstart()); - m_mat_ptr[k][this->m_terms[k].railstart()] = &mat.A[mat.diag[k]]; - } - - this->log().verbose("maximum fill: {1}", gr.first); - this->log().verbose("Post elimination occupancy ratio: {2} Ops: {1}", gr.second, - static_cast(mat.nz_num) / static_cast(iN * iN)); - this->log().verbose(" Pre elimination occupancy ratio: {2}", - static_cast(raw_elements) / static_cast(iN * iN)); - - // FIXME: Move me - - if (state().lib().isLoaded()) - { - pstring symname = static_compile_name(); - m_proc.load(this->state().lib(), symname); - if (m_proc.resolved()) - { - this->log().info("External static solver {1} found ...", symname); - } - else - { - this->log().warning("External static solver {1} not found ...", symname); - } - } - } - template void matrix_solver_GCR_t::generate_code(plib::putf8_fmt_writer &strm) { diff --git a/src/lib/netlist/solver/nld_ms_gmres.h b/src/lib/netlist/solver/nld_ms_gmres.h index f99368549a9..7a12737297c 100644 --- a/src/lib/netlist/solver/nld_ms_gmres.h +++ b/src/lib/netlist/solver/nld_ms_gmres.h @@ -35,15 +35,51 @@ namespace devices * maximize the efficiency of the incomplete LUT. * This is already preconditioning. */ - matrix_solver_GMRES_t(netlist_state_t &anetlist, const pstring &name, const solver_parameters_t *params, const std::size_t size) - // matrix_solver_direct_t(anetlist, name, matrix_solver_t::PREFER_BAND_MATRIX, params, size) - : matrix_solver_direct_t(anetlist, name, params, size) + matrix_solver_GMRES_t(netlist_state_t &anetlist, const pstring &name, + analog_net_t::list_t &nets, + const solver_parameters_t *params, + const std::size_t size) + : matrix_solver_direct_t(anetlist, name, nets, params, size) , m_ops(size, 0) , m_gmres(size) { + const std::size_t iN = this->size(); + + std::vector> fill(iN); + + for (std::size_t k=0; km_terms[k]; + for (const auto &nz_j : row.m_nz) + { + fill[k][static_cast(nz_j)] = 0; + } } - void vsetup(analog_net_t::list_t &nets) override; + m_ops.build(fill); + this->log_fill(fill, m_ops.m_mat); + + /* build pointers into the compressed row format matrix for each terminal */ + + for (std::size_t k=0; km_terms[k].railstart();j++) + { + for (std::size_t i = m_ops.m_mat.row_idx[k]; im_terms[k].m_connected_net_idx[j] == static_cast(m_ops.m_mat.col_idx[i])) + { + this->m_mat_ptr[k][j] = &m_ops.m_mat.A[i]; + cnt++; + break; + } + } + nl_assert(cnt == this->m_terms[k].railstart()); + this->m_mat_ptr[k][this->m_terms[k].railstart()] = &m_ops.m_mat.A[m_ops.m_mat.diag[k]]; + } + } + unsigned vsolve_non_dynamic(const bool newton_raphson) override; private: @@ -60,48 +96,6 @@ namespace devices // matrix_solver - GMRES // ---------------------------------------------------------------------------------------- - template - void matrix_solver_GMRES_t::vsetup(analog_net_t::list_t &nets) - { - matrix_solver_direct_t::vsetup(nets); - - const std::size_t iN = this->size(); - - std::vector> fill(iN); - - for (std::size_t k=0; km_terms[k]; - for (const auto &nz_j : row.m_nz) - { - fill[k][static_cast(nz_j)] = 0; - } - } - - m_ops.build(fill); - this->log_fill(fill, m_ops.m_mat); - - /* build pointers into the compressed row format matrix for each terminal */ - - for (std::size_t k=0; km_terms[k].railstart();j++) - { - for (std::size_t i = m_ops.m_mat.row_idx[k]; im_terms[k].m_connected_net_idx[j] == static_cast(m_ops.m_mat.col_idx[i])) - { - this->m_mat_ptr[k][j] = &m_ops.m_mat.A[i]; - cnt++; - break; - } - } - nl_assert(cnt == this->m_terms[k].railstart()); - this->m_mat_ptr[k][this->m_terms[k].railstart()] = &m_ops.m_mat.A[m_ops.m_mat.diag[k]]; - } - } - template unsigned matrix_solver_GMRES_t::vsolve_non_dynamic(const bool newton_raphson) { diff --git a/src/lib/netlist/solver/nld_ms_sm.h b/src/lib/netlist/solver/nld_ms_sm.h index bec4e426208..a6bc83e27a6 100644 --- a/src/lib/netlist/solver/nld_ms_sm.h +++ b/src/lib/netlist/solver/nld_ms_sm.h @@ -57,9 +57,17 @@ namespace devices static constexpr const std::size_t storage_N = 100; matrix_solver_sm_t(netlist_state_t &anetlist, const pstring &name, - const solver_parameters_t *params, const std::size_t size); + const analog_net_t::list_t &nets, + const solver_parameters_t *params, const std::size_t size) + : matrix_solver_t(anetlist, name, nets, params) + , m_dim(size) + , m_cnt(0) + { + /* FIXME: Shouldn't be necessary */ + for (std::size_t k = 0; k < this->size(); k++) + state().save(*this, RHS(k), this->name(), plib::pfmt("RHS.{1}")(k)); + } - void vsetup(analog_net_t::list_t &nets) override; void reset() override { matrix_solver_t::reset(); } protected: @@ -112,16 +120,6 @@ namespace devices // matrix_solver_direct // ---------------------------------------------------------------------------------------- - template - void matrix_solver_sm_t::vsetup(analog_net_t::list_t &nets) - { - matrix_solver_t::setup_base(nets); - - /* FIXME: Shouldn't be necessary */ - for (std::size_t k = 0; k < size(); k++) - state().save(*this, RHS(k), this->name(), plib::pfmt("RHS.{1}")(k)); - } - template void matrix_solver_sm_t::LE_invert() { @@ -298,14 +296,6 @@ namespace devices return this->solve_non_dynamic(newton_raphson); } - template - matrix_solver_sm_t::matrix_solver_sm_t(netlist_state_t &anetlist, const pstring &name, - const solver_parameters_t *params, const std::size_t size) - : matrix_solver_t(anetlist, name, params) - , m_dim(size) - , m_cnt(0) - { - } } // namespace devices } // namespace netlist diff --git a/src/lib/netlist/solver/nld_ms_sor.h b/src/lib/netlist/solver/nld_ms_sor.h index dbd8fa229ac..41ab4460ced 100644 --- a/src/lib/netlist/solver/nld_ms_sor.h +++ b/src/lib/netlist/solver/nld_ms_sor.h @@ -29,8 +29,10 @@ public: using float_type = FT; - matrix_solver_SOR_t(netlist_state_t &anetlist, const pstring &name, const solver_parameters_t *params, const std::size_t size) - : matrix_solver_direct_t(anetlist, name, params, size) + matrix_solver_SOR_t(netlist_state_t &anetlist, const pstring &name, + analog_net_t::list_t &nets, + const solver_parameters_t *params, const std::size_t size) + : matrix_solver_direct_t(anetlist, name, nets, params, size) , m_lp_fact(*this, "m_lp_fact", 0) , w(size, 0.0) , one_m_w(size, 0.0) @@ -39,7 +41,6 @@ public: { } - void vsetup(analog_net_t::list_t &nets) override; unsigned vsolve_non_dynamic(const bool newton_raphson) override; private: @@ -54,13 +55,6 @@ private: // matrix_solver - Gauss - Seidel // ---------------------------------------------------------------------------------------- - -template -void matrix_solver_SOR_t::vsetup(analog_net_t::list_t &nets) -{ - matrix_solver_direct_t::vsetup(nets); -} - template unsigned matrix_solver_SOR_t::vsolve_non_dynamic(const bool newton_raphson) { diff --git a/src/lib/netlist/solver/nld_ms_sor_mat.h b/src/lib/netlist/solver/nld_ms_sor_mat.h index 47f6a8e4766..943ae1ad989 100644 --- a/src/lib/netlist/solver/nld_ms_sor_mat.h +++ b/src/lib/netlist/solver/nld_ms_sor_mat.h @@ -32,16 +32,16 @@ namespace devices using float_type = FT; - matrix_solver_SOR_mat_t(netlist_state_t &anetlist, const pstring &name, const solver_parameters_t *params, std::size_t size) - : matrix_solver_direct_t(anetlist, name, params, size) + matrix_solver_SOR_mat_t(netlist_state_t &anetlist, const pstring &name, + const analog_net_t::list_t &nets, + const solver_parameters_t *params, std::size_t size) + : matrix_solver_direct_t(anetlist, name, nets, params, size) , m_Vdelta(*this, "m_Vdelta", std::vector(size)) , m_omega(*this, "m_omega", params->m_gs_sor) , m_lp_fact(*this, "m_lp_fact", 0) { } - void vsetup(analog_net_t::list_t &nets) override; - unsigned vsolve_non_dynamic(const bool newton_raphson) override; private: @@ -57,12 +57,6 @@ namespace devices // matrix_solver - Gauss - Seidel // ---------------------------------------------------------------------------------------- - template - void matrix_solver_SOR_mat_t::vsetup(analog_net_t::list_t &nets) - { - matrix_solver_direct_t::vsetup(nets); - } - #if 0 //FIXME: move to solve_base template diff --git a/src/lib/netlist/solver/nld_ms_w.h b/src/lib/netlist/solver/nld_ms_w.h index d6969d4fd8c..33e15db1a49 100644 --- a/src/lib/netlist/solver/nld_ms_w.h +++ b/src/lib/netlist/solver/nld_ms_w.h @@ -63,9 +63,18 @@ public: // FIXME: dirty hack to make this compile static constexpr const std::size_t storage_N = 100; - matrix_solver_w_t(netlist_state_t &anetlist, const pstring &name, const solver_parameters_t *params, const std::size_t size); + matrix_solver_w_t(netlist_state_t &anetlist, const pstring &name, + const analog_net_t::list_t &nets, + const solver_parameters_t *params, const std::size_t size) + : matrix_solver_t(anetlist, name, nets, params) + , m_cnt(0) + , m_dim(size) + { + // FIXME: This shouldn't be necessary, recalculate on each entry ... + for (std::size_t k = 0; k < this->size(); k++) + state().save(*this, RHS(k), this->name(), plib::pfmt("RHS.{1}")(k)); + } - void vsetup(analog_net_t::list_t &nets) override; void reset() override { matrix_solver_t::reset(); } protected: @@ -125,18 +134,6 @@ private: // matrix_solver_direct // ---------------------------------------------------------------------------------------- -template -void matrix_solver_w_t::vsetup(analog_net_t::list_t &nets) -{ - matrix_solver_t::setup_base(nets); - - // FIXME: This shouldn't be necessary, recalculate on each entry ... - for (std::size_t k = 0; k < size(); k++) - state().save(*this, RHS(k), this->name(), plib::pfmt("RHS.{1}")(k)); -} - - - template void matrix_solver_w_t::LE_invert() { @@ -369,15 +366,6 @@ unsigned matrix_solver_w_t::vsolve_non_dynamic(const bool newton_raphs return this->solve_non_dynamic(newton_raphson); } -template -matrix_solver_w_t::matrix_solver_w_t(netlist_state_t &anetlist, const pstring &name, - const solver_parameters_t *params, const std::size_t size) - : matrix_solver_t(anetlist, name, params) - , m_cnt(0) - , m_dim(size) -{ -} - } //namespace devices } // namespace netlist diff --git a/src/lib/netlist/solver/nld_solver.cpp b/src/lib/netlist/solver/nld_solver.cpp index 360a9fc5dc9..b0dcbec2523 100644 --- a/src/lib/netlist/solver/nld_solver.cpp +++ b/src/lib/netlist/solver/nld_solver.cpp @@ -110,39 +110,43 @@ namespace devices } template - plib::unique_ptr create_it(netlist_state_t &nl, pstring name, solver_parameters_t ¶ms, std::size_t size) + plib::unique_ptr create_it(netlist_state_t &nl, pstring name, + analog_net_t::list_t &nets, + solver_parameters_t ¶ms, std::size_t size) { - return plib::make_unique(nl, name, ¶ms, size); + return plib::make_unique(nl, name, nets, ¶ms, size); } template - plib::unique_ptr NETLIB_NAME(solver)::create_solver(std::size_t size, const pstring &solvername) + plib::unique_ptr NETLIB_NAME(solver)::create_solver(std::size_t size, + const pstring &solvername, + analog_net_t::list_t &nets) { switch (m_params.m_method()) { case matrix_type_e::MAT_CR: if (size > 0) // GCR always outperforms MAT solver { - return create_it>(state(), solvername, m_params, size); + return create_it>(state(), solvername, nets, m_params, size); } else { - return create_it>(state(), solvername, m_params, size); + return create_it>(state(), solvername, nets, m_params, size); } case matrix_type_e::SOR_MAT: - return create_it>(state(), solvername, m_params, size); + return create_it>(state(), solvername, nets, m_params, size); case matrix_type_e::MAT: - return create_it>(state(), solvername, m_params, size); + return create_it>(state(), solvername, nets, m_params, size); case matrix_type_e::SM: /* Sherman-Morrison Formula */ - return create_it>(state(), solvername, m_params, size); + return create_it>(state(), solvername, nets, m_params, size); case matrix_type_e::W: /* Woodbury Formula */ - return create_it>(state(), solvername, m_params, size); + return create_it>(state(), solvername, nets, m_params, size); case matrix_type_e::SOR: - return create_it>(state(), solvername, m_params, size); + return create_it>(state(), solvername, nets, m_params, size); case matrix_type_e::GMRES: - return create_it>(state(), solvername, m_params, size); + return create_it>(state(), solvername, nets, m_params, size); } return plib::unique_ptr(); } @@ -227,35 +231,35 @@ namespace devices switch (net_count) { case 1: - ms = plib::make_unique>(state(), sname, &m_params); + ms = plib::make_unique>(state(), sname, grp, &m_params); break; case 2: - ms = plib::make_unique>(state(), sname, &m_params); + ms = plib::make_unique>(state(), sname, grp, &m_params); break; -#if 1 +#if 0 case 3: - ms = create_solver(3, sname); + ms = create_solver(3, sname, grp); break; case 4: - ms = create_solver(4, sname); + ms = create_solver(4, sname, grp); break; case 5: - ms = create_solver(5, sname); + ms = create_solver(5, sname, grp); break; case 6: - ms = create_solver(6, sname); + ms = create_solver(6, sname, grp); break; case 7: - ms = create_solver(7, sname); + ms = create_solver(7, sname, grp); break; case 8: - ms = create_solver(8, sname); + ms = create_solver(8, sname, grp); break; case 9: - ms = create_solver(9, sname); + ms = create_solver(9, sname, grp); break; case 10: - ms = create_solver(10, sname); + ms = create_solver(10, sname, grp); break; #if 0 case 11: @@ -282,7 +286,7 @@ namespace devices #endif #if 1 case 87: - ms = create_solver(86, sname); + ms = create_solver(86, sname, grp); break; #endif #endif @@ -290,42 +294,39 @@ namespace devices log().info(MI_NO_SPECIFIC_SOLVER(net_count)); if (net_count <= 8) { - ms = create_solver(net_count, sname); + ms = create_solver(net_count, sname, grp); } else if (net_count <= 16) { - ms = create_solver(net_count, sname); + ms = create_solver(net_count, sname, grp); } else if (net_count <= 32) { - ms = create_solver(net_count, sname); + ms = create_solver(net_count, sname, grp); } else if (net_count <= 64) { - ms = create_solver(net_count, sname); + ms = create_solver(net_count, sname, grp); } else if (net_count <= 128) { - ms = create_solver(net_count, sname); + ms = create_solver(net_count, sname, grp); } else if (net_count <= 256) { - ms = create_solver(net_count, sname); + ms = create_solver(net_count, sname, grp); } else if (net_count <= 512) { - ms = create_solver(net_count, sname); + ms = create_solver(net_count, sname, grp); } else { - ms = create_solver(net_count, sname); + ms = create_solver(net_count, sname, grp); } break; } - // FIXME ... - ms->setup(grp); - log().verbose("Solver {1}", ms->name()); log().verbose(" ==> {1} nets", grp.size()); log().verbose(" has {1} elements", ms->has_dynamic_devices() ? "dynamic" : "no dynamic"); diff --git a/src/lib/netlist/solver/nld_solver.h b/src/lib/netlist/solver/nld_solver.h index 7e672d74738..1153b1a6011 100644 --- a/src/lib/netlist/solver/nld_solver.h +++ b/src/lib/netlist/solver/nld_solver.h @@ -58,7 +58,8 @@ namespace devices solver_parameters_t m_params; template - plib::unique_ptr create_solver(std::size_t size, const pstring &solvername); + plib::unique_ptr create_solver(std::size_t size, + const pstring &solvername, analog_net_t::list_t &nets); }; } // namespace devices