Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-22 08:22:15 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

rz1.cpp: Use output finders for LEDs (nw)

Browse Source 
Note that this does not fix the problem reported by Tafoid of the LED values being lost upon reloading a state, which represents a fundamental flaw of the named output system as it is currently constituted.
This commit is contained in:
AJR 2018-10-07 16:36:12 -04:00
parent 64177f7daa
commit 7d6fc6dfe2
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/mame/drivers/rz1.cpp
View File

@ -52,6 +52,9 @@ public:
m_pg{ {*this, "upd934g_c"}, {*this, "upd934g_b"} },
m_samples{ {*this, "samples_a"}, {*this, "samples_b"} },
m_keys(*this, "kc%u", 0),
m_led_song(*this, "led_song"),
m_led_pattern(*this, "led_pattern"),
m_led_startstop(*this, "led_startstop"),
m_port_a(0),
m_port_b(0xff)
{ }
@ -72,6 +75,10 @@ private:
required_memory_region m_samples[2];
required_ioport_array<8> m_keys;
output_finder<> m_led_song;
output_finder<> m_led_pattern;
output_finder<> m_led_startstop;
void map(address_map &map);
DECLARE_READ8_MEMBER(port_a_r);
@ -307,13 +314,18 @@ READ8_MEMBER( rz1_state::key_r )
WRITE8_MEMBER( rz1_state::leds_w )
{
output().set_value("led_song", BIT(data, 0) == 0 ? 1 : BIT(data, 1) == 0 ? 2 : 0);
output().set_value("led_pattern", BIT(data, 2) == 0 ? 1 : BIT(data, 3) == 0 ? 2 : 0);
output().set_value("led_startstop", BIT(data, 4) == 0 ? 1 : 0);
m_led_song = BIT(data, 0) == 0 ? 1 : BIT(data, 1) == 0 ? 2 : 0;
m_led_pattern = BIT(data, 2) == 0 ? 1 : BIT(data, 3) == 0 ? 2 : 0;
m_led_startstop = BIT(data, 4) == 0 ? 1 : 0;
}
void rz1_state::machine_start()
{
// resolve output finders
m_led_song.resolve();
m_led_pattern.resolve();
m_led_startstop.resolve();
// register for save states
save_item(NAME(m_port_a));
save_item(NAME(m_port_b));