Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-23 00:39:36 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

exidy440: fix invalid array access

Browse Source
This commit is contained in:
hap 2022-07-09 18:14:17 +02:00
parent cf4d1487bf
commit 80d59e420a
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mame/exidy/exidy440_a.cpp
View File

@ -554,7 +554,7 @@ int16_t *exidy440_sound_device::find_or_add_to_sound_cache(int address, int leng
if (current.address == address && current.length == length && current.bits == bits && current.frequency == frequency)
return &current.data[0];
return add_to_sound_cache(&m_samples[address], address, length, bits, frequency);
return length ? add_to_sound_cache(&m_samples[address], address, length, bits, frequency) : nullptr;
}
@ -584,8 +584,6 @@ void exidy440_sound_device::play_cvsd(int ch)
/* compute the base address in the converted samples array */
base = find_or_add_to_sound_cache(address, length, channel_bits[ch], m_channel_frequency[ch]);
if (!base)
return;
/* if the length is 0 or 1, just do an immediate end */
if (length <= 3)

1
src/mame/exidy/exidy440_a.h
View File

@ -73,7 +73,6 @@ private:
uint8_t m_sound_command_ack;
uint8_t m_sound_banks[4];
//uint8_t m_m6844_data[0x20];
uint8_t m_sound_volume[0x10];
std::vector<int32_t> m_mixer_buffer_left;
std::vector<int32_t> m_mixer_buffer_right;