gb_slot.cpp: clean up the internal logging a tiny bit (nw)

This commit is contained in:
Wilbert Pol 2016-04-03 15:41:37 +02:00
parent 4d7ee46b05
commit 83ac1bf251

View File

@ -816,24 +816,23 @@ void base_gb_cart_slot_device::internal_header_logging(UINT8 *ROM, UINT32 len)
soft[16] = '\0'; soft[16] = '\0';
logerror("Cart Information\n"); logerror("Cart Information\n");
logerror("\tName: %s\n", soft); logerror("\tName: %s\n", soft);
logerror("\tType: %s [0x%2X]\n", (ROM[0x0147] <= 32) ? cart_types[ROM[0x0147]] : "", ROM[0x0147] ); logerror("\tType: %s [0x%02X]\n", (ROM[0x0147] <= 32) ? cart_types[ROM[0x0147]] : "", ROM[0x0147] );
logerror("\tGame Boy: %s\n", (ROM[0x0143] == 0xc0) ? "No" : "Yes" ); logerror("\tGame Boy: %s\n", (ROM[0x0143] == 0xc0) ? "No" : "Yes" );
logerror("\tSuper GB: %s [0x%2X]\n", (ROM[0x0146] == 0x03) ? "Yes" : "No", ROM[0x0146] ); logerror("\tSuper GB: %s [0x%02X]\n", (ROM[0x0146] == 0x03) ? "Yes" : "No", ROM[0x0146] );
logerror("\tColor GB: %s [0x%2X]\n", (ROM[0x0143] == 0x80 || ROM[0x0143] == 0xc0) ? "Yes" : "No", ROM[0x0143] ); logerror("\tColor GB: %s [0x%02X]\n", (ROM[0x0143] == 0x80 || ROM[0x0143] == 0xc0) ? "Yes" : "No", ROM[0x0143] );
logerror("\tROM Size: %d 16kB Banks [0x%2X]\n", rom_banks, ROM[0x0148]); logerror("\tROM Size: %d 16kB Banks [0x%02X]\n", rom_banks, ROM[0x0148]);
logerror("\tRAM Size: %d kB [0x%2X]\n", ramsize[ROM[0x0149] & 0x07], ROM[0x0149]); logerror("\tRAM Size: %d kB [0x%02X]\n", ramsize[ROM[0x0149] & 0x07], ROM[0x0149]);
logerror("\tLicense code: 0x%2X%2X\n", ROM[0x0145], ROM[0x0144] ); logerror("\tLicense code: 0x%02X%02X\n", ROM[0x0145], ROM[0x0144] );
tmp = (ROM[0x014b] << 8) + ROM[0x014a]; tmp = (ROM[0x014b] << 8) + ROM[0x014a];
for (i = 0; i < ARRAY_LENGTH(companies); i++) for (i = 0; i < ARRAY_LENGTH(companies); i++)
if (tmp == companies[i].code) if (tmp == companies[i].code)
break; break;
logerror("\tManufacturer ID: 0x%2X", tmp); logerror("\tManufacturer ID: 0x%02X [%s]\n", tmp, (i < ARRAY_LENGTH(companies)) ? companies[i].name : "?");
logerror(" [%s]\n", (i < ARRAY_LENGTH(companies)) ? companies[i].name : "?"); logerror("\tVersion Number: 0x%02X\n", ROM[0x014c]);
logerror("\tVersion Number: 0x%2X\n", ROM[0x014c]); logerror("\tComplement Check: 0x%02X\n", ROM[0x014d]);
logerror("\tComplement Check: 0x%2X\n", ROM[0x014d]); logerror("\tChecksum: 0x%04X\n", ((ROM[0x014e] << 8) + ROM[0x014f]));
logerror("\tChecksum: 0x%2X\n", ((ROM[0x014e] << 8) + ROM[0x014f]));
tmp = (ROM[0x0103] << 8) + ROM[0x0102]; tmp = (ROM[0x0103] << 8) + ROM[0x0102];
logerror("\tStart Address: 0x%2X\n", tmp); logerror("\tStart Address: 0x%04X\n", tmp);
// Additional checks // Additional checks
if (rom_banks == 256) if (rom_banks == 256)
@ -850,6 +849,6 @@ void base_gb_cart_slot_device::internal_header_logging(UINT8 *ROM, UINT32 len)
csum &= 0xffff; csum &= 0xffff;
if (csum != tmp) if (csum != tmp)
logerror("\nWarning loading cartridge: Checksum is wrong (Actual %X vs Internal %X)\n", csum, tmp); logerror("\nWarning loading cartridge: Checksum is wrong (Actual 0x%04X vs Internal 0x%04X)\n", csum, tmp);
} }