Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-07-05 18:08:04 +03:00
Code Issues Actions 36 Packages Projects Releases Wiki Activity

tutor: Limit offset values, so that gcc is no longer afraid of buffer overflows in snprintf. (nw)

Browse Source
This commit is contained in:
Michael Zapf 2019-03-08 20:44:21 +01:00
parent e576d6201c
commit 873e217fdb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mame/drivers/tutor.cpp
View File

@ -296,13 +296,13 @@ READ8_MEMBER( tutor_state::key_r )
char port[12]; char port[12];
uint8_t value; uint8_t value;
snprintf(port, ARRAY_LENGTH(port), "LINE%d", offset >> 3); snprintf(port, ARRAY_LENGTH(port), "LINE%d", (offset & 0x007e) >> 3);
value = ioport(port)->read(); value = ioport(port)->read();
/* hack for ports overlapping with joystick */ /* hack for ports overlapping with joystick */
if (offset >= 32 && offset < 48) if (offset >= 32 && offset < 48)
{ {
snprintf(port, ARRAY_LENGTH(port), "LINE%d_alt", offset >> 3); snprintf(port, ARRAY_LENGTH(port), "LINE%d_alt", (offset & 0x007e) >> 3);
value |= ioport(port)->read(); value |= ioport(port)->read();
} }