From 890d8129edd4a4a95bb803aec89666b7b24ee157 Mon Sep 17 00:00:00 2001 From: Vas Crabb Date: Sun, 1 Nov 2020 23:59:17 +1100 Subject: [PATCH] cinemat.cpp: Improved armora artworkr Better alignemnent and transmission colours in particular. --- src/devices/bus/a2bus/a2parprn.h | 3 +- src/devices/bus/a2bus/a2pic.h | 10 +- src/mame/includes/hp9845.h | 8 +- src/mame/layout/armora.lay | 225 +++++++------------------------ src/mame/layout/pce220.lay | 6 +- 5 files changed, 62 insertions(+), 190 deletions(-) diff --git a/src/devices/bus/a2bus/a2parprn.h b/src/devices/bus/a2bus/a2parprn.h index 00fd09bdc93..87a9c808c30 100644 --- a/src/devices/bus/a2bus/a2parprn.h +++ b/src/devices/bus/a2bus/a2parprn.h @@ -20,6 +20,7 @@ *spare, SP1-SP5 brought out to pads for wire mods DIP jumper B1: + no connection NC 1 16 B acknowledge latch clock no connection NC 2 15 D printer ready 1 synchronised ACK Y 3 14 C printer ready 2 @@ -34,7 +35,7 @@ microsecond may be ignored. This limitation is not emulated. The card completely ignores the R/W line. The PROM driver uses - and indexed write to access the C0nX region. This produces a + an indexed write to access the C0nX region. This produces a spurious read, causing data to be latched and triggering a delayed strobe pulse. This is why the delay is important – the write needs to happen on the cycle immediately following the diff --git a/src/devices/bus/a2bus/a2pic.h b/src/devices/bus/a2bus/a2pic.h index a484ee92c4c..027c18611f0 100644 --- a/src/devices/bus/a2bus/a2pic.h +++ b/src/devices/bus/a2bus/a2pic.h @@ -36,11 +36,11 @@ This card has significant flaws: * The strobe pulse begins on the same rising edge of the phase 1 - clock as the data is latched. The parallel load input ito the - strobe time counter (6A) is delayed slightly, but the load - happens on the rising phase 1 clock edge. This could glitch - on a real printer. MAME always sets the data outputs before - starting the strobe pulse. + clock as the data is latched. The parallel load enable input + to the strobe time counter (6A) is delayed slightly, but the + load happens on the rising phase 1 clock edge. This could + glitch on a real printer. MAME always sets the data outputs + before starting the strobe pulse. * Acknowledge is ignored while the strobe output is active. If the printer acknowledges the data before the end of the strobe pulse, the card will miss it and wait forever. diff --git a/src/mame/includes/hp9845.h b/src/mame/includes/hp9845.h index b163a4f0dd9..aa38cd79cf1 100644 --- a/src/mame/includes/hp9845.h +++ b/src/mame/includes/hp9845.h @@ -86,11 +86,11 @@ protected: required_region_ptr m_chargen; // Text mode video I/F - typedef struct { + struct video_buffer_t { uint8_t chars[ 80 ]; uint8_t attrs[ 80 ]; bool full = 0; - } video_buffer_t; + }; bitmap_rgb32 m_bitmap; offs_t m_video_mar; @@ -103,7 +103,7 @@ protected: video_buffer_t m_video_buff[ 2 ]; // Graphic video - typedef enum { + enum gv_fsm_state_t { GV_STAT_RESET, GV_STAT_WAIT_DS_0 = GV_STAT_RESET, GV_STAT_WAIT_TRIG_0, @@ -113,7 +113,7 @@ protected: GV_STAT_WAIT_TRIG_1, GV_STAT_WAIT_MEM_1, GV_STAT_WAIT_MEM_2 - } gv_fsm_state_t; + }; bool m_graphic_sel; gv_fsm_state_t m_gv_fsm_state; diff --git a/src/mame/layout/armora.lay b/src/mame/layout/armora.lay index a91e2f04775..e8782ea6622 100644 --- a/src/mame/layout/armora.lay +++ b/src/mame/layout/armora.lay @@ -3,191 +3,62 @@ license:CC0 --> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + ]]> + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + ]]> - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + diff --git a/src/mame/layout/pce220.lay b/src/mame/layout/pce220.lay index 8bc6b432f0c..f8154183b22 100644 --- a/src/mame/layout/pce220.lay +++ b/src/mame/layout/pce220.lay @@ -28,12 +28,12 @@ - + - + @@ -188,7 +188,7 @@ - +