Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-21 11:46:49 +03:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

This should fix a regression incurred from the rom_entry changes identified by MASH

Browse Source 
On pull request #1200, MASH identfied a regression caused by recent changes to rom_entry handling.  That said, I disagreed with his proposed fix because the code did a backwards scan for ROMENTRY_ISEND.  I don't think this is correct; ROMENTRY_ISEND should only work for forward scans, and it probably worked by accident simply because rom_entry structures were likely allocated back to back.

As far as I can tell, my proposed change seems to work but I'm somewhat fuzzy on the interactions between BIOS ROMs and devices, and it is possible that I'm neglecting a use case.
This commit is contained in:
Nathan Woods 2016-08-08 07:31:31 -04:00
parent 74e1aa4619
commit 89ccb9b8fe
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/frontend/mame/info.cpp
View File

@ -579,8 +579,7 @@ void info_xml_creator::output_rom(device_t &device)
if (!is_disk && is_bios) if (!is_disk && is_bios)
{ {
// scan backwards through the ROM entries // scan backwards through the ROM entries
auto entries = rom_build_entries(m_drivlist.driver().rom); for (const rom_entry *brom = rom - 1; brom != device.rom_region(); brom--)
for (const rom_entry *brom = entries.data(); !ROMENTRY_ISEND(brom); brom++)
if (ROMENTRY_ISSYSTEM_BIOS(brom)) if (ROMENTRY_ISSYSTEM_BIOS(brom))
{ {
strcpy(bios_name, ROM_GETNAME(brom)); strcpy(bios_name, ROM_GETNAME(brom));