Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-25 17:56:43 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

fmtowns.cpp: fix crash regression in System Sacom games (#5397) [r09]

Browse Source 
This fixes a regression introduced with commit bb32d72c7e that causes semi-random emulator crashes (at least in non-debug builds) in 38-man Kilo no Kokuu and Yami no Ketsuzoku Special. Apparently they are trying to set colors for palette indexes higher than 15 in 16-color mode, and the m_entry_color array goes out of bounds.

I'm not sure if the hardware discards everything but the 4 least significant bits of the palette index, or if it ignores the color change completely, but it doesn't seem to make any difference in practice, so I'm assuming the former.
This commit is contained in:
r09 2019-07-26 00:29:32 +02:00 committed by cracyc
parent 0b13d4741e
commit 8a2487c47b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mame/video/fmtowns.cpp
View File

@ -532,7 +532,7 @@ void towns_state::towns_update_palette()
{
case 0x00:
case 0x20:
m_palette16[(m_video.towns_video_reg[1] & 0x20) >> 5]->set_pen_color(entry, r, g, b);
m_palette16[(m_video.towns_video_reg[1] & 0x20) >> 5]->set_pen_color(entry & 0x0f, r, g, b);
break;
case 0x10:
case 0x30: