Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-23 00:39:36 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #1795 from ajrhacker/grainbow_fade

Browse Source 
grainbow: Fix palette dimming by respecting a fade-me-not bit
This commit is contained in:
Vas Crabb 2016-12-05 08:48:06 +11:00 committed by GitHub
commit 8ba74712b0
2 changed files with 22 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mame/machine/seibucop/seibucop.cpp
View File

@ -47,8 +47,6 @@
SD Gundam
- stage 3 mid-boss still has the sprite garbage bug;
- stage 4: has sprite stuck on bottom-left of screen;
- palette dims too much on attract / continue screen.
It's known that the DMA data arrangement gives same results on a real Legionnaire board, so shrug?
Seibu Cup Soccer
- Handles collision detection via the 130e/3bb0 macros
130e version in this makes a sub instead of an add as last opcode, which in turn reflects with

39
src/mame/machine/seibucop/seibucop_dma.hxx
View File

@ -41,8 +41,6 @@ void raiden2cop_device::dma_palette_brightness()
TODO:
- Denjin Makai mode 4 is totally guessworked.
- SD Gundam doesn't fade colors correctly, it should have the text layer / sprites with normal gradient and the rest dimmed in most cases,
presumably bad RAM table or bad algorithm
*/
//if(dma_trigger != 0x87)
@ -60,21 +58,28 @@ void raiden2cop_device::dma_palette_brightness()
if (pal_brightness_mode == 5)
{
bt = ((m_host_space->read_word(src + (cop_dma_adr_rel * 0x400))) & 0x7c00) >> 5;
bt = fade_table(bt | (pal_brightness_val ^ 0));
b = ((m_host_space->read_word(src)) & 0x7c00) >> 5;
b = fade_table(b | (pal_brightness_val ^ 0x1f));
pal_val = ((b + bt) & 0x1f) << 10;
gt = ((m_host_space->read_word(src + (cop_dma_adr_rel * 0x400))) & 0x03e0);
gt = fade_table(gt | (pal_brightness_val ^ 0));
g = ((m_host_space->read_word(src)) & 0x03e0);
g = fade_table(g | (pal_brightness_val ^ 0x1f));
pal_val |= ((g + gt) & 0x1f) << 5;
rt = ((m_host_space->read_word(src + (cop_dma_adr_rel * 0x400))) & 0x001f) << 5;
rt = fade_table(rt | (pal_brightness_val ^ 0));
r = ((m_host_space->read_word(src)) & 0x001f) << 5;
r = fade_table(r | (pal_brightness_val ^ 0x1f));
pal_val |= ((r + rt) & 0x1f);
u16 paldata = m_host_space->read_word(src);
if (BIT(paldata, 15))
pal_val = paldata; // fade me not
else
{
u16 targetpaldata = m_host_space->read_word(src + (cop_dma_adr_rel * 0x400));
bt = (targetpaldata & 0x7c00) >> 5;
bt = fade_table(bt | (pal_brightness_val ^ 0));
b = (paldata & 0x7c00) >> 5;
b = fade_table(b | (pal_brightness_val ^ 0x1f));
pal_val = ((b + bt) & 0x1f) << 10;
gt = (targetpaldata & 0x03e0);
gt = fade_table(gt | (pal_brightness_val ^ 0));
g = (paldata & 0x03e0);
g = fade_table(g | (pal_brightness_val ^ 0x1f));
pal_val |= ((g + gt) & 0x1f) << 5;
rt = (targetpaldata & 0x001f) << 5;
rt = fade_table(rt | (pal_brightness_val ^ 0));
r = (paldata & 0x001f) << 5;
r = fade_table(r | (pal_brightness_val ^ 0x1f));
pal_val |= ((r + rt) & 0x1f);
}
}
else if (pal_brightness_mode == 4) //Denjin Makai
{