From 8c8161227f52afff8da61ec9fd378199be12229f Mon Sep 17 00:00:00 2001 From: hap Date: Wed, 7 Dec 2022 02:26:57 +0100 Subject: [PATCH] hd647180x: fix typo on port E read --- src/devices/cpu/z180/hd647180x.cpp | 6 +++--- src/mame/toaplan/toaplan1.cpp | 6 +++--- src/mame/toaplan/toaplan1_m.cpp | 3 +-- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/devices/cpu/z180/hd647180x.cpp b/src/devices/cpu/z180/hd647180x.cpp index cc70b0781a8..8643be896b6 100644 --- a/src/devices/cpu/z180/hd647180x.cpp +++ b/src/devices/cpu/z180/hd647180x.cpp @@ -139,9 +139,9 @@ uint8_t hd647180x_device::z180_internal_port_read(uint8_t port) break; case 0x64: // lower half of ODRE is write-only - data = (m_odr[port - 0x60] | 0x0f) & m_ddr[3]; - if (m_ddr[3] != 0xff) - data |= m_port_input_cb[3](0, ~m_ddr[3]) & ~m_ddr[3]; + data = (m_odr[port - 0x60] | 0x0f) & m_ddr[4]; + if (m_ddr[4] != 0xff) + data |= m_port_input_cb[4](0, ~m_ddr[4]) & ~m_ddr[4]; LOG("HD647180X IDRE rd $%02x\n", data); break; diff --git a/src/mame/toaplan/toaplan1.cpp b/src/mame/toaplan/toaplan1.cpp index 10fa3b3bfb2..9a11da14dc0 100644 --- a/src/mame/toaplan/toaplan1.cpp +++ b/src/mame/toaplan/toaplan1.cpp @@ -991,12 +991,12 @@ void toaplan1_samesame_state::mcu_w(u8 data) { m_to_mcu = data; m_cmdavailable = 1; -}; +} u8 toaplan1_samesame_state::soundlatch_r() { return m_to_mcu; -}; +} void toaplan1_samesame_state::sound_done_w(u8 data) { @@ -1008,7 +1008,7 @@ u8 toaplan1_samesame_state::cmdavailable_r() { if (m_cmdavailable) return 0xff; else return 0x00; -}; +} void toaplan1_samesame_state::hd647180_io_map(address_map &map) { diff --git a/src/mame/toaplan/toaplan1_m.cpp b/src/mame/toaplan/toaplan1_m.cpp index f4ccbb2d7f8..08c55f876ca 100644 --- a/src/mame/toaplan/toaplan1_m.cpp +++ b/src/mame/toaplan/toaplan1_m.cpp @@ -79,7 +79,6 @@ void toaplan1_demonwld_state::dsp_bio_w(u16 data) /* data 0x0000 means set DSP BIO line active and disable */ /* communication to main processor*/ - logerror("DSP PC:%04x IO write %04x at port 3\n", m_dsp->pcbase(), data); if (data & 0x8000) m_dsp_bio = CLEAR_LINE; @@ -205,7 +204,7 @@ void toaplan1_state::coin_w(u8 data) { case 0xee: machine().bookkeeping().coin_counter_w(1,1); machine().bookkeeping().coin_counter_w(1,0); break; /* Count slot B */ case 0xed: machine().bookkeeping().coin_counter_w(0,1); machine().bookkeeping().coin_counter_w(0,0); break; /* Count slot A */ - /* The following are coin counts after coin-lock active (faulty coin-lock ?) */ + /* The following are coin counts after coin-lock active (faulty coin-lock ?) */ case 0xe2: machine().bookkeeping().coin_counter_w(1,1); machine().bookkeeping().coin_counter_w(1,0); machine().bookkeeping().coin_lockout_w(1,1); break; case 0xe1: machine().bookkeeping().coin_counter_w(0,1); machine().bookkeeping().coin_counter_w(0,0); machine().bookkeeping().coin_lockout_w(0,1); break;