Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-30 16:00:01 +03:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

namcona1.c: reduce tagmap lookups using ioport_array (nw)

Browse Source
This commit is contained in:
Alex W. Jackson 2014-04-22 11:13:26 +00:00
parent 727abb38c8
commit 92d6b69712
2 changed files with 12 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/mame/drivers/namcona1.c
View File

@ -661,23 +661,13 @@ WRITE8_MEMBER(namcona1_state::port6_w)
m_mcu_port6 = data; m_mcu_port6 = data;
} }
const char * const namcona1_state::ioport_tags[] = { "P4", "DSW", "P1", "P2" };
READ8_MEMBER(namcona1_state::port7_r) READ8_MEMBER(namcona1_state::port7_r)
{ {
switch (m_mcu_port6 & 0xe0) if ((m_mcu_port6 & 0x80) == 0)
{ return m_ioport[m_mcu_port6 >> 5]->read();
case 0x40: else
return ioport("P1")->read();
case 0x60:
return ioport("P2")->read();
case 0x20:
return ioport("DSW")->read();
case 0x00:
return ioport("P4")->read();
}
return 0xff; return 0xff;
} }
@ -713,7 +703,6 @@ void namcona1_state::machine_reset()
m_mcu_port5 = 1; m_mcu_port5 = 1;
} }
// "encrypt" player 3 inputs
// each bit of player 3's inputs is split across one of the 8 analog input ports // each bit of player 3's inputs is split across one of the 8 analog input ports
// bit 6 => port 0 // bit 6 => port 0
// bit 5 => port 1 // bit 5 => port 1
@ -726,7 +715,7 @@ void namcona1_state::machine_reset()
READ8_MEMBER(namcona1_state::portana_r) READ8_MEMBER(namcona1_state::portana_r)
{ {
static const UINT8 bitnum[8] = { 0x40, 0x20, 0x10, 0x01, 0x02, 0x04, 0x08, 0x80 }; static const UINT8 bitnum[8] = { 0x40, 0x20, 0x10, 0x01, 0x02, 0x04, 0x08, 0x80 };
UINT8 port = ioport("P3")->read(); UINT8 port = m_io_p3->read();
return (port & bitnum[offset>>1]) ? 0xff : 0x00; return (port & bitnum[offset>>1]) ? 0xff : 0x00;
} }

5
src/mame/includes/namcona1.h
View File

@ -25,6 +25,7 @@ enum
class namcona1_state : public driver_device class namcona1_state : public driver_device
{ {
static const char * const ioport_tags[];
public: public:
namcona1_state(const machine_config &mconfig, device_type type, const char *tag) namcona1_state(const machine_config &mconfig, device_type type, const char *tag)
: driver_device(mconfig, type, tag), : driver_device(mconfig, type, tag),
@ -34,6 +35,8 @@ public:
m_screen(*this, "screen"), m_screen(*this, "screen"),
m_palette(*this, "palette"), m_palette(*this, "palette"),
m_c140(*this, "c140"), m_c140(*this, "c140"),
m_ioport(*this, ioport_tags),
m_io_p3(*this, "P3"),
m_workram(*this,"workram"), m_workram(*this,"workram"),
m_vreg(*this,"vreg"), m_vreg(*this,"vreg"),
m_paletteram(*this, "paletteram"), m_paletteram(*this, "paletteram"),
@ -49,6 +52,8 @@ public:
required_device<screen_device> m_screen; required_device<screen_device> m_screen;
required_device<palette_device> m_palette; required_device<palette_device> m_palette;
required_device<c140_device> m_c140; required_device<c140_device> m_c140;
required_ioport_array<4> m_ioport;
required_ioport m_io_p3;
required_shared_ptr<UINT16> m_workram; required_shared_ptr<UINT16> m_workram;
required_shared_ptr<UINT16> m_vreg; required_shared_ptr<UINT16> m_vreg;
required_shared_ptr<UINT16> m_paletteram; required_shared_ptr<UINT16> m_paletteram;