From 9de7ddadee3afb72f065bda4d05310fa38119752 Mon Sep 17 00:00:00 2001 From: hap Date: Tue, 19 Sep 2023 10:19:34 +0200 Subject: [PATCH] namcos23: remove obsolete comment --- src/mame/hegenerglaser/roma2.cpp | 6 +++--- src/mame/namco/namcos23.cpp | 9 ++++----- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/mame/hegenerglaser/roma2.cpp b/src/mame/hegenerglaser/roma2.cpp index 27236f54820..44d6148e5b0 100644 --- a/src/mame/hegenerglaser/roma2.cpp +++ b/src/mame/hegenerglaser/roma2.cpp @@ -178,14 +178,14 @@ void roma2_state::roma2(machine_config &config) M68000(config, m_maincpu, 9.8304_MHz_XTAL); m_maincpu->set_addrmap(AS_PROGRAM, &roma2_state::main_map); + const attotime irq_period = attotime::from_hz(9.8304_MHz_XTAL / 0x14000); // 120Hz + m_maincpu->set_periodic_int(FUNC(roma2_state::irq5_line_hold), irq_period); + HC259(config, m_outlatch); // Q0-Q3: input mux; Q4: strobe; Q6-Q7: DAC m_outlatch->q_out_cb<4>().set(m_display, FUNC(mephisto_display1_device::strobe_w)); m_outlatch->parallel_out_cb().set(m_dac, FUNC(dac_byte_interface::write)).rshift(6).mask(3); - const attotime irq_period = attotime::from_hz(9.8304_MHz_XTAL / 0x14000); // 120Hz - m_maincpu->set_periodic_int(FUNC(roma2_state::irq5_line_hold), irq_period); - MEPHISTO_SENSORS_BOARD(config, m_board); m_board->set_delay(attotime::from_msec(200)); diff --git a/src/mame/namco/namcos23.cpp b/src/mame/namco/namcos23.cpp index 01efbf959a2..83c4dc60c76 100644 --- a/src/mame/namco/namcos23.cpp +++ b/src/mame/namco/namcos23.cpp @@ -120,7 +120,7 @@ c8000000: motoxgo(all) Inputs don't respond at all. Hardlocks shortly in atract mode. downhill Freeze with black screen after POST. downhillu Heavy gfx glitches. Missing rotary inputs. Random freezes. - timecrs2(all) Playable with some gfx glitches up until stage 1-2 (see sub_comm_r). + timecrs2(all) Playable with some gfx glitches panicprk,j,j2 Freezes during 'SUB-READY WAIT' after POST (see sub_comm_r). gunwars,a Hardlocks after POST (gmen related?). raceon Hardlocks after POST (gmen related?). @@ -3073,7 +3073,7 @@ void namcos23_state::mcuen_w(offs_t offset, uint16_t data, uint16_t mem_mask) default: // For some reason, the main program write the high 16bits of the // 32 bits words of itself there... - // logerror("mcuen_w: mask %04x, data %04x @ %x\n", mem_mask, data, offset); + //logerror("mcuen_w: mask %04x, data %04x @ %x\n", mem_mask, data, offset); break; } } @@ -3082,7 +3082,6 @@ void namcos23_state::mcuen_w(offs_t offset, uint16_t data, uint16_t mem_mask) // C?? (unknown comms) // while getting the subcpu to be ready, panicprk sits in a tight loop waiting for this AND 0002 to be non-zero (at PC=BFC02F00) -// timecrs2 locks up in a similar way as panicprk, at the beginning of the 2nd level, by reading/writing to this register a couple of times uint16_t namcos23_state::sub_comm_r(offs_t offset) { // status register @@ -3314,7 +3313,7 @@ void namcos23_state::s23h8rwmap(address_map &map) map(0x300000, 0x300003).noprw(); // seems to be more inputs, maybe false leftover code from System 12? map(0x300010, 0x300011).noprw(); map(0x300020, 0x300021).w(FUNC(namcos23_state::sub_interrupt_main_w)); - map(0x300030, 0x300031).nopw(); // timecrs2 writes this when writing to the sync shared ram location, motoxgo doesn't + map(0x300030, 0x300031).nopw(); // timecrs2 writes this when writing to the sync shared ram location, motoxgo doesn't } @@ -3547,7 +3546,7 @@ static INPUT_PORTS_START( finfurl ) PORT_BIT( 0x2000, IP_ACTIVE_LOW, IPT_JOYSTICK_RIGHT ) PORT_NAME("Whip Button R") PORT_MODIFY("ADC0") - PORT_BIT( 0x3ff, 0x0200, IPT_AD_STICK_Y ) PORT_SENSITIVITY(100) PORT_KEYDELTA(10) PORT_NAME("Swing") + PORT_BIT( 0x3ff, 0x0200, IPT_AD_STICK_Y ) PORT_SENSITIVITY(100) PORT_KEYDELTA(10) PORT_NAME("Swing") PORT_MODIFY("ADC1") PORT_BIT( 0x3ff, 0x0200, IPT_AD_STICK_X ) PORT_SENSITIVITY(100) PORT_KEYDELTA(10) PORT_NAME("Handle") PORT_REVERSE