Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-22 16:31:49 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

konami/k052109.cpp: Remove the color kludge for xmen/gradius3 (#12651)

Browse Source 
* removes the color kludge for xmen/gradius3
* proper handling (init/save) of new m_addrmap variable
This commit is contained in:
JOTEGO 2024-08-11 17:04:20 +02:00 committed by GitHub
parent 1c463815ad
commit 9ea9fad9cd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/mame/konami/k052109.cpp
View File

@ -36,12 +36,10 @@ address lines), and then reading it from the 051962.
- misc interface stuff
- ROM bank selector (CAB1-CAB2)
- character "code" (VC0-VC10)
- character "color" (COL0-COL7); used foc color but also bank switching and tile
flipping. Exact meaning depends on externl connections. All evidence indicates
that COL2 and COL3 select the tile bank, and are replaced with the low 2 bits
from the bank register. The top 2 bits of the register go to CAB1-CAB2.
However, this DOES NOT WORK with Gradius III. "color" seems to pass through
unaltered.
- character "color" (COL0-COL7); used for color but also bank switching and tile
flipping. Exact meaning depends on external connections. COL2 and COL3 select
the tile bank, and may be replaced with the low 2 bits from the bank register.
The top 2 bits of the register go to CAB1-CAB2.
- layer A horizontal scroll (ZA1H-ZA4H)
- layer B horizontal scroll (ZB1H-ZB4H)
- ????? (BEN)
@ -74,7 +72,17 @@ address lines), and then reading it from the 051962.
1000-17ff: layer B tilemap (attributes)
180c-1833: A y scroll
1a00-1bff: A x scroll
1c00 : ?
1c00 : Maps the three 8kB RAM chips to memory addresses.
------xx select the configuration from this table
RAM0 RAM1 RAM2
00 A~B 6~7 8~9 Reset state
01 8~9 4~5 6~7
10 6~7 2~3 4~5
11 4~5 0~1 2~3 TMNT setting
---xxx-- affects how RAMs are accessed
-x------
0 = replace bits 5:4 of color attribute by bits 1:0
1 = do not alter color attribute (gradius3,xmen)
1c80 : row/column scroll control
------xx layer A row scroll
00 = disabled
@ -263,6 +271,7 @@ void k052109_device::device_start()
save_item(NAME(m_irq_enabled));
save_item(NAME(m_charrombank));
save_item(NAME(m_charrombank_2));
save_item(NAME(m_addrmap));
save_item(NAME(m_has_extra_video_ram));
}
@ -276,7 +285,7 @@ void k052109_device::device_reset()
m_irq_enabled = 0;
m_romsubbank = 0;
m_scrollctrl = 0;
m_addrmap = 0;
m_has_extra_video_ram = 0;
for (int i = 0; i < 4; i++)
@ -377,6 +386,10 @@ void k052109_device::write(offs_t offset, u8 data)
{ /* A y scroll */ }
else if (offset >= 0x1a00 && offset < 0x1c00)
{ /* A x scroll */ }
else if (offset == 0x1c00)
{
m_addrmap = data;
}
else if (offset == 0x1c80)
{
if (m_scrollctrl != data)
@ -507,6 +520,7 @@ void k052109_device::tilemap_update( )
m_charrombank[1],
m_charrombank[2],
m_charrombank[3]);
// popmessage("%x",m_addrmap);
#endif
// note: this chip can do both per-column and per-row scroll in the same time, currently not emulated.
@ -679,10 +693,11 @@ void k052109_device::get_tile_info( tile_data &tileinfo, int tile_index, int lay
int flags = 0;
int priority = 0;
int bank = m_charrombank[(color & 0x0c) >> 2];
if (m_has_extra_video_ram)
bank = (color & 0x0c) >> 2; /* kludge for X-Men */
if (!BIT(m_addrmap,6))
{
color = (color & 0xf3) | ((bank & 0x03) << 2);
}
color = (color & 0xf3) | ((bank & 0x03) << 2);
bank >>= 2;
flipy = color & 0x02;

2
src/mame/konami/k052109.h
View File

@ -82,7 +82,7 @@ private:
uint8_t m_has_extra_video_ram;
int32_t m_rmrd_line;
uint8_t m_irq_enabled;
uint8_t m_romsubbank, m_scrollctrl;
uint8_t m_romsubbank, m_scrollctrl, m_addrmap;
int m_dx, m_dy;