Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-29 23:48:56 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

about: remove auto pause (nw)

Browse Source 
reason: inconsistent with other Tab menu entries including the fullscreen popup for selecting new machine, and also a bug where it refuses to unpause when closing About popup with Tab.
This commit is contained in:
hap 2020-03-26 12:19:02 +01:00
parent a8c0abadea
commit 9f2a29e08e
3 changed files with 4 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/frontend/mame/ui/about.cpp
View File

@ -27,7 +27,7 @@ namespace {
ABOUT MODAL ABOUT MODAL
**************************************************/ **************************************************/
//------------------------------------------------- //-------------------------------------------------
@ -36,8 +36,6 @@ namespace {
menu_about::menu_about(mame_ui_manager &mui, render_container &container) menu_about::menu_about(mame_ui_manager &mui, render_container &container)
: menu(mui, container) : menu(mui, container)
, m_pause_checked(false)
, m_was_paused(false)
{ {
} }
@ -48,28 +46,15 @@ menu_about::menu_about(mame_ui_manager &mui, render_container &container)
menu_about::~menu_about() menu_about::~menu_about()
{ {
// resume if appropriate (is the destructor really the right place
// to do this sort of activity?)
// TODO(mooglyguy): No, it isn't. We should have an explicit menu-exit callback.
if (!m_was_paused)
machine().resume();
} }
//------------------------------------------------- //-------------------------------------------------
// populate - populates the about modal // populate - populates the about modal
//------------------------------------------------- //-------------------------------------------------
void menu_about::populate(float &customtop, float &custombottom) void menu_about::populate(float &customtop, float &custombottom)
{ {
// pause if appropriate
if (!m_pause_checked)
{
m_was_paused = machine().paused();
if (!m_was_paused)
machine().pause();
m_pause_checked = true;
}
for (char const *const *line = copying_text; *line; ++line) for (char const *const *line = copying_text; *line; ++line)
item_append(*line, "", 0, nullptr); item_append(*line, "", 0, nullptr);

5
src/frontend/mame/ui/about.h
View File

@ -2,7 +2,7 @@
// copyright-holders:Ryan Holtz // copyright-holders:Ryan Holtz
/*************************************************************************** /***************************************************************************
ui/barcode.h ui/about.h
"About" modal "About" modal
@ -27,9 +27,6 @@ public:
private: private:
virtual void populate(float &customtop, float &custombottom) override; virtual void populate(float &customtop, float &custombottom) override;
virtual void handle() override; virtual void handle() override;
bool m_pause_checked;
bool m_was_paused;
}; };
} // namespace ui } // namespace ui

2
src/mame/drivers/conic_cchess2.cpp
View File

@ -282,4 +282,4 @@ ROM_END
******************************************************************************/ ******************************************************************************/
// YEAR NAME PARENT CMP MACHINE INPUT STATE INIT COMPANY, FULLNAME, FLAGS // YEAR NAME PARENT CMP MACHINE INPUT STATE INIT COMPANY, FULLNAME, FLAGS
CONS( 1980, cncchess2, 0, 0, cncchess2, cncchess2, cchess2_state, empty_init, "Conic", "Computer Chess (Conic, model 7012)", MACHINE_IMPERFECT_SOUND | MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) CONS( 1980, cncchess2, 0, 0, cncchess2, cncchess2, cchess2_state, empty_init, "Conic", "Computer Chess (Conic, model 7012)", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK )