Sprinter/mame
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

namconb: fix sound timing for some games.

Browse Source 
Did some digging into the sound timing issue in certain NB-1 games.
It seems like the C75 MCU does not like non-60 hz interrupt intervals,
wanting the interrupts to sync with a 120hz internal timer.

By moving the interrupt callbacks to separate 60 hz timers
(instead of the 59.7 scanline timer), this fixes the sound tempo in
nebulray, gslugrsj, gslgr94u and clones, and vshoot.
This commit is contained in:
superctr 2016-08-18 17:42:02 +02:00
parent bffc4d03d8
commit a20a6c6906
2 changed files with 28 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/mame/drivers/namconb1.cpp
View File

@ -9,7 +9,6 @@ Notes:
ToDo: ToDo:
- improve interrupts - improve interrupts
- gunbulet force feedback - gunbulet force feedback
- music tempo is too fast in Nebulas Ray, JLS V-Shoot and the Great Sluggers games
Main CPU : Motorola 68020 32-bit processor @ 25MHz Main CPU : Motorola 68020 32-bit processor @ 25MHz
Secondary CPUs : C329 + 137 (both custom) Secondary CPUs : C329 + 137 (both custom)
@ -315,7 +314,7 @@ TIMER_DEVICE_CALLBACK_MEMBER(namconb1_state::scantimer)
if (m_pos_irq_level != 0) if (m_pos_irq_level != 0)
m_maincpu->set_input_line(m_pos_irq_level, ASSERT_LINE); m_maincpu->set_input_line(m_pos_irq_level, ASSERT_LINE);
} }
/*
// TODO: Real sources of these // TODO: Real sources of these
if (scanline == 224) if (scanline == 224)
m_mcu->set_input_line(M37710_LINE_IRQ0, HOLD_LINE); m_mcu->set_input_line(M37710_LINE_IRQ0, HOLD_LINE);
@ -323,9 +322,23 @@ TIMER_DEVICE_CALLBACK_MEMBER(namconb1_state::scantimer)
m_mcu->set_input_line(M37710_LINE_IRQ2, HOLD_LINE); m_mcu->set_input_line(M37710_LINE_IRQ2, HOLD_LINE);
else if (scanline == 128) else if (scanline == 128)
m_mcu->set_input_line(M37710_LINE_ADC, HOLD_LINE); m_mcu->set_input_line(M37710_LINE_ADC, HOLD_LINE);
*/
} }
TIMER_DEVICE_CALLBACK_MEMBER(namconb1_state::mcu_irq0_cb)
{
m_mcu->set_input_line(M37710_LINE_IRQ0, HOLD_LINE);
}
TIMER_DEVICE_CALLBACK_MEMBER(namconb1_state::mcu_irq2_cb)
{
m_mcu->set_input_line(M37710_LINE_IRQ2, HOLD_LINE);
}
TIMER_DEVICE_CALLBACK_MEMBER(namconb1_state::mcu_adc_cb)
{
m_mcu->set_input_line(M37710_LINE_ADC, HOLD_LINE);
}
/****************************************************************************/ /****************************************************************************/
@ -1128,6 +1141,11 @@ static MACHINE_CONFIG_START( namconb1, namconb1_state )
MCFG_TIMER_DRIVER_ADD_SCANLINE("scantimer", namconb1_state, scantimer, "screen", 0, 1) MCFG_TIMER_DRIVER_ADD_SCANLINE("scantimer", namconb1_state, scantimer, "screen", 0, 1)
// has to be 60 hz or music will go crazy in nebulray, vshoot, gslugrs*
MCFG_TIMER_DRIVER_ADD_PERIODIC("mcu_irq0", namconb1_state, mcu_irq0_cb, attotime::from_hz(60))
MCFG_TIMER_DRIVER_ADD_PERIODIC("mcu_irq2", namconb1_state, mcu_irq2_cb, attotime::from_hz(60))
MCFG_TIMER_DRIVER_ADD_PERIODIC("mcu_adc", namconb1_state, mcu_adc_cb, attotime::from_hz(60))
MCFG_SCREEN_ADD("screen", RASTER) MCFG_SCREEN_ADD("screen", RASTER)
MCFG_SCREEN_REFRESH_RATE(59.7) MCFG_SCREEN_REFRESH_RATE(59.7)
MCFG_SCREEN_SIZE(NAMCONB1_HTOTAL, NAMCONB1_VTOTAL) MCFG_SCREEN_SIZE(NAMCONB1_HTOTAL, NAMCONB1_VTOTAL)
@ -1164,6 +1182,9 @@ static MACHINE_CONFIG_START( namconb2, namconb1_state )
MCFG_MACHINE_RESET_OVERRIDE(namconb1_state, namconb) MCFG_MACHINE_RESET_OVERRIDE(namconb1_state, namconb)
MCFG_TIMER_DRIVER_ADD_SCANLINE("scantimer", namconb1_state, scantimer, "screen", 0, 1) MCFG_TIMER_DRIVER_ADD_SCANLINE("scantimer", namconb1_state, scantimer, "screen", 0, 1)
MCFG_TIMER_DRIVER_ADD_PERIODIC("mcu_irq0", namconb1_state, mcu_irq0_cb, attotime::from_hz(60))
MCFG_TIMER_DRIVER_ADD_PERIODIC("mcu_irq2", namconb1_state, mcu_irq2_cb, attotime::from_hz(60))
MCFG_TIMER_DRIVER_ADD_PERIODIC("mcu_adc", namconb1_state, mcu_adc_cb, attotime::from_hz(60))
MCFG_SCREEN_ADD("screen", RASTER) MCFG_SCREEN_ADD("screen", RASTER)
MCFG_SCREEN_REFRESH_RATE(59.7) MCFG_SCREEN_REFRESH_RATE(59.7)

3
src/mame/includes/namconb1.h
View File

@ -113,6 +113,9 @@ public:
UINT32 screen_update_namconb2(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect); UINT32 screen_update_namconb2(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect);
TIMER_DEVICE_CALLBACK_MEMBER(scantimer); TIMER_DEVICE_CALLBACK_MEMBER(scantimer);
TIMER_DEVICE_CALLBACK_MEMBER(mcu_irq0_cb);
TIMER_DEVICE_CALLBACK_MEMBER(mcu_irq2_cb);
TIMER_DEVICE_CALLBACK_MEMBER(mcu_adc_cb);
int NB1objcode2tile(int code); int NB1objcode2tile(int code);
int NB2objcode2tile(int code); int NB2objcode2tile(int code);