Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-07-07 10:58:41 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "i8244: fix problem with major system overlap"

Browse Source 
This reverts commit 401e9f670a.
This commit is contained in:
hap 2021-02-01 20:54:09 +01:00
parent 70d2fce7d6
commit a6218ad31d
2 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/devices/video/i8244.cpp
View File

@ -564,24 +564,25 @@ void i8244_device::char_pixel(u8 index, int x, int y, u8 pixel, u16 color, bitma
m_control_status |= 0x80; m_control_status |= 0x80;
// TODO: much more complex on actual console (weird glitches happen) // TODO: much more complex on actual console (weird glitches happen)
continue; if (colx & 0x80)
continue;
} }
else else
m_priority_map[px] = index; m_priority_map[px] = index;
// note: collision affects transparent pixels too
// check if we collide with an already drawn source object
if (m_vdc.s.collision & colx)
m_collision_status |= 0x80;
// check if an already drawn object would collide with us
if (m_vdc.s.collision & 0x80)
m_collision_status |= colx;
m_collision_map[px] |= 0x80;
if (pixel) if (pixel)
{
// check if we collide with an already drawn source object
if (m_vdc.s.collision & colx)
m_collision_status |= 0x80;
// check if an already drawn object would collide with us
if (m_vdc.s.collision & 0x80)
m_collision_status |= colx;
m_collision_map[px] |= 0x80;
bitmap.pix(y, px) = color; bitmap.pix(y, px) = color;
}
} }
} }
} }

1
src/mame/drivers/odyssey2.cpp
View File

@ -60,6 +60,7 @@ TODO:
(including transparent pixels) will cause glitches and instability, it can even (including transparent pixels) will cause glitches and instability, it can even
overwrite the VDC color and pointer registers overwrite the VDC color and pointer registers
* gunfight: accidental usage, sometimes causes 1-frame glitches near bullet * gunfight: accidental usage, sometimes causes 1-frame glitches near bullet
* powerlrd: occurs at pink mountain on the right, it's not 1:1 identical on MAME
* several homebrews by Rafael: precisely placed overlap to force character * several homebrews by Rafael: precisely placed overlap to force character
color to change to white, see for example Piggyback Planet and Mean Santa color to change to white, see for example Piggyback Planet and Mean Santa
- 8245(PAL) video timing is not 100% accurate, though vtotal and htotal should - 8245(PAL) video timing is not 100% accurate, though vtotal and htotal should