Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-07-02 16:49:22 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

z8536: Avoid magic numbers

Browse Source
This commit is contained in:
Dirk Best 2021-08-05 11:00:31 +02:00
parent 4c1ab8885d
commit aaf23770a3
2 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/devices/machine/z8536.cpp
View File

@ -1041,19 +1041,19 @@ u8 z8536_device::read(offs_t offset)
{
switch (offset & 0x03)
{
case 0:
case EXT_PORT_C:
data = read_register(PORT_C_DATA);
break;
case 1:
case EXT_PORT_B:
data = read_register(PORT_B_DATA);
break;
case 2:
case EXT_PORT_A:
data = read_register(PORT_A_DATA);
break;
case 3:
case EXT_CONTROL:
// state 0 or state 1: read data
data = read_register(m_pointer);
@ -1107,19 +1107,19 @@ void z8536_device::write(offs_t offset, u8 data)
{
switch (offset & 0x03)
{
case 0:
case EXT_PORT_C:
write_register(PORT_C_DATA, data);
break;
case 1:
case EXT_PORT_B:
write_register(PORT_B_DATA, data);
break;
case 2:
case EXT_PORT_A:
write_register(PORT_A_DATA, data);
break;
case 3:
case EXT_CONTROL:
if (m_state0)
{
// state 0: write pointer

9
src/devices/machine/z8536.h
View File

@ -443,6 +443,15 @@ protected:
virtual void z80daisy_irq_reti() override;
private:
// direct external access to ports
enum
{
EXT_PORT_C = 0,
EXT_PORT_B,
EXT_PORT_A,
EXT_CONTROL
};
// control state machine
bool m_state0;
u8 m_pointer;