Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-28 15:14:21 +03:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fixed a bug that caused "Switch Item Ordering" in the software list menu to dupe entries

Browse Source 
This was MT#6402
This commit is contained in:
Nathan Woods 2017-04-03 18:12:23 -04:00 committed by Vas Crabb
parent 58aa97913f
commit ac1cea0dcf
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/frontend/mame/ui/swlist.cpp
View File

@ -22,9 +22,12 @@ namespace ui {
CONSTANTS CONSTANTS
***************************************************************************/ ***************************************************************************/
/* time (in seconds) to display errors */ // time (in seconds) to display errors
#define ERROR_MESSAGE_TIME 5 #define ERROR_MESSAGE_TIME 5
// item reference for "Switch Item Ordering"
#define ITEMREF_SWITCH_ITEM_ORDERING ((void *)1)
/*************************************************************************** /***************************************************************************
SOFTWARE PARTS SOFTWARE PARTS
@ -214,12 +217,15 @@ void menu_software_list::append_software_entry(const software_info &swinfo)
void menu_software_list::populate(float &customtop, float &custombottom) void menu_software_list::populate(float &customtop, float &custombottom)
{ {
// clear all entries before populating
m_entrylist.clear();
// build up the list of entries for the menu // build up the list of entries for the menu
for (const software_info &swinfo : m_swlist->get_info()) for (const software_info &swinfo : m_swlist->get_info())
append_software_entry(swinfo); append_software_entry(swinfo);
// add an entry to change ordering // add an entry to change ordering
item_append(_("Switch Item Ordering"), "", 0, (void *)1); item_append(_("Switch Item Ordering"), "", 0, ITEMREF_SWITCH_ITEM_ORDERING);
// append all of the menu entries // append all of the menu entries
for (auto &entry : m_entrylist) for (auto &entry : m_entrylist)
@ -241,7 +247,7 @@ void menu_software_list::handle()
if (event && event->itemref) if (event && event->itemref)
{ {
if ((uintptr_t)event->itemref == 1 && event->iptkey == IPT_UI_SELECT) if (event->itemref == ITEMREF_SWITCH_ITEM_ORDERING && event->iptkey == IPT_UI_SELECT)
{ {
m_ordered_by_shortname = !m_ordered_by_shortname; m_ordered_by_shortname = !m_ordered_by_shortname;