Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-07-04 17:38:08 +03:00
Code Issues Actions 36 Packages Projects Releases Wiki Activity

Fix most implicit fallthrough warnings from clang

Browse Source
This commit is contained in:
Vas Crabb 2020-11-17 09:18:37 +11:00
parent f14e1794d7
commit ac270744f3
46 changed files with 162 additions and 173 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
scripts/src/3rdparty.lua
View File

@ -1176,15 +1176,6 @@ project "bx"
configuration { } configuration { }
local version = str_to_version(_OPTIONS["gcc_version"])
if _OPTIONS["gcc"]~=nil and string.find(_OPTIONS["gcc"], "gcc") then
if version < 60000 then
buildoptions {
"-Wno-strict-overflow",
}
end
end
includedirs { includedirs {
MAME_DIR .. "3rdparty/bx/include", MAME_DIR .. "3rdparty/bx/include",
MAME_DIR .. "3rdparty/bx/3rdparty", MAME_DIR .. "3rdparty/bx/3rdparty",

2
src/devices/bus/abcbus/ssa.cpp
View File

@ -178,7 +178,7 @@ uint8_t abc_super_smartaid_device::abcbus_xmemfl(offs_t offset)
{ {
case 0x08: case 0x08:
m_prom_bank = 1; m_prom_bank = 1;
// fallthru [[fallthrough]];
case 0x0c: case 0x0f: case 0x0c: case 0x0f:
data = m_rom_2->base()[(m_rom_bank << 12) | (offset & 0xfff)]; data = m_rom_2->base()[(m_rom_bank << 12) | (offset & 0xfff)];
break; break;

6
src/devices/bus/gba/gba_slot.cpp
View File

@ -659,13 +659,13 @@ image_init_result gba_cart_slot_device::call_load()
{ {
case 2 * 1024 * 1024: case 2 * 1024 * 1024:
memcpy(ROM + 0x200000, ROM, 0x200000); memcpy(ROM + 0x200000, ROM, 0x200000);
// intentional fall-through [[fallthrough]];
case 4 * 1024 * 1024: case 4 * 1024 * 1024:
memcpy(ROM + 0x400000, ROM, 0x400000); memcpy(ROM + 0x400000, ROM, 0x400000);
// intentional fall-through [[fallthrough]];
case 8 * 1024 * 1024: case 8 * 1024 * 1024:
memcpy(ROM + 0x800000, ROM, 0x800000); memcpy(ROM + 0x800000, ROM, 0x800000);
// intentional fall-through [[fallthrough]];
case 16 * 1024 * 1024: case 16 * 1024 * 1024:
memcpy(ROM + 0x1000000, ROM, 0x1000000); memcpy(ROM + 0x1000000, ROM, 0x1000000);
break; break;

1
src/devices/bus/sunkbd/hlekbd.cpp
View File

@ -985,6 +985,7 @@ void hle_device_base::received_byte(uint8_t byte)
default: default:
assert(m_rx_state == RX_IDLE); assert(m_rx_state == RX_IDLE);
[[fallthrough]];
case RX_IDLE: case RX_IDLE:
switch (byte) switch (byte)
{ {

1
src/devices/bus/ti8x/ti8x.cpp
View File

@ -432,6 +432,7 @@ TIMER_CALLBACK_MEMBER(device_ti8x_link_port_bit_interface::bit_timeout)
// send timeout: // send timeout:
case WAIT_IDLE: case WAIT_IDLE:
assert(EMPTY != m_tx_bit_buffer); assert(EMPTY != m_tx_bit_buffer);
[[fallthrough]];
case WAIT_ACK_0: case WAIT_ACK_0:
case WAIT_ACK_1: case WAIT_ACK_1:
case WAIT_REL_0: case WAIT_REL_0:

20
src/devices/cpu/drcbec.cpp
View File

@ -540,7 +540,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_EXIT, 4, 1): // EXIT src1[,c] case MAKE_OPCODE_SHORT(OP_EXIT, 4, 1): // EXIT src1[,c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_EXIT, 4, 0): case MAKE_OPCODE_SHORT(OP_EXIT, 4, 0):
return PARAM0; return PARAM0;
@ -548,7 +548,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_JMP, 4, 1): // JMP imm[,c] case MAKE_OPCODE_SHORT(OP_JMP, 4, 1): // JMP imm[,c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_JMP, 4, 0): case MAKE_OPCODE_SHORT(OP_JMP, 4, 0):
newinst = inst[0].inst; newinst = inst[0].inst;
@ -559,7 +559,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_CALLH, 4, 1): // CALLH handle[,c] case MAKE_OPCODE_SHORT(OP_CALLH, 4, 1): // CALLH handle[,c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_CALLH, 4, 0): case MAKE_OPCODE_SHORT(OP_CALLH, 4, 0):
assert(sp < ARRAY_LENGTH(callstack)); assert(sp < ARRAY_LENGTH(callstack));
@ -572,7 +572,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_RET, 4, 1): // RET [c] case MAKE_OPCODE_SHORT(OP_RET, 4, 1): // RET [c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_RET, 4, 0): case MAKE_OPCODE_SHORT(OP_RET, 4, 0):
assert(sp > 0); assert(sp > 0);
@ -584,7 +584,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_EXH, 4, 1): // EXH handle,param[,c] case MAKE_OPCODE_SHORT(OP_EXH, 4, 1): // EXH handle,param[,c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_EXH, 4, 0): case MAKE_OPCODE_SHORT(OP_EXH, 4, 0):
assert(sp < ARRAY_LENGTH(callstack)); assert(sp < ARRAY_LENGTH(callstack));
@ -598,7 +598,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_CALLC, 4, 1): // CALLC func,ptr[,c] case MAKE_OPCODE_SHORT(OP_CALLC, 4, 1): // CALLC func,ptr[,c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_CALLC, 4, 0): case MAKE_OPCODE_SHORT(OP_CALLC, 4, 0):
(*inst[0].cfunc)(inst[1].v); (*inst[0].cfunc)(inst[1].v);
@ -833,7 +833,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_MOV, 4, 1): // MOV dst,src[,c] case MAKE_OPCODE_SHORT(OP_MOV, 4, 1): // MOV dst,src[,c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_MOV, 4, 0): case MAKE_OPCODE_SHORT(OP_MOV, 4, 0):
PARAM0 = PARAM1; PARAM0 = PARAM1;
@ -1466,7 +1466,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_MOV, 8, 1): // DMOV dst,src[,c] case MAKE_OPCODE_SHORT(OP_MOV, 8, 1): // DMOV dst,src[,c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_MOV, 8, 0): case MAKE_OPCODE_SHORT(OP_MOV, 8, 0):
DPARAM0 = DPARAM1; DPARAM0 = DPARAM1;
@ -1837,7 +1837,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_FMOV, 4, 1): // FSMOV dst,src[,c] case MAKE_OPCODE_SHORT(OP_FMOV, 4, 1): // FSMOV dst,src[,c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_FMOV, 4, 0): case MAKE_OPCODE_SHORT(OP_FMOV, 4, 0):
FSPARAM0 = FSPARAM1; FSPARAM0 = FSPARAM1;
@ -1980,7 +1980,7 @@ int drcbe_c::execute(code_handle &entry)
case MAKE_OPCODE_SHORT(OP_FMOV, 8, 1): // FDMOV dst,src[,c] case MAKE_OPCODE_SHORT(OP_FMOV, 8, 1): // FDMOV dst,src[,c]
if (OPCODE_FAIL_CONDITION(opcode, flags)) if (OPCODE_FAIL_CONDITION(opcode, flags))
break; break;
// fall through... [[fallthrough]];
case MAKE_OPCODE_SHORT(OP_FMOV, 8, 0): case MAKE_OPCODE_SHORT(OP_FMOV, 8, 0):
FDPARAM0 = FDPARAM1; FDPARAM0 = FDPARAM1;

4
src/devices/cpu/dspp/dsppdrc.cpp
View File

@ -501,10 +501,10 @@ void dspp_device::generate_set_rbase(drcuml_block &block, compiler_state *compil
case 0: case 0:
UML_MOV(block, mem(&m_core->m_rbase[0]), addr); UML_MOV(block, mem(&m_core->m_rbase[0]), addr);
UML_MOV(block, mem(&m_core->m_rbase[1]), addr + 4 - base); UML_MOV(block, mem(&m_core->m_rbase[1]), addr + 4 - base);
// Intentional fall-through [[fallthrough]];
case 8: case 8:
UML_MOV(block, mem(&m_core->m_rbase[2]), addr + 8 - base); UML_MOV(block, mem(&m_core->m_rbase[2]), addr + 8 - base);
// Intentional fall-through [[fallthrough]];
case 12: case 12:
UML_MOV(block, mem(&m_core->m_rbase[3]), addr + 12 - base); UML_MOV(block, mem(&m_core->m_rbase[3]), addr + 12 - base);
break; break;

2
src/devices/cpu/hd61700/hd61700.cpp
View File

@ -2578,7 +2578,7 @@ void hd61700_cpu_device::execute_run()
m_icount -= 5; m_icount -= 5;
} }
//fall through [[fallthrough]];
case 0xfc: //cani case 0xfc: //cani
{ {

2
src/devices/cpu/lc8670/lc8670dsm.cpp
View File

@ -107,7 +107,7 @@ void lc8670_disassembler::dasm_arg(uint8_t op, char *buffer, offs_t pc, int arg,
break; break;
case OP_R8: case OP_R8:
pc++; pc++;
// fall through [[fallthrough]];
case OP_R8RI: case OP_R8RI:
buffer += sprintf(buffer, "%04x", (pc + 1 + opcodes.r8(pos) - (opcodes.r8(pos)&0x80 ? 0x100 : 0)) & 0xffff); buffer += sprintf(buffer, "%04x", (pc + 1 + opcodes.r8(pos) - (opcodes.r8(pos)&0x80 ? 0x100 : 0)) & 0xffff);
pos++; pos++;

4
src/devices/cpu/mips/ps2vif1.cpp
View File

@ -349,7 +349,7 @@ void ps2_vif1_device::execute_run()
m_icount = 0; m_icount = 0;
break; break;
} }
// Intentional fall-through [[fallthrough]];
case STAT_MODE_DECODE: case STAT_MODE_DECODE:
decode_vifcode(); decode_vifcode();
break; break;
@ -359,7 +359,7 @@ void ps2_vif1_device::execute_run()
m_icount = 0; m_icount = 0;
break; break;
} }
// Intentional fall-through [[fallthrough]];
case STAT_MODE_DATA: case STAT_MODE_DATA:
transfer_vifcode_data(); transfer_vifcode_data();
break; break;

4
src/devices/cpu/pic17/pic17.cpp
View File

@ -890,6 +890,7 @@ void pic17_cpu_device::execute_run()
{ {
while (true) while (true)
{ {
[[fallthrough]];
case exec_phase::Q1: case exec_phase::Q1:
if ((m_execflags & SLEEP) != 0) if ((m_execflags & SLEEP) != 0)
{ {
@ -922,6 +923,7 @@ void pic17_cpu_device::execute_run()
m_execphase = exec_phase::Q2; m_execphase = exec_phase::Q2;
return; return;
} }
[[fallthrough]];
case exec_phase::Q2: case exec_phase::Q2:
if ((m_execflags & INTRPT) == 0) if ((m_execflags & INTRPT) == 0)
@ -942,6 +944,7 @@ void pic17_cpu_device::execute_run()
m_execphase = exec_phase::Q3; m_execphase = exec_phase::Q3;
return; return;
} }
[[fallthrough]];
case exec_phase::Q3: case exec_phase::Q3:
if ((m_execflags & (TABLRD | TABLWT)) == 0) if ((m_execflags & (TABLRD | TABLWT)) == 0)
@ -967,6 +970,7 @@ void pic17_cpu_device::execute_run()
m_execphase = exec_phase::Q4; m_execphase = exec_phase::Q4;
return; return;
} }
[[fallthrough]];
case exec_phase::Q4: case exec_phase::Q4:
if ((m_intsample & m_intsta) != 0) if ((m_intsample & m_intsta) != 0)

2
src/devices/cpu/score/score.cpp
View File

@ -346,7 +346,7 @@ void score7_cpu_device::gen_exception(int cause, uint32_t param)
{ {
case EXCEPTION_P_EL: case EXCEPTION_P_EL:
REG_EMA = REG_EPC; REG_EMA = REG_EPC;
// intentional fallthrough [[fallthrough]];
case EXCEPTION_NMI: case EXCEPTION_NMI:
case EXCEPTION_CEE: case EXCEPTION_CEE:
case EXCEPTION_SYSCALL: case EXCEPTION_SYSCALL:

1
src/devices/cpu/sm8500/sm85ops.h
View File

@ -144,6 +144,7 @@
s2 = s2 + mem_readbyte( ( r1 >> 3 ) & 0x07 ); \ s2 = s2 + mem_readbyte( ( r1 >> 3 ) & 0x07 ); \
} \ } \
s2 = mem_readword( s2 ); \ s2 = mem_readword( s2 ); \
break; \
case 0x80: \ case 0x80: \
case 0xC0: \ case 0xC0: \
break; \ break; \

1
src/devices/cpu/sparc/sparcdasm.cpp
View File

@ -721,6 +721,7 @@ sparc_disassembler::sparc_disassembler(const config *conf, unsigned version, vis
m_vis_op_desc.find(0x07c)->second.mnemonic = "ford"; m_vis_op_desc.find(0x07c)->second.mnemonic = "ford";
m_vis_op_desc.find(0x07e)->second.mnemonic = "foned"; m_vis_op_desc.find(0x07e)->second.mnemonic = "foned";
} }
[[fallthrough]];
case vis_none: case vis_none:
break; break;
} }

2
src/devices/cpu/z80/z80dasm.cpp
View File

@ -497,7 +497,7 @@ offs_t z80_disassembler::disassemble(std::ostream &stream, offs_t pc, const data
break; break;
case 'X': case 'X':
offset = params.r8(pos++); offset = params.r8(pos++);
/* fall through */ [[fallthrough]];
case 'Y': case 'Y':
util::stream_format(stream,"(%s%c$%02x)", ixy, sign(offset), offs(offset) ); util::stream_format(stream,"(%s%c$%02x)", ixy, sign(offset), offs(offset) );
break; break;

2
src/devices/machine/am9513.cpp
View File

@ -1304,7 +1304,7 @@ void am9513_device::command_write(u8 data)
m_write_prefetch = !BIT(data, 0); m_write_prefetch = !BIT(data, 0);
break; break;
} }
// else fall through [[fallthrough]];
default: default:
logerror("Invalid command: %02X\n", data); logerror("Invalid command: %02X\n", data);
break; break;

2
src/devices/machine/hp_taco.cpp
View File

@ -434,7 +434,7 @@ WRITE_LINE_MEMBER(hp_taco_device::tacho_tick_w)
if (m_cmd_state != CMD_PH1) { if (m_cmd_state != CMD_PH1) {
break; break;
} }
// Falls through! [[fallthrough]];
case CMD_WR_GAP_N_TACH: case CMD_WR_GAP_N_TACH:
case CMD_INT_N_TACH: case CMD_INT_N_TACH:

42
src/devices/machine/i8291a.cpp
View File

@ -432,27 +432,27 @@ void i8291a_device::aux_mode_w(uint8_t data)
device_reset(); device_reset();
break; break;
} }
case 1: break;
/* preset internal clock counter */ case 1:
break; /* preset internal clock counter */
case 4: break;
LOGMASKED(LOG_REG, "AUXA = %02X\n", data & 0x1f); case 4:
/* AUXA write */ LOGMASKED(LOG_REG, "AUXA = %02X\n", data & 0x1f);
m_auxa = data; /* AUXA write */
break; m_auxa = data;
case 5: break;
LOGMASKED(LOG_REG, "AUXB = %02X\n", data & 0x1f); case 5:
m_auxb = data; LOGMASKED(LOG_REG, "AUXB = %02X\n", data & 0x1f);
break; m_auxb = data;
case 3: break;
LOGMASKED(LOG_REG, "PPOLL %s (line %d)\n", (data & 0x10) ? "disable" : "enable", data & 7); case 3:
m_lpe = !!!(data & 0x10); LOGMASKED(LOG_REG, "PPOLL %s (line %d)\n", (data & 0x10) ? "disable" : "enable", data & 7);
m_pp_sense = data & 0x08; m_lpe = !!!(data & 0x10);
m_pp_line = data & 7; m_pp_sense = data & 0x08;
break; m_pp_line = data & 7;
default: break;
break; default:
break;
} }
run_fsm(); run_fsm();
} }

2
src/devices/machine/icm7170.cpp
View File

@ -305,7 +305,7 @@ void icm7170_device::write(offs_t offset, uint8_t data)
case REG_COMMAND: case REG_COMMAND:
m_timer->enable(data & CMD_REG_RUN); m_timer->enable(data & CMD_REG_RUN);
// fall through [[fallthrough]];
default: default:
m_regs[offset & 0x1f] = data; m_regs[offset & 0x1f] = data;

4
src/devices/machine/msm6242.cpp
View File

@ -325,11 +325,11 @@ void msm6242_device::update_timer()
{ {
case IRQ_HOUR: case IRQ_HOUR:
callback_ticks += (59 - get_clock_register(RTC_MINUTE)) * (0x8000 * 60); callback_ticks += (59 - get_clock_register(RTC_MINUTE)) * (0x8000 * 60);
// fall through [[fallthrough]];
case IRQ_MINUTE: case IRQ_MINUTE:
callback_ticks += (59 - get_clock_register(RTC_SECOND)) * 0x8000; callback_ticks += (59 - get_clock_register(RTC_SECOND)) * 0x8000;
// fall through [[fallthrough]];
case IRQ_SECOND: case IRQ_SECOND:
callback_ticks += 0x8000 - m_tick; callback_ticks += 0x8000 - m_tick;

2
src/devices/machine/ps2dma.cpp
View File

@ -327,7 +327,7 @@ void ps2_dmac_device::follow_source_tag(uint32_t chan)
break; break;
case ID_REFE: case ID_REFE:
channel.set_end_tag(true); channel.set_end_tag(true);
// Intentional fall-through [[fallthrough]];
case ID_REF: case ID_REF:
channel.set_addr(addr); channel.set_addr(addr);
channel.set_tag_addr(channel.tag_addr() + 0x10); channel.set_tag_addr(channel.tag_addr() + 0x10);

2
src/devices/machine/smc91c9x.cpp
View File

@ -729,7 +729,7 @@ void smc91c9x_device::process_command(uint16_t data)
LOG(" REMOVE AND RELEASE FRAME FROM RX FIFO (PACK_NUM=%d)\n", curr_completed_rx()); LOG(" REMOVE AND RELEASE FRAME FROM RX FIFO (PACK_NUM=%d)\n", curr_completed_rx());
// Release memory allocation // Release memory allocation
alloc_release(curr_completed_rx()); alloc_release(curr_completed_rx());
// Fall through [[fallthrough]];
case ECMD_REMOVE_TOPFRAME_RX: case ECMD_REMOVE_TOPFRAME_RX:
LOG(" REMOVE FRAME FROM RX FIFO\n"); LOG(" REMOVE FRAME FROM RX FIFO\n");
// remove entry from rx completion queue // remove entry from rx completion queue

2
src/devices/machine/spg2xx_io.cpp
View File

@ -805,7 +805,7 @@ void spg2xx_io_device::io_w(offs_t offset, uint16_t data)
case REG_IOA_DATA: case REG_IOB_DATA: case REG_IOC_DATA: case REG_IOA_DATA: case REG_IOB_DATA: case REG_IOC_DATA:
offset++; offset++;
// Intentional fallthrough - we redirect data register writes to the buffer register. [[fallthrough]]; // we redirect data register writes to the buffer register.
case REG_IOA_BUFFER: case REG_IOA_ATTRIB: case REG_IOA_BUFFER: case REG_IOA_ATTRIB:
case REG_IOB_BUFFER: case REG_IOB_ATTRIB: case REG_IOB_BUFFER: case REG_IOB_ATTRIB:

2
src/devices/machine/upd765.cpp
View File

@ -3193,7 +3193,7 @@ void upd72067_device::auxcmd_w(uint8_t data)
for(unsigned i = 0; i < 4; i++) for(unsigned i = 0; i < 4; i++)
if(flopi[i].dev) if(flopi[i].dev)
flopi[i].dev->mon_w(!BIT(data, i + 4)); flopi[i].dev->mon_w(!BIT(data, i + 4));
// fall through [[fallthrough]];
case 0x03: // enable external mode case 0x03: // enable external mode
case 0x0b: // control internal mode case 0x0b: // control internal mode
case 0x0f: // select format case 0x0f: // select format

4
src/devices/video/voodoo.cpp
View File

@ -3228,7 +3228,7 @@ int32_t voodoo_device::register_w(voodoo_device *vd, offs_t offset, uint32_t dat
case fbiInit6: case fbiInit6:
if (vd->vd_type < TYPE_VOODOO_2) if (vd->vd_type < TYPE_VOODOO_2)
break; break;
/* else fall through... */ [[fallthrough]];
/* fbiInitX can only be written if initEnable says we can -- Voodoo/Voodoo2 only */ /* fbiInitX can only be written if initEnable says we can -- Voodoo/Voodoo2 only */
/* most of these affect memory layout, so always recompute that when done */ /* most of these affect memory layout, so always recompute that when done */
@ -5522,7 +5522,7 @@ void voodoo_banshee_device::banshee_io_w(offs_t offset, u32 data, u32 mem_mask)
fbi.width = data & 0xfff; fbi.width = data & 0xfff;
if (data & 0xfff000) if (data & 0xfff000)
fbi.height = (data >> 12) & 0xfff; fbi.height = (data >> 12) & 0xfff;
/* fall through */ [[fallthrough]];
case io_vidOverlayDudx: case io_vidOverlayDudx:
case io_vidOverlayDvdy: case io_vidOverlayDvdy:
{ {

2
src/emu/debug/express.cpp
View File

@ -1484,7 +1484,7 @@ void parsed_expression::parse_symbol_or_number(parse_token &token, const char *&
default: default:
; // fall through ; // fall through
} }
// fall through [[fallthrough]];
default: default:
// check for a symbol match // check for a symbol match

1
src/lib/formats/aim_dsk.cpp
View File

@ -111,6 +111,7 @@ bool aim_format::load(io_generic *io, uint32_t form_factor, floppy_image *image)
raw_w(raw_track_data, 16, 0x8924); raw_w(raw_track_data, 16, 0x8924);
raw_w(raw_track_data, 16, 0x5555); raw_w(raw_track_data, 16, 0x5555);
data_count = 0; data_count = 0;
break;
// TELETEXT.AIM and others // TELETEXT.AIM and others
case 0xff: case 0xff:

2
src/lib/formats/imd_dsk.cpp
View File

@ -208,7 +208,7 @@ static floperr_t imd_write_indexed_sector(floppy_image_legacy *floppy, int head,
if (err) { if (err) {
return err; return err;
} }
// Fall through! [[fallthrough]];
case 1: case 1:
case 3: case 3:

1
src/lib/formats/sol_cas.cpp
View File

@ -322,6 +322,7 @@ static int sol20_handle_cassette(int16_t *buffer, const uint8_t *bytes)
sol20_scan_to_hex(bytes); sol20_scan_to_hex(bytes);
} }
} }
[[fallthrough]];
default: // everything else is ignored default: // everything else is ignored
sol20_scan_to_eol(bytes); sol20_scan_to_eol(bytes);
break; break;

2
src/lib/util/msdib.cpp
View File

@ -244,7 +244,7 @@ msdib_error dib_read_bitmap_header(
header.core.size); header.core.size);
return msdib_error::UNSUPPORTED_FORMAT; return msdib_error::UNSUPPORTED_FORMAT;
} }
// fall through [[fallthrough]];
case 40U: case 40U:
case 52U: case 52U:
case 56U: case 56U:

2
src/mame/audio/tvc.cpp
View File

@ -102,7 +102,7 @@ void tvc_sound_device::write(offs_t offset, uint8_t data)
{ {
case 1: case 1:
m_enabled = BIT(data, 4); m_enabled = BIT(data, 4);
// fall through [[fallthrough]];
case 0: case 0:
{ {

3
src/mame/drivers/ddenlovr.cpp
View File

@ -980,7 +980,7 @@ int ddenlovr_state::blit_draw( int src, int sx )
default: default:
log_draw_error(src, cmd); log_draw_error(src, cmd);
// fall through [[fallthrough]];
case BLIT_STOP: case BLIT_STOP:
return ((bit_addr + m_ddenlovr_blit_rom_bits - 1) / m_ddenlovr_blit_rom_bits) & 0xffffff; return ((bit_addr + m_ddenlovr_blit_rom_bits - 1) / m_ddenlovr_blit_rom_bits) & 0xffffff;
} }
@ -4334,6 +4334,7 @@ void htengoku_state::htengoku_coin_w(uint8_t data)
// popmessage("COINS %02x",data); // popmessage("COINS %02x",data);
#endif #endif
m_coins = data; m_coins = data;
break;
case 0x0d: break; // ff resets input port sequence? case 0x0d: break; // ff resets input port sequence?

25
src/mame/drivers/hng64.cpp
View File

@ -710,18 +710,25 @@ LVS-DG2
#include "cpu/z80/z80.h" #include "cpu/z80/z80.h"
#include "machine/nvram.h" #include "machine/nvram.h"
#define VERBOSE 1 #define LOG_GENERAL (1U << 0)
#define LOG_COMRW (1U << 1)
#define LOG_SNDCOM_UNKNWN (1U << 2)
#define LOG_DMA (1U << 3)
#define LOG_VREGS (1U << 4)
#define VERBOSE (LOG_GENERAL)
#include "logmacro.h" #include "logmacro.h"
uint32_t hng64_state::hng64_com_r(offs_t offset)
uint32_t hng64_state::hng64_com_r(offs_t offset, uint32_t mem_mask)
{ {
//LOG("com read (PC=%08x): %08x %08x = %08x\n", m_maincpu->pc(), (offset*4)+0xc0000000, mem_mask, m_idt7133_dpram[offset]); LOGMASKED(LOG_COMRW, "com read (PC=%08x): %08x %08x = %08x\n", m_maincpu->pc(), (offset*4)+0xc0000000, mem_mask, m_idt7133_dpram[offset]);
return m_idt7133_dpram[offset]; return m_idt7133_dpram[offset];
} }
void hng64_state::hng64_com_w(offs_t offset, uint32_t data, uint32_t mem_mask) void hng64_state::hng64_com_w(offs_t offset, uint32_t data, uint32_t mem_mask)
{ {
//LOG("com write (PC=%08x): %08x %08x = %08x\n", m_maincpu->pc(), (offset*4)+0xc0000000, mem_mask, data); LOGMASKED(LOG_COMRW, "com write (PC=%08x): %08x %08x = %08x\n", m_maincpu->pc(), (offset*4)+0xc0000000, mem_mask, data);
COMBINE_DATA(&m_idt7133_dpram[offset]); COMBINE_DATA(&m_idt7133_dpram[offset]);
} }
@ -776,7 +783,7 @@ void hng64_state::do_dma(address_space &space)
{ {
// check if this determines how long the crosshatch is visible for, we might need to put it on a timer. // check if this determines how long the crosshatch is visible for, we might need to put it on a timer.
//printf("Performing DMA Start %08x Len %08x Dst %08x\n", m_dma_start, m_dma_len, m_dma_dst); LOGMASKED(LOG_DMA, "Performing DMA Start %08x Len %08x Dst %08x\n", m_dma_start, m_dma_len, m_dma_dst);
while (m_dma_len >= 0) while (m_dma_len >= 0)
{ {
uint32_t dat; uint32_t dat;
@ -1049,7 +1056,7 @@ void hng64_state::hng64_sprite_clear_odd_w(offs_t offset, uint32_t data, uint32_
void hng64_state::hng64_vregs_w(offs_t offset, uint32_t data, uint32_t mem_mask) void hng64_state::hng64_vregs_w(offs_t offset, uint32_t data, uint32_t mem_mask)
{ {
// printf("hng64_vregs_w %02x, %08x %08x\n", offset * 4, data, mem_mask); LOGMASKED(LOG_DMA, "hng64_vregs_w %02x, %08x %08x\n", offset * 4, data, mem_mask);
COMBINE_DATA(&m_videoregs[offset]); COMBINE_DATA(&m_videoregs[offset]);
} }
@ -1062,7 +1069,7 @@ uint16_t hng64_state::main_sound_comms_r(offs_t offset)
case 0x06: case 0x06:
return sound_latch[1]; return sound_latch[1];
default: default:
//printf("%08x R\n",offset*2); LOGMASKED(LOG_SNDCOM_UNKNWN, "%08x R\n",offset*2);
break; break;
} }
return 0; return 0;
@ -1081,10 +1088,10 @@ void hng64_state::main_sound_comms_w(offs_t offset, uint16_t data, uint16_t mem_
case 0x08: case 0x08:
m_audiocpu->set_input_line(5, (data & 1) ? ASSERT_LINE : CLEAR_LINE); m_audiocpu->set_input_line(5, (data & 1) ? ASSERT_LINE : CLEAR_LINE);
if(data & 0xfe) if(data & 0xfe)
//printf("IRQ send %02x?\n",data); LOGMASKED(LOG_SNDCOM_UNKNWN, "IRQ send %02x?\n",data);
break; break;
default: default:
//printf("%02x %04x\n",offset*2,data); LOGMASKED(LOG_SNDCOM_UNKNWN, "%02x %04x\n",offset*2,data);
break; break;
} }
} }

4
src/mame/drivers/hp9845.cpp
View File

@ -2093,7 +2093,7 @@ uint16_t hp9845c_state::graphic_r(offs_t offset)
case 2: case 2:
// R6: data register with DMA TC // R6: data register with DMA TC
m_gv_dma_en = false; m_gv_dma_en = false;
// Intentional fall-through [[fallthrough]];
case 0: case 0:
// R4: data register // R4: data register
@ -2785,7 +2785,7 @@ uint16_t hp9845t_state::graphic_r(offs_t offset)
case 2: case 2:
// R6: data register with DMA TC // R6: data register with DMA TC
m_gv_dma_en = false; m_gv_dma_en = false;
// Intentional fall-through [[fallthrough]];
case 0: case 0:
// R4: data register // R4: data register

1
src/mame/drivers/huebler.cpp
View File

@ -286,6 +286,7 @@ WRITE_LINE_MEMBER(amu880_state::ctc_z2_w)
break; break;
case 6: case 6:
m_sio->rxa_w((m_cassette->input() > 0.04) ? 1 : 0); m_sio->rxa_w((m_cassette->input() > 0.04) ? 1 : 0);
break;
default: default:
break; break;
} }

143
src/mame/drivers/kas89.cpp
View File

@ -303,19 +303,19 @@ uint8_t kas89_state::mux_r()
{ {
switch(m_mux_data) switch(m_mux_data)
{ {
case 0x01: return m_pl[0]->read(); case 0x01: return m_pl[0]->read();
case 0x02: return m_pl[1]->read(); case 0x02: return m_pl[1]->read();
case 0x04: return m_pl[2]->read(); case 0x04: return m_pl[2]->read();
case 0x08: return m_pl[3]->read(); case 0x08: return m_pl[3]->read();
case 0x10: return m_pl[4]->read(); case 0x10: return m_pl[4]->read();
case 0x20: return m_pl[5]->read(); case 0x20: return m_pl[5]->read();
case 0x40: case 0x40:
{ {
m_lamps[37] = BIT(~m_svc->read(), 5); // Operator Key LAMP m_lamps[37] = BIT(~m_svc->read(), 5); // Operator Key LAMP
return m_svc->read(); return m_svc->read();
} }
case 0x80: return m_dsw->read(); // Polled at $162a through NMI routine case 0x80: return m_dsw->read(); // Polled at $162a through NMI routine
case 0x3f: return m_unk->read(); case 0x3f: return m_unk->read();
} }
logerror("Mux_data %02X\n", m_mux_data); logerror("Mux_data %02X\n", m_mux_data);
@ -420,91 +420,66 @@ void kas89_state::led_mux_select_w(uint8_t data)
m_leds_mux_selector = data; m_leds_mux_selector = data;
uint8_t i;
for ( uint8_t i = 0; i < 37; i++ ) for ( uint8_t i = 0; i < 37; i++ )
{ {
m_lamps[i] = 0; // All LEDs OFF m_lamps[i] = 0; // All LEDs OFF
} }
switch(data) if (BIT(data, 0))
{ {
case 0x00: m_lamps[11] = BIT(m_leds_mux_data, 0); // Number 11 LED
{ m_lamps[36] = BIT(m_leds_mux_data, 1); // Number 36 LED
for ( i = 0; i < 37; i++ ) m_lamps[13] = BIT(m_leds_mux_data, 2); // Number 13 LED
{ m_lamps[27] = BIT(m_leds_mux_data, 3); // Number 27 LED
m_lamps[i] = 0; // All LEDs OFF m_lamps[ 6] = BIT(m_leds_mux_data, 4); // Number 6 LED
} m_lamps[34] = BIT(m_leds_mux_data, 5); // Number 34 LED
} m_lamps[17] = BIT(m_leds_mux_data, 6); // Number 17 LED
m_lamps[25] = BIT(m_leds_mux_data, 7); // Number 25 LED
}
case 0x01: if (BIT(data, 1))
{ {
m_lamps[11] = BIT(m_leds_mux_data, 0); // Number 11 LED m_lamps[ 2] = BIT(m_leds_mux_data, 0); // Number 2 LED
m_lamps[36] = BIT(m_leds_mux_data, 1); // Number 36 LED m_lamps[21] = BIT(m_leds_mux_data, 1); // Number 21 LED
m_lamps[13] = BIT(m_leds_mux_data, 2); // Number 13 LED m_lamps[ 4] = BIT(m_leds_mux_data, 2); // Number 4 LED
m_lamps[27] = BIT(m_leds_mux_data, 3); // Number 27 LED m_lamps[19] = BIT(m_leds_mux_data, 3); // Number 19 LED
m_lamps[06] = BIT(m_leds_mux_data, 4); // Number 6 LED m_lamps[15] = BIT(m_leds_mux_data, 4); // Number 15 LED
m_lamps[34] = BIT(m_leds_mux_data, 5); // Number 34 LED m_lamps[32] = BIT(m_leds_mux_data, 5); // Number 32 LED
m_lamps[17] = BIT(m_leds_mux_data, 6); // Number 17 LED m_lamps[ 0] = BIT(m_leds_mux_data, 6); // Number 0 LED
m_lamps[25] = BIT(m_leds_mux_data, 7); // Number 25 LED m_lamps[26] = BIT(m_leds_mux_data, 7); // Number 26 LED
break; }
}
case 0x02: if (BIT(data, 2))
{ {
m_lamps[ 2] = BIT(m_leds_mux_data, 0); // Number 2 LED m_lamps[ 3] = BIT(m_leds_mux_data, 0); // Number 3 LED
m_lamps[21] = BIT(m_leds_mux_data, 1); // Number 21 LED m_lamps[35] = BIT(m_leds_mux_data, 1); // Number 35 LED
m_lamps[ 4] = BIT(m_leds_mux_data, 2); // Number 4 LED m_lamps[12] = BIT(m_leds_mux_data, 2); // Number 12 LED
m_lamps[19] = BIT(m_leds_mux_data, 3); // Number 19 LED m_lamps[28] = BIT(m_leds_mux_data, 3); // Number 28 LED
m_lamps[15] = BIT(m_leds_mux_data, 4); // Number 15 LED m_lamps[ 7] = BIT(m_leds_mux_data, 4); // Number 7 LED
m_lamps[32] = BIT(m_leds_mux_data, 5); // Number 32 LED m_lamps[29] = BIT(m_leds_mux_data, 5); // Number 29 LED
m_lamps[ 0] = BIT(m_leds_mux_data, 6); // Number 0 LED m_lamps[18] = BIT(m_leds_mux_data, 6); // Number 18 LED
m_lamps[26] = BIT(m_leds_mux_data, 7); // Number 26 LED }
break;
}
case 0x04: if (BIT(data, 3))
{ {
m_lamps[ 3] = BIT(m_leds_mux_data, 0); // Number 3 LED m_lamps[22] = BIT(m_leds_mux_data, 0); // Number 22 LED
m_lamps[35] = BIT(m_leds_mux_data, 1); // Number 35 LED m_lamps[ 9] = BIT(m_leds_mux_data, 1); // Number 9 LED
m_lamps[12] = BIT(m_leds_mux_data, 2); // Number 12 LED m_lamps[31] = BIT(m_leds_mux_data, 2); // Number 31 LED
m_lamps[28] = BIT(m_leds_mux_data, 3); // Number 28 LED m_lamps[14] = BIT(m_leds_mux_data, 3); // Number 14 LED
m_lamps[ 7] = BIT(m_leds_mux_data, 4); // Number 7 LED m_lamps[20] = BIT(m_leds_mux_data, 4); // Number 20 LED
m_lamps[29] = BIT(m_leds_mux_data, 5); // Number 29 LED m_lamps[ 1] = BIT(m_leds_mux_data, 5); // Number 1 LED
m_lamps[18] = BIT(m_leds_mux_data, 6); // Number 18 LED m_lamps[33] = BIT(m_leds_mux_data, 6); // Number 33 LED
break; }
}
case 0x08: if (BIT(data, 4))
{ {
m_lamps[22] = BIT(m_leds_mux_data, 0); // Number 22 LED m_lamps[16] = BIT(m_leds_mux_data, 0); // Number 16 LED
m_lamps[ 9] = BIT(m_leds_mux_data, 1); // Number 9 LED m_lamps[24] = BIT(m_leds_mux_data, 1); // Number 24 LED
m_lamps[31] = BIT(m_leds_mux_data, 2); // Number 31 LED m_lamps[ 5] = BIT(m_leds_mux_data, 2); // Number 5 LED
m_lamps[14] = BIT(m_leds_mux_data, 3); // Number 14 LED m_lamps[10] = BIT(m_leds_mux_data, 3); // Number 10 LED
m_lamps[20] = BIT(m_leds_mux_data, 4); // Number 20 LED m_lamps[23] = BIT(m_leds_mux_data, 4); // Number 23 LED
m_lamps[ 1] = BIT(m_leds_mux_data, 5); // Number 1 LED m_lamps[ 8] = BIT(m_leds_mux_data, 5); // Number 8 LED
m_lamps[33] = BIT(m_leds_mux_data, 6); // Number 33 LED m_lamps[30] = BIT(m_leds_mux_data, 6); // Number 30 LED
break;
}
case 0x10:
{
m_lamps[16] = BIT(m_leds_mux_data, 0); // Number 16 LED
m_lamps[24] = BIT(m_leds_mux_data, 1); // Number 24 LED
m_lamps[ 5] = BIT(m_leds_mux_data, 2); // Number 5 LED
m_lamps[10] = BIT(m_leds_mux_data, 3); // Number 10 LED
m_lamps[23] = BIT(m_leds_mux_data, 4); // Number 23 LED
m_lamps[ 8] = BIT(m_leds_mux_data, 5); // Number 8 LED
m_lamps[30] = BIT(m_leds_mux_data, 6); // Number 30 LED
break;
}
case 0xff:
{
for ( i = 0; i < 37; i++ )
{
m_lamps[i] = 1; // All LEDs ON
}
}
} }
} }

3
src/mame/drivers/spectrum.cpp
View File

@ -721,7 +721,8 @@ void spectrum_state::init_spectrum()
switch (m_ram->size()) switch (m_ram->size())
{ {
case 48*1024: case 48*1024:
m_specmem->space(AS_PROGRAM).install_ram(0x8000, 0xffff, nullptr); // Fall through m_specmem->space(AS_PROGRAM).install_ram(0x8000, 0xffff, nullptr);
[[fallthrough]];
case 16*1024: case 16*1024:
m_specmem->space(AS_PROGRAM).install_ram(0x5b00, 0x7fff, nullptr); m_specmem->space(AS_PROGRAM).install_ram(0x5b00, 0x7fff, nullptr);
} }

2
src/mame/drivers/svision.cpp
View File

@ -30,7 +30,7 @@ TIMER_CALLBACK_MEMBER(svision_state::svision_pet_timer)
{ {
m_pet.input = m_joy2->read(); m_pet.input = m_joy2->read();
} }
/* fall through */ [[fallthrough]];
case 0x02: case 0x04: case 0x06: case 0x08: case 0x02: case 0x04: case 0x06: case 0x08:
case 0x0a: case 0x0c: case 0x0e: case 0x0a: case 0x0c: case 0x0e:

2
src/mame/drivers/x07.cpp
View File

@ -1135,7 +1135,7 @@ uint8_t x07_state::x07_io_r(offs_t offset)
break; break;
case 0xf6: case 0xf6:
if (m_cass_motor) m_regs_r[6] |= 4; if (m_cass_motor) m_regs_r[6] |= 4;
//fall through [[fallthrough]];
case 0xf0: case 0xf0:
case 0xf1: case 0xf1:
case 0xf3: case 0xf3:

2
src/mame/includes/hng64.h
View File

@ -326,7 +326,7 @@ private:
float m_lightStrength; float m_lightStrength;
float m_lightVector[3]; float m_lightVector[3];
uint32_t hng64_com_r(offs_t offset); uint32_t hng64_com_r(offs_t offset, uint32_t mem_mask = ~0);
void hng64_com_w(offs_t offset, uint32_t data, uint32_t mem_mask = ~0); void hng64_com_w(offs_t offset, uint32_t data, uint32_t mem_mask = ~0);
void hng64_com_share_w(offs_t offset, uint8_t data); void hng64_com_share_w(offs_t offset, uint8_t data);
uint8_t hng64_com_share_r(offs_t offset); uint8_t hng64_com_share_r(offs_t offset);

1
src/mame/machine/iteagle_fpga.cpp
View File

@ -911,6 +911,7 @@ void iteagle_periph_device::ctrl_w(offs_t offset, uint32_t data, uint32_t mem_ma
if (ACCESSING_BITS_8_15) { if (ACCESSING_BITS_8_15) {
m_rtc_regs[m_ctrl_regs[0x70/4]&0xff] = (data>>8)&0xff; m_rtc_regs[m_ctrl_regs[0x70/4]&0xff] = (data>>8)&0xff;
} }
break;
default: default:
break; break;
} }

1
src/mame/machine/rmnimbus.cpp
View File

@ -1075,6 +1075,7 @@ uint8_t rmnimbus_state::scsi_r(offs_t offset)
case 0x08 : case 0x08 :
result = m_scsi_data_in->read(); result = m_scsi_data_in->read();
hdc_post_rw(); hdc_post_rw();
break;
default: default:
break; break;
} }

2
src/mame/video/dkong.cpp
View File

@ -945,7 +945,7 @@ VIDEO_START_MEMBER(dkong_state,dkong)
m_screen->register_screen_bitmap(m_bg_bits); m_screen->register_screen_bitmap(m_bg_bits);
m_gfx3 = memregion("gfx3")->base(); m_gfx3 = memregion("gfx3")->base();
m_gfx3_len = memregion("gfx3")->bytes(); m_gfx3_len = memregion("gfx3")->bytes();
/* fall through */ [[fallthrough]];
case HARDWARE_TKG04: case HARDWARE_TKG04:
case HARDWARE_TKG02: case HARDWARE_TKG02:
m_bg_tilemap = &machine().tilemap().create(*m_gfxdecode, tilemap_get_info_delegate(*this, FUNC(dkong_state::dkong_bg_tile_info)), TILEMAP_SCAN_ROWS, 8, 8, 32, 32); m_bg_tilemap = &machine().tilemap().create(*m_gfxdecode, tilemap_get_info_delegate(*this, FUNC(dkong_state::dkong_bg_tile_info)), TILEMAP_SCAN_ROWS, 8, 8, 32, 32);

1
src/mame/video/k007342.cpp
View File

@ -169,6 +169,7 @@ void k007342_device::vreg_w(offs_t offset, uint8_t data)
break; break;
case 0x06: /* scroll y (register 1) */ case 0x06: /* scroll y (register 1) */
m_scrolly[1] = data; m_scrolly[1] = data;
break;
case 0x07: /* unused */ case 0x07: /* unused */
break; break;
} }

8
src/mame/video/rmnimbus.cpp
View File

@ -22,13 +22,13 @@
operation by disassembling the Nimbus bios and by writing experemental operation by disassembling the Nimbus bios and by writing experemental
code on the real machine. code on the real machine.
*/ */
#include <functional>
#include "emu.h" #include "emu.h"
#include "includes/rmnimbus.h"
#include "debugger.h" #include "debugger.h"
#include "debug/debugcon.h" #include "debug/debugcon.h"
#include "includes/rmnimbus.h"
#include <functional>
#define WIDTH_MASK 0x07 #define WIDTH_MASK 0x07

2
src/osd/modules/input/input_sdlcommon.cpp
View File

@ -122,7 +122,7 @@ void sdl_event_manager::process_window_event(running_machine &machine, SDL_Event
case SDL_WINDOWEVENT_ENTER: case SDL_WINDOWEVENT_ENTER:
m_mouse_over_window = 1; m_mouse_over_window = 1;
/* fall through */ [[fallthrough]];
case SDL_WINDOWEVENT_FOCUS_GAINED: case SDL_WINDOWEVENT_FOCUS_GAINED:
case SDL_WINDOWEVENT_EXPOSED: case SDL_WINDOWEVENT_EXPOSED:
case SDL_WINDOWEVENT_MAXIMIZED: case SDL_WINDOWEVENT_MAXIMIZED: