Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-30 11:50:30 +03:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Merge pull request #1150 from ajrhacker/valid_verbose

Browse Source 
Validity checking improvements
This commit is contained in:
Vas Crabb 2016-07-27 23:32:20 +10:00 committed by GitHub
commit b48ada64c5
6 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/emu/attotime.h
View File

@ -120,7 +120,7 @@ public:
/** @return the seconds portion. */ /** @return the seconds portion. */
constexpr seconds_t seconds() const { return m_seconds; } constexpr seconds_t seconds() const { return m_seconds; }
static constexpr attotime from_double(double _time); static attotime from_double(double _time);
static attotime from_ticks(UINT64 ticks, UINT32 frequency); static attotime from_ticks(UINT64 ticks, UINT32 frequency);
/** Create an attotime from a integer count of seconds @seconds */ /** Create an attotime from a integer count of seconds @seconds */
static constexpr attotime from_seconds(INT32 seconds) { return attotime(seconds, 0); } static constexpr attotime from_seconds(INT32 seconds) { return attotime(seconds, 0); }
@ -376,7 +376,7 @@ inline attotime attotime::from_ticks(UINT64 ticks, UINT32 frequency)
} }
/** Create an attotime from floating point count of seconds @p _time */ /** Create an attotime from floating point count of seconds @p _time */
inline constexpr attotime attotime::from_double(double _time) inline attotime attotime::from_double(double _time)
{ {
seconds_t secs = floor(_time); seconds_t secs = floor(_time);
_time -= double(secs); _time -= double(secs);

1
src/emu/dimemory.cpp
View File

@ -9,7 +9,6 @@
***************************************************************************/ ***************************************************************************/
#include "emu.h" #include "emu.h"
#include "validity.h"
//************************************************************************** //**************************************************************************

1
src/emu/divtlb.cpp
View File

@ -10,7 +10,6 @@
#include "emu.h" #include "emu.h"
#include "divtlb.h" #include "divtlb.h"
#include "validity.h"

8
src/emu/validity.cpp
View File

@ -270,6 +270,10 @@ void validity_checker::validate_end()
void validity_checker::validate_one(const game_driver &driver) void validity_checker::validate_one(const game_driver &driver)
{ {
// help verbose validation detect configuration-related crashes
if (m_print_verbose)
output_via_delegate(OSD_OUTPUT_CHANNEL_ERROR, "Validating driver %s (%s)...\n", driver.name, core_filename_extract_base(driver.source_file).c_str());
// set the current driver // set the current driver
m_current_driver = &driver; m_current_driver = &driver;
m_current_config = nullptr; m_current_config = nullptr;
@ -303,7 +307,9 @@ void validity_checker::validate_one(const game_driver &driver)
// if we had warnings or errors, output // if we had warnings or errors, output
if (m_errors > start_errors || m_warnings > start_warnings || !m_verbose_text.empty()) if (m_errors > start_errors || m_warnings > start_warnings || !m_verbose_text.empty())
{ {
output_via_delegate(OSD_OUTPUT_CHANNEL_ERROR, "Driver %s (file %s): %d errors, %d warnings\n", driver.name, core_filename_extract_base(driver.source_file).c_str(), m_errors - start_errors, m_warnings - start_warnings); if (!m_print_verbose)
output_via_delegate(OSD_OUTPUT_CHANNEL_ERROR, "Driver %s (file %s): ", driver.name, core_filename_extract_base(driver.source_file).c_str());
output_via_delegate(OSD_OUTPUT_CHANNEL_ERROR, "%d errors, %d warnings\n", m_errors - start_errors, m_warnings - start_warnings);
if (m_errors > start_errors) if (m_errors > start_errors)
output_indented_errors(m_error_text, "Errors"); output_indented_errors(m_error_text, "Errors");
if (m_warnings > start_warnings) if (m_warnings > start_warnings)

2
src/emu/validity.h
View File

@ -51,7 +51,7 @@ public:
int region_length(const char *tag) { return m_region_map.find(tag)->second; } int region_length(const char *tag) { return m_region_map.find(tag)->second; }
// generic registry of already-checked stuff // generic registry of already-checked stuff
bool already_checked(const char *string) { return m_already_checked.insert(string).second; } bool already_checked(const char *string) { return !m_already_checked.insert(string).second; }
// osd_output interface // osd_output interface

1
src/mame/machine/slapstic.cpp
View File

@ -182,7 +182,6 @@
#include "includes/slapstic.h" #include "includes/slapstic.h"
#include "validity.h"
extern const device_type SLAPSTIC = &device_creator<atari_slapstic_device>; extern const device_type SLAPSTIC = &device_creator<atari_slapstic_device>;