Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-26 10:13:37 +03:00
Code Issues Actions 29 Packages Projects Releases Wiki Activity

system1: no need for m_videomode_prev variable

Browse Source
This commit is contained in:
hap 2024-11-11 13:45:31 +01:00
parent eec8a5b106
commit ba90d9bf3d
3 changed files with 53 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/mame/sega/system1.cpp
View File

@ -337,11 +337,11 @@ void system1_state::machine_start()
}
save_item(NAME(m_adjust_cycles));
save_item(NAME(m_videomode_prev));
save_item(NAME(m_mcu_control));
save_item(NAME(m_nob_maincpu_latch));
save_item(NAME(m_nob_mcu_latch));
save_item(NAME(m_nob_mcu_status));
save_item(NAME(m_nobb_inport23_step));
}
@ -376,14 +376,14 @@ void system1_state::adjust_cycles(u8 data)
*
*************************************/
void system1_state::bank44_custom_w(u8 data, u8 prevdata)
void system1_state::bank44_custom_w(u8 data)
{
// bank bits are bits 6 and 2
m_bank1->set_entry(((data & 0x40) >> 5) | ((data & 0x04) >> 2));
}
void system1_state::bank0c_custom_w(u8 data, u8 prevdata)
void system1_state::bank0c_custom_w(u8 data)
{
// bank bits are bits 3 and 2
m_bank1->set_entry((data & 0x0c) >> 2);
@ -404,8 +404,7 @@ void system1_state::videomode_w(u8 data)
// handle any custom banking or other stuff
if (m_videomode_custom != nullptr)
(this->*m_videomode_custom)(data, m_videomode_prev);
m_videomode_prev = data;
(this->*m_videomode_custom)(data);
// remaining signals are video-related
common_videomode_w(data);
@ -729,7 +728,7 @@ u8 system1_state::nobb_inport1c_r()
u8 system1_state::nobb_inport22_r()
{
// logerror("IN $22 : pc = %04x - data = %02x\n",m_maincpu->pc(),nobb_inport17_step);
return(0);//nobb_inport17_step);
return(0); // nobb_inport17_step;
}
u8 system1_state::nobb_inport23_r()

11
src/mame/sega/system1.h
View File

@ -111,13 +111,12 @@ public:
protected:
virtual void machine_start() override ATTR_COLD;
virtual void machine_reset() override ATTR_COLD { };
virtual void machine_reset() override ATTR_COLD { }
virtual void video_start() override ATTR_COLD;
// video related
std::unique_ptr<u8[]> m_videoram;
void (system1_state::*m_videomode_custom)(u8 data, u8 prevdata);
u8 m_videomode_prev = 0;
void (system1_state::*m_videomode_custom)(u8 data);
std::unique_ptr<u8[]> m_mix_collide;
u8 m_mix_collide_summary = 0;
std::unique_ptr<u8[]> m_sprite_collide;
@ -134,7 +133,7 @@ protected:
u8 m_nob_maincpu_latch = 0;
u8 m_nob_mcu_latch = 0;
u8 m_nob_mcu_status = 0;
int m_nobb_inport23_step = 0;
u8 m_nobb_inport23_step = 0;
// video handlers
void common_videomode_w(u8 data);
@ -189,8 +188,8 @@ protected:
// misc functions
TIMER_DEVICE_CALLBACK_MEMBER(soundirq_gen);
TIMER_DEVICE_CALLBACK_MEMBER(mcu_t0_callback);
void bank44_custom_w(u8 data, u8 prevdata);
void bank0c_custom_w(u8 data, u8 prevdata);
void bank44_custom_w(u8 data);
void bank0c_custom_w(u8 data);
// devices
required_device<z80_device> m_maincpu;

2
src/mame/sega/system1_v.cpp
View File

@ -215,7 +215,7 @@ void system1_state::video_start_common(int pagecount)
// allocate a temporary bitmap for sprite rendering
m_screen->register_screen_bitmap(m_sprite_bitmap);
// register for save stats
// register for save states
save_item(NAME(m_video_mode));
save_item(NAME(m_mix_collide_summary));
save_item(NAME(m_sprite_collide_summary));