Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-07-07 02:50:50 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

add proper flipscreen support to himesiki.cpp, previous support was incorrectly hooked up to the scroll registers (androidp exposed this bug)

Browse Source
This commit is contained in:
David Haywood 2016-03-14 19:42:00 +00:00
parent 41c8a9f6fa
commit bbb9fd448f
3 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mame/drivers/himesiki.cpp
View File

@ -103,7 +103,10 @@ WRITE8_MEMBER(himesiki_state::himesiki_rombank_w)
{
membank("bank1")->set_entry(((data & 0x0c) >> 2));
if (data & 0xf3)
m_flipscreen = (data & 0x10)>>4;
flip_screen_set(m_flipscreen);
if (data & 0xe3)
logerror("p06_w %02x\n", data);
}

1
src/mame/includes/himesiki.h
View File

@ -38,7 +38,6 @@ public:
DECLARE_WRITE8_MEMBER(himesiki_bg_ram_w);
DECLARE_WRITE8_MEMBER(himesiki_scrollx_w);
DECLARE_WRITE8_MEMBER(himesiki_scrolly_w);
// DECLARE_WRITE8_MEMBER(himesiki_flip_w);
TILE_GET_INFO_MEMBER(get_bg_tile_info);
virtual void machine_start() override;
virtual void machine_reset() override;

17
src/mame/video/himesiki.cpp
View File

@ -43,17 +43,6 @@ WRITE8_MEMBER(himesiki_state::himesiki_scrolly_w)
m_scrolly = data;
}
#if 0 // this can't be flipscreen (android uses it for scroll, same PCB)
WRITE8_MEMBER(himesiki_state::himesiki_flip_w)
{
m_flipscreen = data & 0xc0;
flip_screen_set(m_flipscreen);
if (data & 0x3f)
logerror("p08_w %02x\n",data);
}
#endif
void himesiki_state::himesiki_draw_sprites( bitmap_ind16 &bitmap, const rectangle &cliprect )
{
UINT8 *spriteram;
@ -77,7 +66,7 @@ void himesiki_state::himesiki_draw_sprites( bitmap_ind16 &bitmap, const rectangl
if (m_flipscreen)
{
y = (y + 33) & 0xff;
y = (y - 31) & 0xff;
x = 224 - x;
fx ^= 4;
fy = 1;
@ -116,7 +105,7 @@ void himesiki_state::himesiki_draw_sprites( bitmap_ind16 &bitmap, const rectangl
if (m_flipscreen)
{
y += 49;
y = (y - 15) &0xff;
x = 240 - x;
f = 1;
}
@ -135,7 +124,7 @@ UINT32 himesiki_state::screen_update_himesiki(screen_device &screen, bitmap_ind1
{
int x = -(m_scrollx[0] << 8 | m_scrollx[1]) & 0x1ff;
m_bg_tilemap->set_scrolldx(x, x);
m_bg_tilemap->set_scrolldy(-m_scrolly, -m_scrolly);
m_bg_tilemap->set_scrolldy(-m_scrolly, -m_scrolly-64);
m_bg_tilemap->draw(screen, bitmap, cliprect, TILEMAP_DRAW_OPAQUE, 0);
himesiki_draw_sprites(bitmap, cliprect);