Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-07 13:23:50 +03:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

ymz280b.cpp: Better fix for signed arithmetic issue

Browse Source
This commit is contained in:
AJR 2020-07-11 21:27:19 -04:00
parent 041382375a
commit c296555db1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/devices/sound/ymz280b.cpp
View File

@ -40,8 +40,8 @@
#define MAX_SAMPLE_CHUNK 10000 #define MAX_SAMPLE_CHUNK 10000
#define FRAC_BITS 9 static constexpr unsigned FRAC_BITS = 9;
#define FRAC_ONE (1 << FRAC_BITS) static constexpr s32 FRAC_ONE = 1 << FRAC_BITS;
//#define INTERNAL_BUFFER_SIZE (1 << 15) //#define INTERNAL_BUFFER_SIZE (1 << 15)
#define INTERNAL_SAMPLE_RATE (m_master_clock * 2.0) #define INTERNAL_SAMPLE_RATE (m_master_clock * 2.0)
@ -452,7 +452,7 @@ void ymz280b_device::sound_stream_update(sound_stream &stream, stream_sample_t *
/* interpolate */ /* interpolate */
while (remaining > 0 && voice->output_pos < FRAC_ONE) while (remaining > 0 && voice->output_pos < FRAC_ONE)
{ {
int interp_sample = (((s32)prev * (FRAC_ONE - voice->output_pos)) + ((s32)curr * voice->output_pos)) >> FRAC_BITS; int interp_sample = ((s32(prev) * (FRAC_ONE - voice->output_pos)) + (s32(curr) * voice->output_pos)) >> FRAC_BITS;
*ldest++ += interp_sample * lvol; *ldest++ += interp_sample * lvol;
*rdest++ += interp_sample * rvol; *rdest++ += interp_sample * rvol;
voice->output_pos += voice->output_step; voice->output_pos += voice->output_step;
@ -516,7 +516,7 @@ void ymz280b_device::sound_stream_update(sound_stream &stream, stream_sample_t *
/* interpolate */ /* interpolate */
while (remaining > 0 && voice->output_pos < FRAC_ONE) while (remaining > 0 && voice->output_pos < FRAC_ONE)
{ {
int interp_sample = (((s32)prev * (FRAC_ONE - voice->output_pos)) + ((s32)curr * voice->output_pos)) >> FRAC_BITS; int interp_sample = ((s32(prev) * (FRAC_ONE - voice->output_pos)) + (s32(curr) * voice->output_pos)) >> FRAC_BITS;
*ldest++ += interp_sample * lvol; *ldest++ += interp_sample * lvol;
*rdest++ += interp_sample * rvol; *rdest++ += interp_sample * rvol;
voice->output_pos += voice->output_step; voice->output_pos += voice->output_step;