Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-27 14:49:11 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed a potential buffer overrun in the code that reads headers for the CoCo JVC disk image format

Browse Source
This commit is contained in:
Nathan Woods 2016-09-13 06:50:08 -04:00
parent 9b88a353ba
commit c51de7aa95
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/lib/formats/jvc_dsk.cpp
View File

@ -37,16 +37,19 @@ const char *jvc_format::extensions() const
bool jvc_format::parse_header(io_generic *io, int &header_size, int &tracks, int &heads, int &sectors, int &sector_size, int &base_sector_id)
{
// The JVC format has a header whose size is the size of the image modulo 256. Currently, we only
// handle up to five header bytes
UINT64 size = io_generic_size(io);
header_size = size % 256;
UINT8 header[5];
// if we know that this is a header of a bad size, we can fail
// immediately; otherwise read the header
if (header_size >= sizeof(header))
return false;
if (header_size > 0)
io_generic_read(io, header, 0, header_size);
if (header_size > 5)
return false;
// default values
heads = 1;
sectors = 18;