Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-10-06 17:08:28 +03:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

MT #7309 (nw)

Browse Source 
The situation here with interrupts being acknowledged at a time nominally preceding the condition that triggered them suggests a disturbingly general problem with MAME's CPU scheduling. However, it should only affect machines in which such interrupt vectors are calculated from free-running counters (as this hardware does) rather than the more normal priority encoding of latched requests.
This commit is contained in:
AJR 2019-05-02 20:31:45 -04:00
parent 46d30e2381
commit c647150368
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mame/includes/mw8080bw.h
View File

@ -187,6 +187,8 @@ private:
emu_timer *m_interrupt_timer; emu_timer *m_interrupt_timer;
emu_timer *m_maze_tone_timer; emu_timer *m_maze_tone_timer;
attotime m_interrupt_time;
DECLARE_READ8_MEMBER(mw8080bw_shift_result_rev_r); DECLARE_READ8_MEMBER(mw8080bw_shift_result_rev_r);
DECLARE_READ8_MEMBER(mw8080bw_reversable_shift_result_r); DECLARE_READ8_MEMBER(mw8080bw_reversable_shift_result_r);
DECLARE_WRITE8_MEMBER(mw8080bw_reversable_shift_count_w); DECLARE_WRITE8_MEMBER(mw8080bw_reversable_shift_count_w);

7
src/mame/machine/mw8080bw.cpp
View File

@ -52,6 +52,8 @@ TIMER_CALLBACK_MEMBER(mw8080bw_state::interrupt_trigger)
m_maincpu->set_input_line(0, ASSERT_LINE); m_maincpu->set_input_line(0, ASSERT_LINE);
m_interrupt_time = machine().time();
/* set up for next interrupt */ /* set up for next interrupt */
uint8_t next_counter; uint8_t next_counter;
int next_vblank; int next_vblank;
@ -74,6 +76,9 @@ TIMER_CALLBACK_MEMBER(mw8080bw_state::interrupt_trigger)
IRQ_CALLBACK_MEMBER(mw8080bw_state::interrupt_vector) IRQ_CALLBACK_MEMBER(mw8080bw_state::interrupt_vector)
{ {
int vpos = m_screen->vpos(); int vpos = m_screen->vpos();
// MAME scheduling quirks cause this to happen more often than you might think, in fact far too often
if (machine().time() < m_interrupt_time)
vpos++;
uint8_t counter = vpos_to_vysnc_chain_counter(vpos); uint8_t counter = vpos_to_vysnc_chain_counter(vpos);
uint8_t vector = 0xc7 | ((counter & 0x40) >> 2) | ((~counter & 0x40) >> 3); uint8_t vector = 0xc7 | ((counter & 0x40) >> 2) | ((~counter & 0x40) >> 3);
@ -92,6 +97,8 @@ void mw8080bw_state::mw8080bw_start_interrupt_timer( )
{ {
int vpos = vysnc_chain_counter_to_vpos(MW8080BW_INT_TRIGGER_COUNT_1, MW8080BW_INT_TRIGGER_VBLANK_1); int vpos = vysnc_chain_counter_to_vpos(MW8080BW_INT_TRIGGER_COUNT_1, MW8080BW_INT_TRIGGER_VBLANK_1);
m_interrupt_timer->adjust(m_screen->time_until_pos(vpos)); m_interrupt_timer->adjust(m_screen->time_until_pos(vpos));
m_interrupt_time = attotime::zero;
} }